[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-10344: ---------------------------------------- Summary: consider refactor how AS7 management service is done to avoid eager loading (was: CLONE - Workspace set to default even if set differently) Description: AS71 and AS70 management interfaces points back to as.core causing eager loading. could move the as.core interfaces into a shared bundle instead or not use declarative services for AS7. Need to consider the options. was: Before I installed JBoss Tools into Eclipse workspaces worked fine - Eclipse asks which workspace to use at start time. Once I installed JBoss Tools, Eclipse stopped asking me for workspace location on startup. Even if I change the workspace it falls back to default on the next start of Eclipse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Rob Cernich commented on JBIDE-10344: ------------------------------------- You should be able to correct this by removing the immediate flag from the service declarations in the jboss-management-service.xml files. The services should only be loaded when they are picked up by as.core. I've modified the binaries in my Eclipse install and I haven't had any problems. You might also want to make the names of the services unique (there's a warning in the Eclipse log, two services with the same name). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10344: ------------------------------------------ I also disabled the immediate activation on the binary plugin (unzipped, modified, repacked). Starting/Stopping the as7 adapter works perfectly but the IDE still skips the workspace selection. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Rob Cernich commented on JBIDE-10344: ------------------------------------- Hey Andre, you may have to start Eclipse with -clean after modifying the plugins. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-10344: ------------------------------------- Attachment: start-osgi-services-lazy.patch I uncommented the wait loop in the activator, that waited for the workspace selection to become set and changed both services to get activated lazyly. Worked perfectly for me. @Rob: please verify my patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10344: ------------------------------------------ The following statement is not precise: {quote} convert it to a non-declarative service and load it lazily {quote} The management service is still a declarative service. It is declared via org.jboss.ide.eclipse.as.management.as71/META-INF/jboss-management-service.xml {code} <?xml version="1.0" encoding="UTF-8"?> <scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" enabled="true" immediate="false" name="org.jboss.ide.eclipse.as.management.as71.service"> <implementation class="org.jboss.ide.eclipse.as.internal.management.as71.JBoss71ManagerService"/> <service> <provide interface="org.jboss.ide.eclipse.as.management.core.IJBoss7ManagerService"/> </service> <property name="as.version" type="String" value="710.beta1"/> </scr:component> {code} It is now loaded lazyly with the following addition to the service declaration: {code} immediate="false" {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10344?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-10344 at 1/6/12 8:29 AM: ------------------------------------------------------------------ The following statement is not precise: {quote} * convert it to a non-declarative service and load it lazily {quote} The management service is still a declarative service. It is declared via *org.jboss.ide.eclipse.as.management.as71/META-INF/jboss-management-service.xml* {code} <?xml version="1.0" encoding="UTF-8"?> <scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" enabled="true" immediate="false" name="org.jboss.ide.eclipse.as.management.as71.service"> <implementation class="org.jboss.ide.eclipse.as.internal.management.as71.JBoss71ManagerService"/> <service> <provide interface="org.jboss.ide.eclipse.as.management.core.IJBoss7ManagerService"/> </service> <property name="as.version" type="String" value="710.beta1"/> </scr:component> {code} It is now loaded lazyly with the following addition to the service declaration: {code} immediate="false" {code} was (Author: adietish): The following statement is not precise: {quote} convert it to a non-declarative service and load it lazily {quote} The management service is still a declarative service. It is declared via *org.jboss.ide.eclipse.as.management.as71/META-INF/jboss-management-service.xml* {code} <?xml version="1.0" encoding="UTF-8"?> <scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" enabled="true" immediate="false" name="org.jboss.ide.eclipse.as.management.as71.service"> <implementation class="org.jboss.ide.eclipse.as.internal.management.as71.JBoss71ManagerService"/> <service> <provide interface="org.jboss.ide.eclipse.as.management.core.IJBoss7ManagerService"/> </service> <property name="as.version" type="String" value="710.beta1"/> </scr:component> {code} It is now loaded lazyly with the following addition to the service declaration: {code} immediate="false" {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira