[
https://issues.jboss.org/browse/JBIDE-24114?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-24114:
------------------------------------
From Martin: {quote}Can you think of any downside?{quote}
From Max: {quote}Unless tycho changed a lot then base check requires
internet and takes time check. Several seconds overhead.{quote}
So, each build incurs some extra time as the build hits the reference baseline URL and
downloads metadata against which to compare the current bits. But I think "several
seconds" is a small price to pay for having PRs & local builds fail faster when
people forget to bump versions.
[parent pom] do not skip baseline comparison check when
-DskipTests=true
------------------------------------------------------------------------
Key: JBIDE-24114
URL:
https://issues.jboss.org/browse/JBIDE-24114
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.4.4.AM1, 4.5.0.AM1
Reporter: Nick Boldt
Assignee: Jeff MAURY
Fix For: 4.4.4.AM2, 4.5.0.AM1
Currently, when you build with -DskipTests, the baseline checks are also skipped. This
means that if you make a change to a file in a plugin, and build it locally to see if
anything breaks, but forget to bump the version of the plugin and its containing feature,
you won't see the baseline check failure until it's built in Jenkins and someone
like me complains about it to you directly.
This happened recently in the 4.4.x branch for changes to openshift and base.
So I propose this change in parent pom for 4.4.x and master branches:
{code}
-
<skipBaselineComparison>${skipTestsOrITests}</skipBaselineComparison>
+ <skipBaselineComparison>false</skipBaselineComparison>
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)