11:44 a.m.
Daniel Azarov created JBIDE-11136:
-------------------------------------
Summary: Wrong quick fix for empty tag <class> in beans.xml
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1, 3.3.0.CR1
Attachments: empty_tag_class.png
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:44 a.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Daniel Azarov updated JBIDE-11136:
----------------------------------
Attachment: empty_tag_class.png
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1, 3.3.0.CR1
Attachments: empty_tag_class.png
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:49 a.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Daniel Azarov updated JBIDE-11136:
----------------------------------
Description:
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name [JSR-299
§5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1, 3.3.0.CR1
Attachments: empty_tag_class.png
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:31 p.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Daniel Azarov updated JBIDE-11136:
----------------------------------
Attachment: JBIDE-11136.patch
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1, 3.3.0.CR1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:53 p.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Alexey Kazakov resolved JBIDE-11136.
------------------------------------
Assignee: Daniel Azarov (was: Alexey Kazakov)
Fix Version/s: (was: 3.3.0.CR1)
Resolution: Done
Fixed
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:03 a.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič commented on JBIDE-11136:
-------------------------------------------
Daniel, Alexey, so what is the expected behaviour when
"<class> </class>" is in beans.xml? There should be error marker
but no quick fix should be provided? Because I have just tried to reproduce on JBT 3.3.0
Beta1c and quick fix is still there. Only change from previous Beta1 builds is replacing
the message: Create '<class> </class>' CDI Bean Class --->
Create CDI Bean Class '<class> </class>'.
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:51 a.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Daniel Azarov commented on JBIDE-11136:
---------------------------------------
Expected behavior is:
1.in case when string in tag <class> can be a Java Class name and there is no Java
Class with that name - offer to create such Java Class.
2. If not - not to offer that. (empty tag <class> is a part of 2.)
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
noon
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Daniel Azarov commented on JBIDE-11136:
---------------------------------------
it was fixed in trunk and in branches/jbosstools-3.3.0.Beta1/
may be we should wait when that changes will become a new build/installer
By the way, the changes what you mentioned were made long time ago (1-2 months)
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:11 p.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Daniel Azarov commented on JBIDE-11136:
---------------------------------------
JBT 3.3.0 Beta1c does not have this changes, we should wait for JBT 3.3.0 Beta1d
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:24 a.m.
[
https://issues.jboss.org/browse/JBIDE-11136?page=com.atlassian.jira.plugi...
]
Jaroslav Jankovič closed JBIDE-11136.
-------------------------------------
Verified in JBT 3.3.0 Beta1e.
Wrong quick fix for empty tag <class> in beans.xml
--------------------------------------------------
Key: JBIDE-11136
URL: https://issues.jboss.org/browse/JBIDE-11136
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: CDI
Affects Versions: 3.3.0.Beta1
Reporter: Daniel Azarov
Assignee: Daniel Azarov
Fix For: 3.3.0.Beta1
Attachments: empty_tag_class.png, JBIDE-11136.patch
Test case:
Execute:
1. Create CDI project
2. Create beans.xml
{code}
<?xml version="1.0"?>
<beans xmlns="http://java.sun.com/xml/ns/javaee"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
http://jboss.org/schema/cdi/beans_1_0.xsd">
<alternatives>
<class> </class>
</alternatives>
</beans>
{code}
3. Save file
ASSERT: There is a problem marker "There is no class with the specified name
[JSR-299 §5.1.1]" for tag <class> </class>
EXECUTE: Point mouse to marked text then hold
ASSERT: There should be no Quick Fix "Create CDI Bean Class" for such cases
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5134
days inactive
5147
days old
jbosstools-issues@lists.jboss.org
9 comments
3 participants
participants (3)
-
Alexey Kazakov (JIRA) -
Daniel Azarov (JIRA)
-
Jaroslav Jankovič (JIRA)