[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-1532: ------------------------------------- JBDS is not working with Java 1.5 anymore, so I guess we should not let to continue installation until java 1.6 is selected to run JBDS, but installer can be executed under both java 1.5 an 1.6. *First of all* installer should check if it is running under OS it is intended for. So if your for some reason is trying to run mac installer on linux it would not let you continue. *Second*, it should check if arch of eclipse inside installer is compatible with current platform architecture. So it would be possible to install 32 bit JBDS on 64 bit platform, but it would not let user to continue and install 64 bit jbds on 32 bit platform. *Third*, it should verify that right java selected to run JBDS, it must match platform architecture of JBDS included in installer. So if user runs installer with JBDS for 32 bit linux on on 64 bit Linux it should not let to select 64 bit java to run JBDS for 32 bit architecture. Warning when JBDS is running with java 1.5 would be good anyway, because user can run JBDS with any java he wants even it was configured right during installation. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Max Rydahl Andersen commented on JBDS-1532: ------------------------------------------- mixing of architecture and java seem to constantly come up - lets fix it properly in JBDS 5 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] SBS JIRA Integration updated JBDS-1532: --------------------------------------- JBoss Forum Reference: http://community.jboss.org/message/603265#603265 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin updated JBDS-1532: -------------------------------- Fix Version/s: 5.0.0.M4 (was: 5.0.0.M3) Forum Reference: http://community.jboss.org/message/603265#603265 (was: http://community.jboss.org/message/603265#603265) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Martin Malina commented on JBDS-1532: ------------------------------------- Note: Mac OS X 10.5 Leopard will no longer be supported in JBDS 5.0 - Leopard is EOL now - by the time JBDS 5 gets released, Lion will have been on the market for more than 6 months and Leopard won't have been updated for quite a while then. (Snow Leopard still will, however.) This means that we don't have to worry about Leopard anymore, but as Denis pointed out, this issue is related to other platforms as well, so it's still valid and to be fixed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-1532: ------------------------------------- I've never tried that since I don't have 64 bit Mac, but installer should not hung. It unpacks studio bits and then start headles JBDS to initialize OSGi cache for faster first start. First part is platform independent and second probably just shows the error message. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Len DiMaggio commented on JBDS-1532: ------------------------------------ +1 - what we need is to add that warning for the users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-1532: ------------------------------------- I'm going to add radio buttons for mac to select 32/64 arch and that would add -d32 or -d64 accordingly to jvm parameters. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-1532: ---------------------------------- Would it not apply to any OSX installers, regardless of the OS level on which it's being installed? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-1532: ---------------------------------- You're right, the 32-bit OSX installer doesn't have this problem, but it should still warn the user if he's trying to install it w/ JDK 1.5. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin updated JBDS-1532: -------------------------------- Fix Version/s: 5.0.0.Beta2 (was: 5.0.0.Beta1) Forum Reference: http://community.jboss.org/message/603265#603265 (was: http://community.jboss.org/message/603265#603265) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-1532: ------------------------------------- Radio buttons to select 32/64 bits should be available in first sucessfull product build after after #1229 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin commented on JBDS-1532: ------------------------------------- they are hidden for Windows/Linux, because -d32/64 is not supported. But I am thinking about showing them disabled, so it would be possible to see architecture for selected JVM on Windows/Linux. Still haven't decided where to show warning about VPE, probably under the radio buttons. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Martin Malina commented on JBDS-1532: ------------------------------------- I can confirm that the buttons work as expected on Mac in the first Beta3 build (H119). And it's what I wanted. But shouldn't we help the user choose one of those somehow? Perhaps recommend one? Like: 32-bit (recommended). Of course it would be best to describe the impact for the user, but that would add clutter to the UI. So simply recommending one could be enough. Also, why do you call it Java Data Model? Wouldn't simply "Architecture" be better? And last, wouldn't "32-bit" be better than "32 bits"? That's what I see used elsewhere. Max, what do you think? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin edited comment on JBDS-1532 at 5/2/12 11:42 AM: -------------------------------------------------------------- Martin, haven't committed yet whole fix because it is little more complex like you explained. Features to fix in CR1 are: 1. Support for radio buttons for all platforms to show architecture for selected JVM (they are going to be disabled because -d is realy works only for mac) 2. Description for every platform what to expect from selected architecture (and like you suggested 32-bit (recommended) on mac and windows sounds good for me) And you're right about architecture called 32-bit and 64-bit. These names are better. was (Author: dgolovin): Martin, haven't committed yet whole fix because it is little more complex like you explained. Features to fix in CR1 are: 1. Support for radio buttons for all platforms to show architecture for selected JVM (they are going to be disabled because -d is realy works only for mac) 2. Description for every platform what to expect from selected architecture (and like you suggested 32-bit (recommended) on mac and windows sounds good for me) And you're right 32-bit and 64-bit are better names for radio buttons -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Martin Malina commented on JBDS-1532: ------------------------------------- Thanks Denis for the comments, I agree. So this JIRA will be moved to CR1? But it is partially fixed in the Beta3 build we just received. Will it be reverted then? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Martin Malina updated JBDS-1532: -------------------------------- Fix Version/s: 5.0.0.CR1 (was: 5.0.0.Beta3) Forum Reference: http://community.jboss.org/message/603265#603265 (was: http://community.jboss.org/message/603265#603265) Setting fix for CR1 - I believe that's where this will be finished. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Daniel Azarov updated JBDS-1532: -------------------------------- Attachment: JBDS-1532.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin resolved JBDS-1532. --------------------------------- Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Martin Malina reopened JBDS-1532: --------------------------------- 5. Doesn't work for me - the warning is displayed regardless of what option I select - it should only be displayed if I select 64-bit, right? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Denis Golovin edited comment on JBDS-1532 at 5/29/12 1:21 PM: -------------------------------------------------------------- What was implemented: 1. Names were updated to Installation type and 32/64-bit 2. Validation check selected name while you type and shows error/warnings below radio buttons to select installation type. 3. Radio buttons are visible for all platforms and enabled only for Mac OSX 4. On Mac OSX desired installation type 32 or 64 can be changed by radio button, on other platforms location should be changed to JVM with desired architecture (and disabled radio buttons reflects architecture for selection) 5. For windows 64-bit and Mac OSX 64-bit it warns that Visual Editor is not supported for selected installation type was (Author: dgolovin): What was implemented: 1. Names were updated to Installation type and 32/64-bit 2. Validation check selected name while you type and shows error/warnings below radio buttons to select installation type. 3. Radio buttons are visible for all platforms and enabled only for Mac OSX 4. On Mac OSX desired installation type 32 or 64 can be chaned by radio button, on other platforms location should be changed to JVM with desired architecture (and disabled radio buttons reflects selection) 5. For windows 64-bit and Mac OSX 64-bit it warns that Visual Editor is not supported for selected installation type -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-1532?page=com.atlassian.jira.plugin.... ] Pavol Srna closed JBDS-1532. ---------------------------- Verified in JBDS 5.0.0.CR1b build. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira