3:47 a.m.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Reporter: Denis Maliarevich
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:47 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich updated JBIDE-10597:
--------------------------------------
Priority: Minor (was: Major)
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:47 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich updated JBIDE-10597:
--------------------------------------
Fix Version/s: 3.3.0.Beta1
Affects Version/s: 3.3.0.M5
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:59 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-10597:
-------------------------------------------
equalsIgnoreCase() is the right choise.
But this "while" loop looks strange: if the page doesn't have <table>
tag -- the loop won't stop.
I'll check it.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich updated JBIDE-10597:
--------------------------------------
Attachment: rich_stp.jsp
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:19 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-10597:
-------------------------------------------
If you open "rich_stp.jsp" file and press toggle icon -- nothing will happen.
It's a bug.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:14 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-10597:
-------------------------------------------
After casting nsIDOMNode to nsIDOMElement VpeDomMapping could not be found.
{code}
nsIDOMElement element = queryInterface(selectedElem, nsIDOMElement.class);
{code}
VpeDomMapping.getNodeMappingAtVisualNode(..) could not get mapping from visualMap by
nsIDOMElement as a key.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:16 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-10597:
-------------------------------------------
Unnecessary "while" loop was removed.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:18 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-10597:
-------------------------------------------
JUnits passed fine.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:30 a.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Denis Maliarevich resolved JBIDE-10597.
---------------------------------------
Resolution: Done
Resolved.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
[
https://issues.jboss.org/browse/JBIDE-10597?page=com.atlassian.jira.plugi...
]
Vlado Pakan closed JBIDE-10597.
-------------------------------
Verified in SVN.
Change node name comparison to equalsIgnoreCase(..)
---------------------------------------------------
Key: JBIDE-10597
URL: https://issues.jboss.org/browse/JBIDE-10597
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.M5
Reporter: Denis Maliarevich
Assignee: Denis Maliarevich
Priority: Minor
Fix For: 3.3.0.Beta1
Attachments: rich_stp.jsp
Vlado Pakan wrote:
I would like to make small change to
http://svn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.tools.v....
I need to make this small change to doToggle(...) method:
Current code:
{code}
while (!selectedElem.getNodeName().equals(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Proposed code:
{code}
while (!selectedElem.getNodeName().equalsIgnoreCase(HTML.TAG_TABLE)) {
selectedElem = queryInterface(selectedElem.getParentNode(), nsIDOMElement.class);
}
{code}
Problem is that method selectedElem.getNodeName() returns node name uppercase but
HTML.TAG_TABLE is lowercase so method equals(HTML.TAG_TABLE) always returns false and my
tests are failing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5161
days inactive
5213
days old
jbosstools-issues@lists.jboss.org
10 comments
5 participants
participants (5)
-
Denis Maliarevich (Commented) (JIRA) -
Denis Maliarevich (Created) (JIRA)
-
Denis Maliarevich (Resolved) (JIRA)
-
Denis Maliarevich (Updated) (JIRA)
-
Vlado Pakan (JIRA)