7:07 a.m.
All Plugins/Installer build is "lying" when sub parts have errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr1
See attached. This is an example from internal devstudio build but the same goes for jboss
tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:15 a.m.
New subject: [JBoss JIRA] Updated: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBDS-491:
-------------------------------------
Attachment: summarybuildislying.png
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr1
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:13 a.m.
New subject: [JBoss JIRA] Commented: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBDS-491:
------------------------------------------
Related issue is https://jira.jboss.org/jira/browse/JBIDE-3185 which indicates the
updatesite was also causing problems.
I don't think we should update the updatesite if any of the parts had build problems.
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr1
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 a.m.
New subject: [JBoss JIRA] Updated: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBDS-491:
-------------------------------------
Fix Version/s: 2.0.0.cr2
(was: 2.0.0.cr1)
slip
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr2
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:21 p.m.
New subject: [JBoss JIRA] Commented: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBDS-491:
---------------------------------
Looks like all we're doing to get the status icon is checking if the file exists.
<macrodef name="get.status">
<attribute name="file"/>
<attribute name="property"/>
<sequential>
<if>
<available file="@{file}"/>
<then><property name="@{property}"
value="OK"/></then>
<else><property name="@{property}"
value="FAIL"/></else>
</if>
</sequential>
</macrodef>
Sounds like we need a summary check -- if all the individual pieces are OK, set another
status code for "all.pieces.status" and have the ALL status checks be "if
file exists and all.pieces.status == OK, then OK. If any of the pieces FAIL
(all.pieces.status == FAIL) but ALL file exists, set a new, third status of
"MAYBE" ?
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr2
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:05 a.m.
New subject: [JBoss JIRA] Commented: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBDS-491:
------------------------------------------
sounds plausible. For "MAYBE" just use the fail cross or put in a yellow
triangle ;)
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr2
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:20 p.m.
New subject: [JBoss JIRA] Updated: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBDS-491:
-------------------------------------
Fix Version/s: 2.0.0.GA
(was: 2.0.0.cr2)
assume slip
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.GA
Attachments: summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:35 a.m.
New subject: [JBoss JIRA] Updated: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Nick Boldt updated JBDS-491:
----------------------------
Attachment: jbds-491-patch.txt
patch to perform both simple "does the file exist?" and "do the file, and
all the standalone plugin zips, exist?"
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.GA
Attachments: jbds-491-patch.txt, summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:41 p.m.
New subject: [JBoss JIRA] Work started: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Work on JBDS-491 started by Nick Boldt.
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.GA
Attachments: jbds-491-patch.txt, summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
New subject: [JBoss JIRA] Updated: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Nick Boldt updated JBDS-491:
----------------------------
Fix Version/s: 2.0.0.cr2
(was: 2.0.0.GA)
Fixed in CR2, not GA.
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr2
Attachments: jbds-491-patch.txt, JBDS-491.png, summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
New subject: [JBoss JIRA] Resolved: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Nick Boldt resolved JBDS-491.
-----------------------------
Resolution: Done
Local testing indicates this is fixed. I'll attach a screen shot to show what it looks
like when one of the standalone bits fails. Note that in this screenshot I deliberately
broke drools (deleted the zips) to test the logic and icons.
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.GA
Attachments: jbds-491-patch.txt, JBDS-491.png, summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:10 p.m.
New subject: [JBoss JIRA] Updated: (JBDS-491) All Plugins/Installer build is "lying" when sub parts have errors
[
https://jira.jboss.org/jira/browse/JBDS-491?page=com.atlassian.jira.plugi...
]
Nick Boldt updated JBDS-491:
----------------------------
Attachment: JBDS-491.png
All Plugins/Installer build is "lying" when sub parts have
errors
-----------------------------------------------------------------
Key: JBDS-491
URL: https://jira.jboss.org/jira/browse/JBDS-491
Project: Developer Studio
Issue Type: Bug
Components: Build
Affects Versions: 1.1.0.GA
Reporter: Max Rydahl Andersen
Assignee: Nick Boldt
Fix For: 2.0.0.cr2
Attachments: jbds-491-patch.txt, JBDS-491.png, summarybuildislying.png
See attached. This is an example from internal devstudio build but the same goes for
jboss tools build.
Some of the sub projects have failed to build and gives a red triangle (good!)
The installer/all plugins has a green check mark (bad!)
I assume this happens because neither the zip or the installer actually checks if it gets
the right result (nor do I think it can check reliably);
but the build could at least check that if there are some errors in the individual
plugins then there must be something wrong in the zip/installers too.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5735
days inactive
5798
days old
jbosstools-issues@lists.jboss.org
11 comments
2 participants
participants (2)
-
Max Rydahl Andersen (JIRA) -
Nick Boldt (JIRA)