[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Fred Bricon edited comment on JBIDE-11738 at 5/7/12 5:55 AM: ------------------------------------------------------------- Max we can probably write some maven configurator for this, what is needed on the JBossAs/Servers front (since you assigned it to Rob)? was (Author: fbricon): Max we can probably write some maven configurator or this, what is needed on the JBossAs/Servers front (since you assigned it to Rob)? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11738: --------------------------------------------- Looks good, a few comments: Shouldn't it be the other way around ? endorseddirs first, compilerargument second ? or is that because <compilerArgument> actuallly can override the endorsed dirs ? With respect to the regular expression I guess this could be problematic if the directory have spaces in it? (could be a future enhancement to handle that - and I guess endorseddirs would be able to handle spaces?) Any alternatives to this ? (besides hoping users will guess and figure it out on their own to run a mvn build first?) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Fred Bricon commented on JBIDE-11738: ------------------------------------- * javac uses jars from java.endorsed.dirs before those from endorseddirs (I checked). * maven-compiler-plugin is pretty bad at handling spaces in compilerArguments. It currently surrounds the whole <compilerArgument> value with quotes, regardless of the number of actual arguments in it. Dunno how <endorseddirs> behaves. yet. * Maybe add a warning marker on the project if the endorsed dirs are missing and ask him to run a CLI build manually. Corner case : given that maven-dependency-plugin can have several configurations spanned over several maven execution lifecycle mappings, it's gonna be tricky to know which one to execute/ point the user to : {code:xml} <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-dependency-plugin</artifactId> <version>2.1</version> <executions> <execution> <id>validate</id> <phase>validate</phase> <goals> <goal>copy</goal> </goals> <configuration> <outputDirectory>${endorsed.dir}</outputDirectory> <silent>true</silent> <artifactItems> <artifactItem> <groupId>javax</groupId> <artifactId>javaee-endorsed-api</artifactId> <version>6.0</version> <type>jar</type> </artifactItem> <artifactItem> <groupId>foo.bar</groupId> <artifactId>endorsed</artifactId> <version>0.0.1</version> <type>jar</type> </artifactItem> </artifactItems> </configuration> </execution> <execution> <id>generate-sources</id> <phase>generate-resources</phase> <goals> <goal>copy</goal> </goals> <configuration> <outputDirectory>${endorsed.dir2}</outputDirectory> <silent>true</silent> <artifactItems> <artifactItem> <groupId>foo.bar</groupId> <artifactId>endorsed</artifactId> <version>0.0.2</version> <type>jar</type> </artifactItem> </artifactItems> </configuration> </execution> </executions> </plugin> {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Fred Bricon edited comment on JBIDE-11738 at 5/10/12 6:54 AM: -------------------------------------------------------------- * Download [^endorsed_libs_update_site.zip] * in eclipse > Help > Install new software... * click Add... * click Archive, point at your local endorsed_libs_update_site.zip, Open * Give it a name if you like, click OK * Select JBoss Maven Endorsed Libraries configurator * proceed with installation * restart workspace when done. was (Author: fbricon): * Download !endorsed_libs_update_site.zip! * in eclipse > Help > Install new software... * click Add... * click Archive, point at your local endorsed_libs_update_site.zip, Open * Give it a name if you like, click OK * Select JBoss Maven Endorsed Libraries configurator * proceed with installation * restart workspace when done. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Fred Bricon resolved JBIDE-11738. --------------------------------- Labels: new_and_noteworthy (was: ) Resolution: Done Fixed in trunk. During project configuration, if the endorsed directories are missing, an Error Marker is added at the maven-compiler-plugin location in pom.xml. If there's a maven-dependency-plugin:copy goal defined in a plugin execution, then a quick fix will be available for the error marker, basically proposing the user to run mvn <phase_executing_dependency_copy>. After that goal is run, the project configuration is updated, effectively adding the Endorsed Libraries to project classpath. Please note that the maven-dependency-plugin execution is still not covered by m2e (this goes beyond the scope of this JIRA), thus requires custom lifecycle mapping (see http://wiki.eclipse.org/M2E_plugin_execution_not_covered) Finally, adding an action menu on "Endorsed Libraries" to automatically execute the dependency:copy thing (similar to what the quick fix does), can be dealt with a new feature enhancement request. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Fred Bricon updated JBIDE-11738: -------------------------------- Workaround Description: In case endorsed directories are defined in the maven-compiler-plugin configuration, this new maven configurator : * parses <compilerArgument> for -Djava.endorsed.dirs=([^ \\t]+) and falls back on the <compilerArguments><endorseddirs> value. * lists all the jars and zips found under the endorsed directories and adds them to a new Endorsed Libraries classpath library. Endorsed Libraries is put first on the project's classpath. For now the endorsed dirs need to have been created/populated before the project's configuration. * During project configuration, if the endorsed directories are missing, an Error Marker is added at the maven-compiler-plugin location in pom.xml. * If there's a maven-dependency-plugin:copy goal defined in a plugin execution, then a quick fix will be available for the error marker, basically proposing the user to run mvn <phase_executing_dependency_copy>. After that goal is run, the project configuration is updated, effectively adding the Endorsed Libraries to the project's classpath. Please note that the maven-dependency-plugin execution is still not covered by m2e (this goes beyond the scope of this JIRA), thus requires custom lifecycle mapping (see http://wiki.eclipse.org/M2E_plugin_execution_not_covered) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Rastislav Wagner closed JBIDE-11738. ------------------------------------ verified in jbdevstudio-product-universal-5.0.0.v201205272317M-H143-CR1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11738?page=com.atlassian.jira.plugi... ] Fred Bricon commented on JBIDE-11738: ------------------------------------- Code is at https://github.com/jbosstools/jbosstools-central/tree/master/maven/plugin... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira