[
https://issues.jboss.org/browse/JBIDE-19757?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-19757:
------------------------------------
More explicit than this?
https://github.com/jbosstools/jbosstools-download.jboss.org/blob/master/j...
True, having two URLs point to the same content could befuddle p2, but the wtp server
adapter discovery site is only loaded once. I can't imagine you'd get much
performance gain from having it point to a site which is already cached because you're
a JBoss Tools user.
If you can prove there's performance gain by using a composite instead of a symlink,
then I will agree with you that your approach is better than mine.
I believe 1 file saying the same thing as 2 is better from a maintenance & simplicity
perspective. And this year's goal w/ the release process refactoring was to make
things EASIER to maintain by simplifying, right?
Use jbosstools aggregate site instead of special webtools-site for
WTP's AS server discovery
--------------------------------------------------------------------------------------------
Key: JBIDE-19757
URL:
https://issues.jboss.org/browse/JBIDE-19757
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: build, server
Reporter: Mickael Istria
Assignee: Nick Boldt
Fix For: 4.3.0.Beta1
With
https://bugs.eclipse.org/bugs/show_bug.cgi?id=434185 , WTP Server Discovery
mechanism was granted a new strategy which allows to rely on regular p2 metadata instead
of a site.xml.
Support for this was already merged in server (
https://github.com/jbosstools/jbosstools-server/commit/2d3cc63a9b67753ad9...
)
In order to save an artifact to manage (the webtools p2 repository), we could use this
mechanism and consider contributing directly the main JBT URL to webtools discovery.
However, server discovery also keeps older strategies and since we produce invalid
site.xml files, this is currently failing
{code}
!ENTRY org.eclipse.equinox.p2.updatesite 2 0 2015-05-04 09:40:58.088
!MESSAGE Error parsing feature stream. The unique identifier or the version is null or
empty for the State: "Category": unique identifier="minimal-json"
version="null".
{code}
because we are lines specifying bundle but no version in the site.xml.
[~nickboldt] What are those site.xml useful for? Could we get rid of them?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)