[
https://issues.jboss.org/browse/JBIDE-12716?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-12716:
--------------------------------
Attachment: JBIDE-12716.patch
I have a patch for this issue:
QE:
The changes I'm making affect how and when the dialog will persist the changes made in
the preference page. If everything is working perfect, changes should ONLY ever be
persisted when "Apply" or "OK" are pressed on the preference page.
Everything else should be considered temporary changes ONLY.
When you edit a runtime path, in the subsequent dialogs, cancel should make sure the
'change' is not even shown in the preference page. The preference page should no
longer randomly close and re-open to refresh itself, but changes must be persisted when
the user expects, and NOT persisted when they do not expect it.
To anyone else: The reason for this original bug is as follows:
1) The 'remove' button was only keeping the change in the local model until
performOK or performApply was pressed, when it would persist the change. This was correct
2) The 'add' button was persisting the change immediately upon 'add' and
its dialogs being finished.
The issue here was that a call to remove would locally remove the runtime path. A call to
'add' would add the new one and persist that change. Since the core model never
had the 'removed' object actually removed, the 'add' called to the core
model would persist only the addition, and the never-actually-removed entry would still be
persisted. The preference page would close and reopen (?!) and then you would see both
entries.
Remove button does not work properly
------------------------------------
Key: JBIDE-12716
URL:
https://issues.jboss.org/browse/JBIDE-12716
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: runtime detection
Affects Versions: 4.0.0.Alpha2
Reporter: Lucia Jelinkova
Assignee: Rob Stryker
Priority: Blocker
Fix For: 4.0.0.Beta1
Attachments: JBIDE-12716.patch
When I remove the path from runtime detection preferences page and then add another path,
the removed path appears again.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira