Secure storage of OpenShift 3 token does not work ------------------------------------------------- Key: JBIDE-21742 URL: https://issues.jboss.org/browse/JBIDE-21742 Project: Tools (JBoss Tools) Issue Type: Bug Components: openshift Affects Versions: 4.3.1.CR1 Reporter: Marián Labuda Assignee: Viacheslav Kabanovich Labels: connection, openshift_v3, security_domain Fix For: 4.3.1.CR1 Attachments: SecureStorageAccessFailure.png When I have already user secure storage in another session (password is set) and I fill in valid token and check checkbox to store token in secure storage, confirmation dialog of secure storage is shown upon hitting Finish button. Upon filling invalid secure storage password for first time, dialog is invoked again to enter password. After second filling of invalid password for secure storage, it looks like it passed - no other prompt nor error dialog (just in error log see stack trace) and even in Connection dialog (opened via Edit context menu item on the connection) is checkbox for secure storage checked, what is wrong, because it is not stored (checked secure storage preference page and its content and also after restart of eclipse it was not stored). {code} org.jboss.tools.openshift.internal.common.core.security.SecureStoreException: Could not store value token: iQKo-5jRkMeaegCi3mljsFsAXhNaogmzwaKeaQNUAxc at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:104) at org.jboss.tools.openshift.internal.common.core.security.SecureStore.put(SecureStore.java:57) at org.jboss.tools.openshift.core.connection.Connection.saveOrClear(Connection.java:187) at org.jboss.tools.openshift.core.connection.Connection.save(Connection.java:159) at org.jboss.tools.openshift.core.connection.Connection.connect(Connection.java:207) at org.jboss.tools.openshift.core.connection.Connection.retryList(Connection.java:424) at org.jboss.tools.openshift.core.connection.Connection.getResources(Connection.java:368) at org.jboss.tools.openshift.core.connection.Connection.getResources(Connection.java:355) at org.jboss.tools.openshift.internal.ui.models.OpenShiftProjectCache.getProjectsFor(OpenShiftProjectCache.java:60) at org.jboss.tools.openshift.internal.ui.explorer.OpenShiftExplorerContentProvider.getChildrenFor(OpenShiftExplorerContentProvider.java:95) at org.jboss.tools.openshift.internal.common.ui.explorer.BaseExplorerContentProvider$1.run(BaseExplorerContentProvider.java:167) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) Caused by: org.eclipse.equinox.security.storage.StorageException: No password provided. at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getModulePassword(SecurePreferencesRoot.java:304) at org.eclipse.equinox.internal.security.storage.SecurePreferencesRoot.getPassword(SecurePreferencesRoot.java:224) at org.eclipse.equinox.internal.security.storage.SecurePreferences.put(SecurePreferences.java:224) at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.put(SecurePreferencesWrapper.java:110) at org.jboss.tools.openshift.internal.common.core.security.SecureStore.store(SecureStore.java:102) ... 11 more {code}