[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Cody Lerum commented on JBIDE-5974: ----------------------------------- This does occur in 3.1GA as well -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-5974: ---------------------------------------------- Cody, Vadim, if after the failure you restart Eclipse and try once more "Add JSF Capabiliites" to that project, will it be added ok then? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- It goes away every time. There's a message "!MESSAGE Project P/ProjectName has corrupted nature: org.jboss.tools.jsf.jsfnature" in the logs for every time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- Once I add this builder it stops working: <buildCommand> <name>org.jboss.tools.common.verification.verifybuilder</name> <arguments> </arguments> </buildCommand> It removes the JSF nature when it runs... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- Yes, you are right. In 3.1 CR2 and 3.1 GA, the JSF nature is removed even without the verifybuild builder present. I guess adding it manually only works in CR1, but in CR1 having the JSF nature doesn't really have a benefit. Back to CR1... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- Yes it works fine in a "regular" project. (Note I tested using 3.1 CR1... I'll lose my mind if I have to switch between 3.1CR1 and 3.1GA one more time) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker updated JBIDE-5974: ------------------------------------ Attachment: .project project file -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Cody Lerum updated JBIDE-5974: ------------------------------ Attachment: .project project file -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker updated JBIDE-5974: ------------------------------------ Attachment: .settings.zip Workspace is C:\Projects and the project is located in C:\Projects\TheProject so the project is within the eclipse workspace. The path to web.xml is C:\Projects\TheProject\resources\WEB-INF\web.xml -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-5974: ---------------------------------------------- And, very important 3. .project file includes nature org.eclipse.wst.common.modulecore.ModuleCoreNature. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- Okay I installed 3.1GA to test this. I followed the instructions. After I "Add JSF Capability", I end up with exactly the same "corrupt" settings. I tried a couple of times to make sure I wasn't making a mistake, but the end result is the same every time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-5974: --------------------------------------- Vadim, which version of Seam do you use to generate the project? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-5974: --------------------------------------- It seems you use some old Seam-gen templates which are incorrect for Eclipse 3.5/WTP 3.1. Try to use the latest Seam 2.2.0. I can't reproduce this problem there. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Cody Lerum commented on JBIDE-5974: ----------------------------------- I followed these steps exactly (https://jira.jboss.org/jira/browse/JBIDE-5974?focusedCommentId=12519990#a...) and it worked for me. Thanks! The JSF capabilities are preserved after restarting eclipse. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- I FOUND IT! Can't say I didn't try :) It's the m2eclipse WTP Integration that's causing this. It's adding <buildCommand> <name>org.eclipse.wst.common.project.facet.core.builder</name> <arguments> </arguments> </buildCommand> and <nature>org.eclipse.wst.common.project.facet.core.nature</nature> automatically when the project is built which then causes Add JSF Capability not to work... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-5974: ---------------------------------------------- JSF Capability is based on Web Dynamic Project and not any faceted project can be converted to it. For example specific facets of ESB project, JPA project etc. are not compatible with 'jst.web' facet of dynamic web project. I have studied our code and found that it just avoids adding 'jst.web' facet to an existing faceted project because in 99% of cases it is going to fail anyway (with a message like 'Dynamic Web Module 2.5 and JBoss ESB 4.5 cannot both be selected.'). But there exists at least one case when adding 'jst.web' facet is successful, and it is the case of this issue - the faceted project does not declare any facets. So, this issue may be fixed by simple trying to add 'jst.web' facet if it is missing. Such a fix will not make worse any other case. When it fails, it would mean that the project is not Web Dynamic Project, and at the next start of Eclipse JSF model will not be able to obtain web root from it (after Add JSF Capability wizard it took it from input and tried to save with 'jst.web' facet), so jsfnature will be removed as corrupted. But it is exactly what happens now, only exceptions are different. This simple fix is safe for 3.1.1. It will be smarter to improve validation in Add JSF Capability wizard, and check if it is safe to try and add missing 'jst.web' facet, and if answer is negative report to wizard error message area of impossibility to add JSF capabilities to the project, and disable finish button. I think it also can be done for 3.1.1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Vadim Berezniker commented on JBIDE-5974: ----------------------------------------- Thank you. Based on your knowledge, do you think it's a bug (or at least not a nice thing to do) for m2eclipse to automatically add the faceted nature to projects? Seems that this could be improved too. If you do, I'll file a issue with m2eclipse for this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich updated JBIDE-5974: ----------------------------------------- Attachment: ImportWebProjectWizardPage5974.patch ImportWebProjectWizardPage5974.patch provides warning for projects that cannot be converted into Web Dynamic project and disables finish in that case. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-5974?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-5974: ---------------------------------------------- 1. EXECUTE: Create new EJB project. EXECUTE: Add to project root folder WebContent folder from some JSF project. EXECUTE: Run 'Add JSF Capabilities' wizard. ASSERT: Finish/Next buttons are disabled, and error message 'The project cannot be converted to Web Dynamic project required for JSF capabilities' is displayed. 2. EXECUTE: Create new Java project. EXECUTE: Add to project root folder WebContent folder from some JSF project. EXECUTE: Run 'Add JSF Capabilities' wizard. ASSERT: Wizard is successfully completed and project appears in Web Projects view. 3. EXECUTE: Create new JSF project. EXECUTE: Run 'Remove JSF Capabilities' action (variants: remove or do not remove dynamic web project capabilities) EXECUTE: Run 'Add JSF Capabilities' wizard. ASSERT: Wizard is successfully completed and project appears in Web Projects view. 4. EXECUTE: Create Faceted Project with any consistent set of facets. If 'Dynamic Web Module' facet is not included into the set, take a note before finishing if wizard allows for it to be added to the set or not. EXECUTE: Add to the project root folder WebContent folder from some JSF project, if the created project has no web content. EXECUTE: Run 'Add JSF Capabilities' wizard. ASSERT: If the created faceted project has 'Dynamic Web Module' facet, or if that facet was allowed by new faceted project wizard, then 'Add JSF Capabilities' wizard completes succcessfully, otherwize Finish/Next buttons are disabled and error message is displayed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-5974?page=com.atlassian.jira.plugin.s... ] Vlado Pakan closed JBIDE-5974. ------------------------------ Verified on JBDS 3.0.1.v201005241821R-H78-GA -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira