3:34 a.m.
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Task
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:38 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Maxim Areshkau updated JBIDE-9323:
----------------------------------
Attachment: JBIDE-9323.diff
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Task
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Labels: refactoring
Attachments: JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:02 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Maxim Areshkau updated JBIDE-9323:
----------------------------------
Attachment: JBIDE-9323-new.patch
updated version of patch
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Task
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Labels: refactoring
Attachments: JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Yahor Radtsevich updated JBIDE-9323:
------------------------------------
Issue Type: Feature Request (was: Task)
Fix Version/s: LATER
Priority: Optional (was: Major)
There is {{vpeCommands}} variable in [^JBIDE-9323-new.patch]. An empty {{ArrayList}} is
assigned to it once and it never changed. Is not something missing in the patch?
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: LATER
Attachments: JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:54 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Maxim Areshkau commented on JBIDE-9323:
---------------------------------------
Nope, the behaviour is expected. It reads register during first call(initialization time)
and all.
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: LATER
Attachments: JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:34 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Yahor Radtsevich commented on JBIDE-9323:
-----------------------------------------
If you want your patch to be applied sooner, please make it more readable:
# Comment your code
# Use correct indentation
# If you need a flag indicating that initialization passed, use a boolean variable
# Delete old code instead commenting (if it not is necessary for understanding)
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: LATER
Attachments: JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:44 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Maxim Areshkau updated JBIDE-9323:
----------------------------------
Attachment: JBIDE-9323-new-2.patch
JBIDE-9323-new-2.patch
New version of patсh with comments. Old code has been removed.
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: LATER
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:44 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Maxim Areshkau updated JBIDE-9323:
----------------------------------
Attachment: JBIDE-9323-new-2.patch
New version of patch with comments, old code has been removed.
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: LATER
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:15 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Yahor Radtsevich resolved JBIDE-9323.
-------------------------------------
Fix Version/s: 3.3.0.M3
(was: LATER)
Resolution: Done
*Resolved*
I have applied a little bit changed patch to trunk.
Maxim, next time please also try to build and run VPE tests before sending patch, since it
was caused a compile error in there.
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: 3.3.0.M3
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:32 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Vlado Pakan commented on JBIDE-9323:
------------------------------------
Maxim please could you verify and close this Jira or provide steps how to verify it?
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: 3.3.0.M3
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:55 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Maxim Areshkau commented on JBIDE-9323:
---------------------------------------
{quote}
Maxim please could you verify and close this Jira or provide steps how to verify it?
{quote}
So I have verified and closed the issue as you wrote in 1-st part of your comment. It hard
to verify with java coding.
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: 3.3.0.M3
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:28 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Vlado Pakan closed JBIDE-9323.
------------------------------
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: 3.3.0.M3
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:28 a.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-9323) Possibility to contribute on vpe toolbar in eclipse
[
https://issues.jboss.org/browse/JBIDE-9323?page=com.atlassian.jira.plugin...
]
Vlado Pakan resolved JBIDE-9323.
--------------------------------
Resolution: Done
Possibility to contribute on vpe toolbar in eclipse
---------------------------------------------------
Key: JBIDE-9323
URL: https://issues.jboss.org/browse/JBIDE-9323
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: Visual Page Editor core
Affects Versions: 3.3.0.M2
Reporter: Maxim Areshkau
Assignee: Yahor Radtsevich
Priority: Optional
Labels: refactoring
Fix For: 3.3.0.M3
Attachments: JBIDE-9323-new-2.patch, JBIDE-9323-new-2.patch,
JBIDE-9323-new-2.patch, JBIDE-9323-new.patch, JBIDE-9323.diff
VPE icons have some logic behind them(disabled when visual part not visible). We need
possibility to contribute on this toolbar. For now this is inpossible. Because refresh
icon function has hardcoded commands'id. Better to refresh all commands on some
org.jboss.tools.vpe.category. That allows contribute to vpe-toolbar.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4763
days inactive
4827
days old
jbosstools-issues@lists.jboss.org
12 comments
3 participants
participants (3)
-
Maxim Areshkau (JIRA) -
Vlado Pakan (JIRA)
-
Yahor Radtsevich (JIRA)