[ https://issues.jboss.org/browse/JBIDE-9674?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-9674: --------------------------------------- Description: comment originally from JBIDE-9203: Property Key is not selected correctly. When cursor position is within text containing more lines Property Key is selected with special characters '\r' and '\n' displayed not correctly !wrongPropertykeySelection.png! When Property Key with more lines is used validator is displaying error !errorAfterWrongPropertyKeySelection.png! I think translation should not include leading and trailing <EOL>, <CR>, <LF> characters of whole text paragraph because after translation is used formatting of web page source is lost i.e: <h1> Line1 Line2 Line3 ... </h1> is replaced with <h1>#{Message.Line1}</h1> what can be confusing. was: 1. Create JSF kick start project 2. Open hello.jsp page 3. Insert "Plain" text as shown on picture below and choose Externalize selected string toolbar button In the Externalize String dialog is set text "Plain" as Property value but together with special characters <EOL> !externalizestringdialog.png! 4. Choose next>, next>, OK. (Use default values) hello.jsp page look like this. <EOL> characters around "Plain" text were removed/replaced with reference to .properties file: !externalizestringresult.png! hello.properties has wrong contnent: !propertiesfile.png! -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9674?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-9674: --------------------------------------- Fix Version/s: 3.3.0.M4 (was: 3.3.0.M3) wrongly put on M3, should be M4 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9674?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-9674: ------------------------------------------ First of all as you could notice "formatting of web page source is lost" but formatting of the visual representation is still the same. Secondly when user selects some text in the page source directly -- only that lines/strings will be replaced, without any changes to leading/trailing <EOL>, <CR>, <LF> characters. Thirdly when nothing is selected the whole text area under the cursor is supposed to be replaced, including all the <EOL>, <CR>, <LF> characters. It is an arguable question whether it good or bad solution. 50/50 to my mind. Nevertheless the visual representation remains the same. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9674?page=com.atlassian.jira.plugin... ] Denis Maliarevich resolved JBIDE-9674. -------------------------------------- Resolution: Done Resolved. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9674?page=com.atlassian.jira.plugin... ] Isaac Rooskov updated JBIDE-9674: --------------------------------- Release Notes Docs Status: Documented as Resolved Issue Writer: irooskov Release Notes Text: An error existed where the special characters '\r' and '\n' that are part of the Property Key, were not displayed correctly when the Property Key contained more lines than initially shown. This caused the following error to appear: Unable to render embedded object: File (errorAfterWrongPropertyKeySelection.png) not found. The generated Property Key has been corrected by modifying the ExternalizeStringsUtils.java file by adding in single quotes as characters to be correctly replaced when formatting a web page. Property Key is now displayed correctly and the error no longer appears. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira