8:36 p.m.
Andre Dietisheim created JBIDE-12134:
----------------------------------------
Summary: StackOverflow when importing into existing project
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Reporter: Andre Dietisheim
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:38 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Fix Version/s: 3.3.0.CR1
Priority: Critical (was: Major)
Affects Version/s: 3.3.0.CR1
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:43 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Steps to Reproduce:
# ASSERT: have a project in your workspace (that is git shared, ex. cloned from github?)
# EXEC: launch *New OpenShift Application wizard*
# EXEC: take some application name, type etc.
# EXEC: choose to import into your workspace project: uncheck "new project",
*browse" your workspace and *choose your workspace project*
Result:
You get an error dialog with a StackOverflow.
!stack-overflow.png!
In the log you'll spot the following endless recursion:
{code}
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
{code}
was:
# ASSERT: have a project in your workspace (that is git shared, ex. cloned from github?)
# EXEC: launch *New OpenShift Application wizard*
# EXEC: take some application name, type etc.
# EXEC: choose to import into your workspace project: uncheck "new project",
*browse" your workspace and *choose your workspace project*
Result:
You get an error dialog with a StackOverflow. In the log you'll spot the following
endless recursion:
{code}
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
{code}
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:49 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-12134:
------------------------------------------
the culprit (the one that is causing the endless recurring change) is:
ProjectAndServerAdapterSettingsWizardPageModel.existingProjectValidity<IStatus>
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:25 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Steps to Reproduce:
I cannot reproduce it always, it happens rarely. Still not sure what the exact
circustances are.
# ASSERT: have a project in your workspace (that is git shared, ex. cloned from github?)
# EXEC: launch *New OpenShift Application wizard*
# EXEC: take some application name, type etc.
# EXEC: choose to import into your workspace project: uncheck "new project",
*browse" your workspace and *choose your workspace project*
Result:
You get an error dialog with a StackOverflow.
!stack-overflow.png!
In the log you'll spot the following endless recursion:
{code}
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
{code}
was:
# ASSERT: have a project in your workspace (that is git shared, ex. cloned from github?)
# EXEC: launch *New OpenShift Application wizard*
# EXEC: take some application name, type etc.
# EXEC: choose to import into your workspace project: uncheck "new project",
*browse" your workspace and *choose your workspace project*
Result:
You get an error dialog with a StackOverflow.
!stack-overflow.png!
In the log you'll spot the following endless recursion:
{code}
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
at
org.eclipse.core.databinding.validation.MultiValidator.revalidate(MultiValidator.java:295)
at
org.eclipse.core.databinding.validation.MultiValidator$DependencyListener.handleChange(MultiValidator.java:152)
at org.eclipse.core.databinding.observable.ChangeEvent.dispatch(ChangeEvent.java:41)
at
org.eclipse.core.databinding.observable.ChangeManager.fireEvent(ChangeManager.java:119)
at
org.eclipse.core.databinding.observable.AbstractObservable.fireChange(AbstractObservable.java:65)
at
org.eclipse.core.databinding.observable.list.ObservableList.fireListChange(ObservableList.java:72)
at
org.eclipse.core.databinding.observable.list.WritableList.addAll(WritableList.java:193)
{code}
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:39 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Attachment: stack-overflow.png
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-12134:
---------------------------------------------
i assume this is for you Andre?
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:08 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBIDE-12134:
----------------------------------------
Assignee: Andre Dietisheim
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Attachment: validate-in-ui.patch
I suspect a bad implementation of the MultiValidator. The golden rule with MultiValidator
is that you have to access all observables that are participating in the validation. This
is not the case in the current implementation since validation occurrs in the model (@see
ProjectAndServerAdapterSettingsWizardPageModel#setProjectName &
ProjectAndServerAdapterSettingsWizardPageModel#setNewProject - both call
#validateExistingProject).
I moved the validation from the model to the UI and implemented a MultiValidator in the
way it is implemented in all other pages. It now accesses all observables that participate
to the validation:
- applicationName
- projectName
- isNewProject (checkbox)
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 a.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBIDE-12134:
----------------------------------------
Assignee: Xavier Coulon (was: Max Rydahl Andersen)
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:20 a.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-12134:
---------------------------------------------
I couldn't reproduce the original issue nor fully follow the patch. but things does
seem to still work.
Xavier - can you review it since you could reproduce and now the validation better than
i.
thanks.
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:14 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Xavier Coulon updated JBIDE-12134:
----------------------------------
Component/s: openshift
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-12134:
------------------------------------------
xavier commented in
https://issues.jboss.org/browse/JBIDE-12138?focusedCommentId=12700091#com...
(wrong issue):
{quote}
I just applied André's patch and could not reproduce the bug (so far).
furthermore, code is improved (following the same style as with other pages/models of the
wizard), so it is much forth keeping.
{quote}
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1, 3.4.x
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-12134:
------------------------------------------
committed to BRANCH (3.3.0.CR1) and TRUNK (3.4.x)
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1, 3.4.x
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim resolved JBIDE-12134.
--------------------------------------
Fix Version/s: 3.4.x
Resolution: Done
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1, 3.4.x
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:55 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Xavier Coulon commented on JBIDE-12134:
---------------------------------------
I just applied André's patch and could not reproduce the bug (so far).
furthermore, code is improved (following the same style as with other pages/models of the
wizard), so it is much forth keeping.
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.0.CR1, 3.4.x
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Stefan Bunciak updated JBIDE-12134:
-----------------------------------
Fix Version/s: (was: 3.3.0.Final)
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.4.0.M1
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:24 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Fix Version/s: 3.3.2
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.2, 3.4.0.M1
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:40 p.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Fix Version/s: 4.0.0.Alpha2
(was: 4.0.0.Alpha1)
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.2, 4.0.0.Alpha2
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:35 a.m.
[
https://issues.jboss.org/browse/JBIDE-12134?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12134:
-------------------------------------
Fix Version/s: 4.0.x
(was: 4.0.0.Alpha2)
Moved to 4.0.x since I could not reproduce it while testing for Alpha2
StackOverflow when importing into existing project
--------------------------------------------------
Key: JBIDE-12134
URL: https://issues.jboss.org/browse/JBIDE-12134
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.CR1
Reporter: Andre Dietisheim
Assignee: Xavier Coulon
Priority: Critical
Fix For: 3.3.2, 4.0.x
Attachments: stack-overflow.png, validate-in-ui.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4381
days inactive
4487
days old
jbosstools-issues@lists.jboss.org
22 comments
4 participants
participants (4)
-
Andre Dietisheim (JIRA) -
Max Rydahl Andersen (JIRA)
-
Stefan Bunciak (JIRA)
-
Xavier Coulon (JIRA)