[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=all ] Max Andersen updated JBIDE-1558: -------------------------------- Fix Version/s: 2.1 (was: LATER) Affects Version/s: 2.0.0.GA please remember to set affects version and we shouldn't set version fix to later unless we have decided to do it later (or its a really minor or really big feature)....this one is important since its something users would expect to work. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=comments#action_12397832 ] Max Andersen commented on JBIDE-1558: ------------------------------------- the properties file the classpath this should be done through rename/move/delete partipants from ltk.core.refactoring so it becomes part of the normal rename/refactoring support. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=comments#action_12398234 ] Max Andersen commented on JBIDE-1558: ------------------------------------- Your suggestions sound to be a general rule, not hibernate specific. btw. why do you point out .properties and what file values are you concerned about here ? which use case ? all depends on what context you have. e.g. if you have: c:/work/project/myprj/src/model/customer.hbm.xml then in eclipse it would probably be listed as the following resource myprj/src/model/customer.hbm.xml but in that projects cfg.xml it would be referred to as model/customer.hbm.xml so no, can't be done that simple I would say if specific for hibernate. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=comments#action_12398248 ] Max Andersen commented on JBIDE-1558: ------------------------------------- btw. lets focus on the refactoring that is mentioned in the bug first then we can improve later. focus on if refactor the location of hibernate.cfg.xml then the launchconfiguration will not work - that is the first task to sovle. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=comments#action_12398257 ] Dima Geraskov commented on JBIDE-1558: -------------------------------------- And to full refactoring support we need to decide what we will do if user delete resource we are referred to from launch configurations? Should we remove the references or? Also when you spoke about properties file do you meant reference on properties file from launch configuration? (I understand that my refactoring participant should change all paths are contained by launch configurations if they should be changed ). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=comments#action_12398266 ] Dima Geraskov commented on JBIDE-1558: -------------------------------------- <Good question - I guess they actually should get the option of deleting the launch configuration or keep it as is. <Can't think of other refactorings in eclipse that has the same situation - can you ? Yes. I've just created JUnit test to see how it behaves itself when TestCase it referes to deleted. It do nothing. I think we can get this as a rule. <"Also when you spoke about properties file do you meant reference on properties file from launch <configuration? " <You talked about "search all .properties files" which to me means all files and not just the ones related to <launch configuration. Yes, I talked that because I didn't understand at the beginning what did you mean. But later I understand that you tried to help me do not forget all possible references from launch configuration. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1558?page=all ] Dima Geraskov resolved JBIDE-1558. ---------------------------------- Resolution: Partially Completed Refactoring doesn't affect on absolute paths. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira