[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-10966: ---------------------------------------- Priority: Blocker (was: Critical) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Xavier Coulon commented on JBIDE-10966: --------------------------------------- forgot about domain names -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10966: ------------------------------------------ the validation was also added to the client: https://github.com/bdecoste/openshift-java-client/commit/a1045afe2280ae0a... {code} protected void validateApplicationName(final String name) throws OpenShiftException { for (int i = 0; i < name.length(); ++i) { if (!Character.isLetterOrDigit(name.charAt(i))) { throw new InvalidNameOpenShiftException( "Application name \"{0}\" contains non-alphanumeric characters.", name); } else if (Character.isUpperCase(name.charAt(i))) { throw new InvalidNameOpenShiftException( "Application name \"{0}\" contains uppercase letters (only lowercase allowed)", name); } } } protected void validateDomainName(final String name) throws OpenShiftException { for (int i = 0; i < name.length(); ++i) { if (!Character.isLetterOrDigit(name.charAt(i))) { throw new InvalidNameOpenShiftException( "Domain name \"{0}\" contains non-alphanumeric characters", name); } else if (Character.isUpperCase(name.charAt(i))) { throw new InvalidNameOpenShiftException( "Domain name \"{0}\" contains uppercase letters (only lowercase allowed)", name); } } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10966: ------------------------------------------ @Max: in terms of client library, the validation is done only at creation time. @Xavier: what about the UI validation? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-10966 at 2/23/12 9:15 AM: ------------------------------------------------------------------- @Max: in terms of client library, the validation is done only at creation time. So using existing uppercase names should work perfectly fine. @Xavier: what about the UI validation? was (Author: adietish): @Max: in terms of client library, the validation is done only at creation time. @Xavier: what about the UI validation? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10966: ------------------------------------------ @Xavier: so I guess one would have to change the name of an existing domain/app if it was uppercase? but other operations would still work (like choosing an existing app to import). Right? Could I beg you to have a quick test (since you already have the patch applied in your workspace)? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-10966: ------------------------------------------ @xavier: thanks for testing! @Max: are your requirements fullfilled then? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Xavier Coulon commented on JBIDE-10966: --------------------------------------- Patch applied on trunk and on branch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10966?page=com.atlassian.jira.plugi... ] Stefan Bunciak closed JBIDE-10966. ---------------------------------- Names are correctly being checked. Verified on JBoss Tools 3.3.0.Beta1b -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira