[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Dmitry Geraskov commented on JBIDE-6374: ---------------------------------------- Where the screenshots and log? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Jiri Peterka updated JBIDE-6374: -------------------------------- Attachment: NPE-hibernate-configuration-editor.png -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Jiri Peterka commented on JBIDE-6374: ------------------------------------- Sorry Dmitry, JIRA client sync problem... Attachments uploaded -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Max Rydahl Andersen commented on JBIDE-6374: -------------------------------------------- what is the workaround ? And would probably need the actual file used when crashing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Dmitry Geraskov reassigned JBIDE-6374: -------------------------------------- Assignee: Alexey Kazakov (was: Dmitry Geraskov) This could happen if XModelObject returns null-child by "Session Factory" path. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6374: ---------------------------------------------- NewConfigurationWizard creates new file in two stages. First it creates an empty file and then sets content to it. Of course, it is a legal way, but it creates a lot of problems for model update. The typical sequence is as follows. 1) Empty file is created. 2) It is loaded by model as unrecognized xml. 3) Content is set so fast after creation that modification stamp remains the same. 4) Model tries to update, but because it checks file modification stamp to avoid unnecessary update, it skips the file. 5) Editor fails because it gets unrecognized xml. To avoid the issue, I suggest creating new file in one step, by overriding method WizardNewFileCreationPage.getInitialContents which is designated exactly for such purpose. Next, editor should be modified to behave nicely when it receives unexpected input. Finally, I will improve logic of XJob, that as I found in testing, in some cases failed to run tasks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Dmitry Geraskov commented on JBIDE-6374: ---------------------------------------- Looks like NewConfigurationWizard#openContentStream could be used for the purpose. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich updated JBIDE-6374: ----------------------------------------- Attachment: HibConfig3CompoundEditor6374.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich commented on JBIDE-6374: ---------------------------------------------- Dmitry, I just moved calls to putIfNotNull from one place to another. I would avoid unnecessary modifications to avoid side effects. I think minor improvements can be done later as this issue is verified and closed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6374?page=com.atlassian.jira.plugin.s... ] Viacheslav Kabanovich resolved JBIDE-6374. ------------------------------------------ Resolution: Done Merged to branches/jbosstools-3.1.x. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira