[
https://issues.jboss.org/browse/JBIDE-25089?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-25089:
------------------------------------------
The patch is chopping off version characters that are illegal for
org.osgi.framework.Version (that we use to parse/compare versions). The real fix would
have to replace org.osgi.framework.Version by our own class since the oc versioning scheme
doesnt match the osgi versioning scheme.
But for now, this seems good enough
Server adapter wizard: oc version exception thrown when using latest
3.7.1.alpha.1
----------------------------------------------------------------------------------
Key: JBIDE-25089
URL:
https://issues.jboss.org/browse/JBIDE-25089
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.5.1.AM2
Reporter: Andre Dietisheim
Assignee: Rob Stryker
Priority: Minor
Labels: oc_binary, server_adapter_wizard
Fix For: 4.5.1.Final
steps:
# ASSERT: use/configure the oc binary that you can download from
https://github.com/openshift/origin/releases/download/v3.7.0-alpha.1/open...
# ASSERT: make sure that you have an openshift application running in OpenShift
# EXEC: in OpenShift explorer: select the service/dc/rc for your application and choose
"Server adapter..." from the context menu
# ASSERT: server adapter wizard shows up
Result:
In Eclipse log you'll find the following:
{code}
java.lang.IllegalArgumentException: invalid version "3.7.0.alpha.1": invalid
qualifier "alpha.1"
at org.osgi.framework.Version.validate(Version.java:205)
at org.osgi.framework.Version.<init>(Version.java:94)
at
org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.parseVersion(OCBinaryVersionValidator.java:109)
at
org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.parseVersion(OCBinaryVersionValidator.java:93)
at
org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.getVersion(OCBinaryVersionValidator.java:78)
at
org.jboss.tools.openshift.internal.core.preferences.OCBinaryVersionValidator.isCompatibleForPublishing(OCBinaryVersionValidator.java:132)
at
org.jboss.tools.openshift.internal.core.preferences.OCBinary.getStatus(OCBinary.java:137)
at
org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizardPage.<init>(ServerSettingsWizardPage.java:179)
at
org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizardPage.<init>(ServerSettingsWizardPage.java:169)
at
org.jboss.tools.openshift.internal.ui.server.ServerSettingsWizard.<init>(ServerSettingsWizard.java:48)
at
org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.createServer(ServerAdapterHandler.java:137)
at
org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.openOrCreateServerAdapter(ServerAdapterHandler.java:127)
at
org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.getOpenShiftServer(ServerAdapterHandler.java:106)
at
org.jboss.tools.openshift.internal.ui.handler.ServerAdapterHandler.execute(ServerAdapterHandler.java:60)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:291)
at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:92)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:305)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:239)
at
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
at
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:487)
at
org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
at
org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:431)
at
org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:446)
at
org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.lambda$2(AbstractContributionItem.java:472)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:86)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:5268)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1348)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4522)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4107)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1150)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1039)
at
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:680)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:594)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:151)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:653)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:590)
at org.eclipse.equinox.launcher.Main.run(Main.java:1499)
at org.eclipse.equinox.launcher.Main.main(Main.java:1472)
{code}
Eclipse preferences will nevertheless recognize it partly correctly as 3.7.0
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)