[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Rob Stryker updated JBIDE-3050: ------------------------------- Assignee: Rob Stryker -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3050: -------------------------------------------- caching results ? what good would that do ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3050: -------------------------------------------- what does it cache? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Rob Stryker resolved JBIDE-3050. -------------------------------- Fix Version/s: 3.1.0 (was: 3.0.1.GA) Resolution: Done committed with a test case -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3050: ------------------------------------ 1) UI wise, there has been no change for screenshots or anything that might affect docs. Functionality wise, the "preview" will only show the first 30 results. I know this is relatively arbitrary and non-configurable, and I expect future JIRA issues requesting either a workspace preference or a preference in some dialogs to show full results. I didn't want that in there right away, though. If you think this is stupid, I expect to hear about it ;) 2) Honestly, I've been moving the Directory Scanner from a tiny fork of the apache version into its own thing. The changes now are large enough that really to try to keep it the same is silly. The class no longer implements the ant interfaces it implemented before. This made it acceptable to remove those methods if they didn't apply to how I was using the class. So not only comments, but also entire methods. Often times the methods had changed so much that the doc / comments were innacurate. 3) As I said before, I was trying to slim the class down to its core use. My archives descriptor didn't have any way to set following sym links or not and since those methods were unused, I removed them. Following symlinks is now by default (it always was actually. There was no way to turn it off. Now I just removed it from "a variable that always evaluated to true" to just "true".) This also allowed me to simplify several of the methods that required separate logic. 4) The point of the test is to make sure that in the end, the sizes are the same. You don't need to test if it actually "stops" because the way to "stop" it is to not ask for the "next". Essentially, if you're using an iterator, it only scans one folder and doesn't recurse. Instead, it adds all subfolders to a list of folders that can be scanned on the next hasNext() call. A call to hasNext() will either return the next file in the queue that's already been scanned, or if there's no files left but still folders to scan, it will scan the next folder (non-recurse) to see if there are any matches there. If not, the next folder, etc. Can you point me to an ArrayList test that checks to see if the iterator can be "stopped"? No. The proper method of stopping an iterator is... to stop iterating ;) 5) Nothing's wrong with enums or long. I use doubles for the same reason I had eggplant for dinner last night. It seemed like a good idea at the time and there didn't seem to be anything horribly wrong about it. Also, that's not in scope for this bug. 6) Great idea. Not right now. But great idea. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3050: ------------------------------------ #4 Ok, but the class doesn't test if it actually finds what is needed. I.e. if they find 0 matches the test still passes. There is no actual verification of the matcher actually finding what it should. In response to this, there are other tests that verify the matching capabilities. This test just verifies that the iterator has the same number of results and that there's no difference between the results you get from an iterator and those you get from a full scan / iterator. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3050?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3050: -------------------------------------------- but if you had a assertEquals(matches, 27) (or whatever the count was you would be sure the test actually did verify that they were equal. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira