[ https://jira.jboss.org/jira/browse/JBIDE-6214?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-6214: --------------------------------------- Fix Version/s: 3.2.next Affects Version/s: 3.1.0.GA Snjezana, the use case is that those doing the examples would want to use some automated way of generating .project/.classpath files and the closest tool for that is mvn eclipse:eclipse but that is not really what we would like for Maven projects since m2eclipse would/should be the one generating the proper metadata. Can we autodetect how the import should be done for a project (i.e. if .project > import Eclipse project, if no .project and pom.xml import Maven Project, etc.) and possibly have a flag to control this in the project example xml ? Still without requiring the user to have Maven plugins installed...in that case these non-metadata projects would just be treated as normal eclipse projects I would expect. Thoughts ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin.s... ] Max Andersen commented on JBIDE-6214: ------------------------------------- Couldn't we make this an extension point for project examples avoiding a hard dependency to m2eclipse ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin.s... ] Max Andersen commented on JBIDE-6214: ------------------------------------- Yes, sounds good to me. Any place in the ui where users can see the "ignored" list of examples ? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Snjezana Peco resolved JBIDE-6214. ---------------------------------- Fix Version/s: 3.2.0.CR1 (was: 3.2.x) Resolution: Done I have created a new extension point - the org.jboss.tools.project.examples.importProjectExamples extension point that enables a user to import project examples that aren't Eclipse projects. This extension point is implemented for maven projects in the org.jboss.tool.maven.project.examples plugin (the org.jboss.tools.maven.project.examples.feature feature) as follows: <extension point="org.jboss.tools.project.examples.importProjectExamples"> <importProjectExample class="org.jboss.tools.maven.project.examples.ImportMavenProjectExample" name="Import Maven Project Examples" type="maven"> </importProjectExample> </extension> The org.jboss.tools.maven.project.examples.ImportMavenProjectExample class has to implement IImportProjectExample (or to extend AbstractImportProjectExample class). The type element is a marker that determinates the way in which a project example will be imported. An example of a project example that imports a pure maven project is defined on a new site - JBoss Tools Maven Project Examples. If a maven project example would be defined in an old site, JBT <= 3.2.0.Beta2 would try to import it as an Eclipse project. I have created the example using the weld-jsf-login example from the Weld 1.0.1.Final distribution. The project example definition looks as follows: <project> <category>Weld 1.0.1</category> <name>weld-jsf-login</name> <included-projects> weld-examples-parent,weld-jsf-login </included-projects> <shortDescription>Weld JSF login example</shortDescription> <description> The example demonstrates user login/logout for an application that uses JSF. It will create the weld-examples-parent and weld-jsf-login project in your workspace. </description>i <size>17532</size> <url>http://anonsvn.jboss.org/repos/jbosstools/workspace/snjeza/weld-ex... <importType>maven</importType> <importTypeDescription>The project example requires the m2eclipse-core, m2eclipse-wtp and JBoss Maven Project Examples feature.</importTypeDescription> </project> New elements are the following: importType (maven) - marks the project example as a maven project that will be imported in a separate way importTypeDefinition - a message appearing if the user doesn't have the required features (importing a maven project requires the m2eclipse-core, m2eclipse-wtp and JBoss Maven Project Examples feature). The http://anonsvn.jboss.org/repos/jbosstools/workspace/snjeza/weld-examples/... file contains a pure maven project. It is the examples directory from the Weld 1.0.1 distribution from which the following directories have been removed: lib, se, wicket, jsf/numberguess, jsf/permalink, jsf/pastecode and jsf/translator. All the modules except the login module are also removed from the root's pom.xml. It is possible easily packs the complete examples directory and all the Weld examples will be imported to the workspace. If you look at http://anonsvn.jboss.org/repos/jbosstools/workspace/snjeza/weld-examples/..., you will see that it is a pure Maven project that doesn't contain Eclipse artifacts. The imported weld-jsf-login project contains the JBoss CDI facet and can use all the JBoss Tools features. The user can easily create the JBoss AS 6.0 (or any other AS that includes CDI),deploy and execute the application. It is also possible to create a project example based on a maven archetype. The user would only need to enter the artifactId and groupId of the project he wants to create. He wouldn't need to enter the artifactId, groupId, version and repository of the archetype. I have added the org.jboss.tool.maven.project.examples plugin and org.jboss.tools.maven.project.examples.feature feature and updated the according pom.xml files. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Vlado Pakan commented on JBIDE-6214: ------------------------------------ How can JBoss Maven Project Examples feature be installed? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Libor Zoubek commented on JBIDE-6214: ------------------------------------- I have installed all plugins in Maven category in JBoss Tools updatesite and I am getting the same as Vlado. Unable to Finish importing mavenized project example. Here are my JBossTools maven plugins org.jboss.tools.maven.cdi, Version: 1.0.0.v20110114-0220-H7-CR1 org.jboss.tools.maven.core, Version: 1.1.0.v20110114-0220-H7-CR1 org.jboss.tools.maven.hibernate, Version: 1.0.0.v20110114-0220-H7-CR1 org.jboss.tools.maven.jsf, Version: 1.0.0.v20110114-0220-H7-CR1 org.jboss.tools.maven.portlet, Version: 1.0.0.v20110114-0220-H7-CR1 org.jboss.tools.maven.seam, Version: 1.1.0.v20110114-0220-H7-CR1 org.jboss.tools.maven.ui, Version: 1.0.0.v20110114-0220-H7-CR1 Do I need something else? Maybe requried plugins are incorrectly detected. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Max Rydahl Andersen updated JBIDE-6214: --------------------------------------- Fix Version/s: 3.2.0.CR1 (was: 3.2.0.CR2 (tentative)) Priority: Blocker (was: Major) back on CR1 since the actual plugin is missing from jboss tools update site. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Nick Boldt updated JBIDE-6214: ------------------------------ Attachment: maven.proj.ex.patch Revised patch: Two files need to be changed in trunk and CR1 branch: ~/maven/site/site.xml (add feature to catg) ~/build/aggregate/site/site.xml (add feature to Maven catg) Guess we need to add this to the JBDS update site too, eh? -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Nick Boldt commented on JBIDE-6214: ----------------------------------- Right, my bad. So, Maven build H21 is done. http://download.jboss.org/jbosstools/builds/staging/jbosstools-3.2_stable... shows 7 features, instead of previous 6. Waiting on respin of JBT aggregate build so I can close this. (Also waiting on AS/Deltacloud/WS and Examples respins, too.) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6214?page=com.atlassian.jira.plugin... ] Libor Zoubek commented on JBIDE-6214: ------------------------------------- Now I am able to import example mentioned above. verified on v20110121-1718-H21-CR1 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira