[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich updated JBIDE-6287: ------------------------------------- Attachment: JBIDE-6287 - externalize strings wizard.png JBIDE-6287 - toolbar icon.png The draft version of the Externalize Strings Wizard was added. Please see screenshots and toolbar icon. Actually toolbar icon should be updated. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich commented on JBIDE-6287: ------------------------------------------ New File creation was added, table with a content of the properties file was added. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich commented on JBIDE-6287: ------------------------------------------ 1) Menu item was added to the Source Context menu. 2) Selection was updated: when nothing is selected underlying text or property value well be selected. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Vlado Pakan commented on JBIDE-6287: ------------------------------------ Source tab context menu doesn't contain menu item Externalize String on JBDS Version: 4.0.0.M1 Build id: v201007091251N Build date: 201007091354 Linux 32bit Sun Java JDK 1.6. Externalize Strings Toolbar button on the same selection within source tab works correctly -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Vlado Pakan commented on JBIDE-6287: ------------------------------------ I found out that source tab context menu contain menu item Externalize String for .jsp file and not for .xhtml file. I don't know if it's intended to work like that. When I create JSF Kick Start project and add <h:outputText value="xxxxxx" /> tag to inputUserName.jsp file everything works fine. It's possible to translate this tag value and new property name/value is added to proper resource file. When I create blank .xhtml file it doesn't work. There is no source tab context menu item Externalize String and when Externalize dialog is opened via Externalize toolbar button there is not possible to select resource file just create new one but that also doesn't work. File is created with proper properties name/value pair but within the page value from properties file is not evaluated. See attachment of not working .xhtml file. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Vlado Pakan updated JBIDE-6287: ------------------------------- Attachment: notWorkingXHTMLFile.png -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich commented on JBIDE-6287: ------------------------------------------ Changing the initialization had two effects: 1) Bundle from the current page was added to the drop-down list 2) But the message bundle from the <ui:composition>'s template file is missing. To sum up I suggest to leave the current functionality for the xhtml files that use facelets: all the tags out of the <ui:composition> will be ignored. In addition when the application is run on server the bundle value from the bundle is not displayed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich commented on JBIDE-6287: ------------------------------------------ JUnits for the xhtml files and initialization should be added. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich resolved JBIDE-6287. -------------------------------------- Resolution: Done Basic functionality is completed. So the issue is resolved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Golovin updated JBIDE-6287: --------------------------------- Summary: Externilize strings wizard for web page (was: externilize string wizard from web page) Fix Version/s: 3.3.x (was: 3.2.x) Affects Version/s: 3.2.0.Beta (was: 3.2.x) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Maxim Areshkau commented on JBIDE-6287: --------------------------------------- #also we should understand selection in visual part but that should be different issue, selection in visual part=selection in source part, it select the same source nodes, but with different presentation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich edited comment on JBIDE-6287 at 8/31/10 5:30 AM: ------------------------------------------------------------------- 1) As Maxim wrote the text selection in the visual and source parts is the same. So when user selects the text in the visual part I'll add "Externalize strings..." item to the visual part's context menu. 2) I'll correct the window name and the title. 3) I'll disable the toolbar icon when no text is selected. 4) At the moment there is no way to externalize all the strings on the page. Denis, why according to your comment externalizing a single string is not valuable? The idea of the dialog was to create a basic functionality for the single string first and then add support to externalize all the strings on the page. was (Author: dmaliarevich): 1) As Maxim wrote text selection in the visual and source parts are the same. So when user selects text in the visual part I'll add "Externalize strings..." item the visual part's context menu. 2) I'll correct the window name and the title. 3) I'll disable the toolbar icon when no text is selected. 4) At the moment there is no way to externalize all strings on the page. Denis, why according to your comment externalizing a single string is not valuable? The idea of the dialog was to create a basic functionality first for the single string and then add support to externalize all the strings on the page. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Maxim Areshkau commented on JBIDE-6287: --------------------------------------- The main idea of this feature to provide possibility for externalisation of one string. So I have created a task which will be contain extra features for externalising stings processing https://jira.jboss.org/browse/JBIDE-7003 and I assume that one can be resolved. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Golovin resolved JBIDE-6287. ---------------------------------- Fix Version/s: 3.2.0.Beta (was: 3.3.x) Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Denis Maliarevich commented on JBIDE-6287: ------------------------------------------ Now I'm moving Externalize Strings wizard to another plugin ( see JBIDE-7060 ). And the wizard will be separate from the visual editor. Thus we are planning to create toolbar item it the main eclipse toolbar ( as for Selection Bar, see JBIDE-7059 ) and leave the option in the source editor context menu. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Max Andersen commented on JBIDE-6287: ------------------------------------- Main eclipse toolbar ? that one is over crowded..and not reachable via keyboard shortcuts nor context menu. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin.s... ] Vlado Pakan closed JBIDE-6287. ------------------------------ Verified on JBT 3.2.0.v20100929-2012-H96-Beta1. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-6287?page=com.atlassian.jira.plugin... ] Denis Maliarevich commented on JBIDE-6287: ------------------------------------------ Hi Patrick, the option for selecting existed resource bundles exists. Drop-down list is populated with the bundles that are registered on the web page or in the faces-config file. If the resource hasn't been defined neither on the web page nor in the faces-config file it wouldn't appear in the list. In this case checkbox "create a new properties file" gets automatically enabled. And it is expected behaviour to my mind. On the other hand, when no resource bundles are found we shouldn't allow user to edit anything in the bottom of the first page as it's pointless. Nevertheless when resource's file is found it will be selected in the drop-down list, the next field will contain its path, and in the table you will see all the keys and values of this file. So concerning your situation I can assume that there are no registered resource bundles in your project. Could please describe your environment in details? In addition we do not have the functionality to populate drop-down list with any suitable *.properties file which is in the project. I recon we could add this feature though it's depends on the importance. Thus if you have any suggestion or remarks you can put them to new issues regarding the dialog. Thank you for your exploring it. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira