[
https://issues.jboss.org/browse/JBIDE-22968?page=com.atlassian.jira.plugi...
]
Nick Boldt commented on JBIDE-22968:
------------------------------------
A better p2diff check we should use:
{code}
p2diff -mode=deep
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-ope...
\
file://`pwd` \
| egrep -v "\.feature.jar|\.source|Update Site" | egrep "^(<|>)
" | sed -e "s/\(<\|>\) \(.\+\)/\2\1/" | sort | sed -e "s/\(.\+\)
\(<\|>\)/\2 \1/" | egrep "^(<|>)"
{code}
This will enable deep mode, to compare IU contents instead of just looking at filenames.
So instead of finding 10 IUs different in openshift (client plugin + 2 containing features
+ 2 containing feature.groups + sources), we only find that the client plugin (and its
source plugin) have changed. Much cleaner output, especially if we filter out the source
plugin and only see the changed client plugin:
{code}
< org.jboss.tools.openshift.client [3.3.0.AM3-v20160812-0237-B1502]
org.jboss.tools.openshift.client [3.3.0.AM3-v20160812-1420]
{code}
So, next week can see if we can go back to using the jgit timestamp provider for this
plugin, and have p2diff detect the changes in its lib/ folder when SNAPSHOT deps change.
if a build fails to publish, future builds may think there's
nothing new and also not publish
---------------------------------------------------------------------------------------------
Key: JBIDE-22968
URL:
https://issues.jboss.org/browse/JBIDE-22968
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Reporter: Nick Boldt
Assignee: Nick Boldt
Fix For: 4.4.1.AM3
Attachments: openshift-failed-future-builds-did-not-publish.png
When publishing snapshots to
download.jboss.org via Jenkins jobs, we need to add a check
for "did the last build fail? if so, set skipRevisionCheckWhenPublishing =
true"
That way we don't get situations where the Openshift build fails (because failed
enforcer check) and then the next 4-5 builds are NOT published (because as far as the
current tests are concerned, the latest SHA in Jenkins == latest SHA in github... but NOT
the latest SHA on
download.jboss.org/.../snapshots/JOB_NAME/latest/.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)