6:17 a.m.
Mickael Istria created JBIDE-11358:
--------------------------------------
Summary: Replace included features by dependency
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, JBossAS/Servers, jbpm, JSF
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.x
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:19 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria updated JBIDE-11358:
-----------------------------------
Component/s: Build/Releng
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.x
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:17 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Nick Boldt updated JBIDE-11358:
-------------------------------
Fix Version/s: 3.3.0.Beta3
3.3.0.Beta3-SOA
(was: 3.3.x)
Description:
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
was:Some features use included features. This is an anti-pattern with p2 which cause
troubles on further steps using p2. Dependencies are the way to go.
Affects Version/s: 3.3.0.Beta3
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-11358:
----------------------------------------
This is now fixed for AS, JSF and BPEL.
I can't build jBPM locally from a "clean" repo because it seems like --jmx
is not part of the composite repository I use for resolution.
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:27 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria resolved JBIDE-11358.
------------------------------------
Resolution: Done
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:26 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria edited comment on JBIDE-11358 at 3/21/12 5:25 AM:
-----------------------------------------------------------------
This is now fixed for AS, JSF and BPEL.
I can't build jBPM locally from a "clean" repo because it seems like --flow
is not part of the composite repository I use for resolution.
was (Author: mickael_istria):
This is now fixed for AS, JSF and BPEL.
I can't build jBPM locally from a "clean" repo because it seems like --jmx
is not part of the composite repository I use for resolution.
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:46 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-11358:
-------------------------------------------
Mickael, you left "<includes id="org.jboss.tools.jsf.feature"
version="3.3.0" match="greaterOrEqual"/>" in
trunk/jsf/features/org.jboss.tools.richfaces.feature/feature.xml ([changeset
39654|https://source.jboss.org/changelog/JBossTools?cs=39654&_sscc=t])
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:54 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Denis Maliarevich edited comment on JBIDE-11358 at 3/22/12 10:53 AM:
---------------------------------------------------------------------
Mickael, you left "<includes id="org.jboss.tools.jsf.feature"
version="3.3.0" match="greaterOrEqual"/>" in
trunk/jsf/features/org.jboss.tools.richfaces.feature/feature.xml ([changeset
39654|https://source.jboss.org/changelog/JBossTools?cs=39654&_sscc=t])
End Eclipse IDE shows it as an error.
was (Author: dmaliarevich):
Mickael, you left "<includes id="org.jboss.tools.jsf.feature"
version="3.3.0" match="greaterOrEqual"/>" in
trunk/jsf/features/org.jboss.tools.richfaces.feature/feature.xml ([changeset
39654|https://source.jboss.org/changelog/JBossTools?cs=39654&_sscc=t])
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:13 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-11358:
----------------------------------------
Yes, thanks for noticing it.
I didn't change it because included features are not annoying when the oncluded
feature is part of the same component and will be delivered on the same update-site by the
same build.
It is working fine like this, however, If you'd prefer using import here, I encourage
you to do it to avoid future issues.
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:29 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich commented on JBIDE-11358:
------------------------------------------
Anyway, PDE marks this line as "unknown attribute 'match'".
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:35 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Denis Maliarevich commented on JBIDE-11358:
-------------------------------------------
The problem is that "match" attribute is not supported inside <includes>
element (according to Eclipse platform feature manifest).
So if you are leaving <includes> statement you must remove "match"
attribute from it.
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:39 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-11358:
----------------------------------------
Yahor told me the same thing via IRC.
It was working like that before this refactoring and without much trouble. It is probably
ignored by Tycho.
However, this is a separate issue, can you please open a new ticket for it?
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Yahor Radtsevich commented on JBIDE-11358:
------------------------------------------
I created JBIDE-11382 for the match errors.
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:59 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-11358:
----------------------------------------
Thanks
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:59 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Mickael Istria resolved JBIDE-11358.
------------------------------------
Resolution: Done
Looks Ok now, but feel free to reopen if you detect any issue about included features.
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:41 a.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Jiri Peterka closed JBIDE-11358.
--------------------------------
Assuming this can be closed
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta3, 3.3.0.Beta3-SOA
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:40 p.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Nick Boldt updated JBIDE-11358:
-------------------------------
Fix Version/s: 3.3.0.Beta1-SOA
(was: 3.3.0.Beta3-SOA)
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta1-SOA, 3.3.0.Beta3
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:42 p.m.
[
https://issues.jboss.org/browse/JBIDE-11358?page=com.atlassian.jira.plugi...
]
Nick Boldt closed JBIDE-11358.
------------------------------
Resolution: Done
Close again w/ correct -SOA fix version
Replace included features by dependency
---------------------------------------
Key: JBIDE-11358
URL: https://issues.jboss.org/browse/JBIDE-11358
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: BPEL, Build/Releng, JBossAS/Servers, jbpm, JSF
Affects Versions: 3.3.0.Beta3
Environment: any
Reporter: Mickael Istria
Assignee: Mickael Istria
Priority: Blocker
Fix For: 3.3.0.Beta1-SOA, 3.3.0.Beta3
Some features use included features. This is an anti-pattern with p2 which cause troubles
on further steps using p2. Dependencies are the way to go.
== Core ==
* AS
* JSF
== SOA Tooling ==
* BPEL
* jBPM 3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5089
days inactive
5130
days old
jbosstools-issues@lists.jboss.org
17 comments
5 participants
participants (5)
-
Denis Maliarevich (JIRA) -
Jiri Peterka (JIRA)
-
Mickael Istria (JIRA)
-
Nick Boldt (JIRA)
-
Yahor Radtsevich (JIRA)