3:56 a.m.
Rob Stryker created JBIDE-11929:
-----------------------------------
Summary: Project examples freezes during quickfix dialog
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Fix For: 3.3.0.CR1
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-11929:
--------------------------------
Attachment: JBIDE-11929.jstack
full jstack
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Fix For: 3.3.0.CR1
Attachments: JBIDE-11929.jstack
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen updated JBIDE-11929:
----------------------------------------
Priority: Blocker (was: Major)
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: JBIDE-11929.jstack
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Max Rydahl Andersen commented on JBIDE-11929:
---------------------------------------------
Snjezana - why do we block the UI to wait for the builder to finish ? A quickfix could
cause a very long wait and if there is an error/bug in a builder it could lock up the
whole UI.
Wouldn't this be better solved by having a progress monitor going like "Waiting
for <xyz> to finish..." and provide a cancel button which would when pressed
state "<xyz> is not yet finished, there might still be problems left to fix. Do
you want to stop waiting and close the quickfix dialog anyway ?" and then provide a
button to say Yes and close the dialog and let the user be able to fix other things while
the builders wait. And if he says No it goes back to continue waiting for it.
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: JBIDE-11929.jstack
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:32 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Snjezana Peco resolved JBIDE-11929.
-----------------------------------
Resolution: Done
I have added a progress dialog.
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: JBIDE-11929.jstack
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:23 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-11929:
--------------------------------
Attachment: jbide-11929.b.trace
adding a trace
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:30 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-11929:
-------------------------------------
It seems that the workspace job in the marker dialog schedules another workspace job, and
joins on it. Clearly the waitForBuildAndValidation job cannot start until the workspace
job in MarkerDialog finishes, but the workspace job in MarkerDialog is now waiting for
waitForBuildAndValidation to begin. Classic deadlock.
The UI is responsive, however, attempts to cancel the progress monitor do nothing and the
workspace stays in an unusable state.
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:02 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rob Stryker updated JBIDE-11929:
--------------------------------
Attachment: jbide-11929.v2.patch
here's a patch. it also updates the progress monitors.
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack, jbide-11929.v2.patch
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:06 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-11929:
-------------------------------------
In general, the job inside MarkerDialog is a workspace job. Launching another job which
waits on resources family jobs to finish will never end, since job2 is waiting for
resource jobs to finish, but job1 is a resource job waiting for job2 to finish.
The solution was to move the join logic direct into the workspace job in MarkerDialog. I
left out the resource family in that instance, since that seemed to leave my job frozen
also (but able to be canceled). By limiting it only to examples and validation, and since
hte markerDialog job alreayd has the resource lock, all seems to be working much better.
Also the progress monitors work better
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack, jbide-11929.v2.patch
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:02 p.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Snjezana Peco resolved JBIDE-11929.
-----------------------------------
Resolution: Done
Since we don't want to block the UI until markers are updated, we can remove the job
that builds projects and waits for builders and validators to finish.
A quick fix will trigger incremental building of required projects. The job was calling a
full building of all the projects included in a project example.
This is the way in which quick fixes in the Problems view or in some editor work.
Now a quick fix related to the DVD Store project example lasts a few seconds.
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack, jbide-11929.v2.patch
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:03 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rob Stryker commented on JBIDE-11929:
-------------------------------------
this seems to work much better. thanks.
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack, jbide-11929.v2.patch
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:37 a.m.
[
https://issues.jboss.org/browse/JBIDE-11929?page=com.atlassian.jira.plugi...
]
Rastislav Wagner closed JBIDE-11929.
------------------------------------
verified in jbdevstudio-product-universal-5.0.0.v201205272317M-H143-CR1
Project examples freezes during quickfix dialog
-----------------------------------------------
Key: JBIDE-11929
URL: https://issues.jboss.org/browse/JBIDE-11929
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.CR1
Reporter: Rob Stryker
Assignee: Snjezana Peco
Priority: Blocker
Fix For: 3.3.0.CR1
Attachments: jbide-11929.b.trace, JBIDE-11929.jstack, jbide-11929.v2.patch
When importing the dvd seam example project, a list of quickfixes was shown. After trying
to fix each one, the UI would freeze for 15-30 seconds. A Jstack revealed the following:
{code}
"main" prio=10 tid=0x00007f35b8009800 nid=0x26e1 in Object.wait()
[0x00007f35bd93c000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)
- waiting on <0x00000000fe463e08> (a
org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.Semaphore.acquire(Semaphore.java:39)
- locked <0x00000000fe463e08> (a org.eclipse.core.internal.jobs.Semaphore)
at org.eclipse.core.internal.jobs.JobManager.join(JobManager.java:847)
at org.eclipse.core.internal.jobs.InternalJob.join(InternalJob.java:380)
at org.eclipse.core.runtime.jobs.Job.join(Job.java:385)
at
org.jboss.tools.project.examples.dialog.MarkerDialog.okPressed(MarkerDialog.java:237)
{code}
Clearly the UI thread is waiting on a newly scheduled background job, which causes the
freeze. The lines in this stacktrace match with lines in trunk. The offending lines of
code seem to be this:
{code}
ProjectExamplesActivator.waitForBuildAndValidation.schedule();
ProjectExamplesActivator.waitForBuildAndValidation.join();
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5063
days inactive
5071
days old
jbosstools-issues@lists.jboss.org
11 comments
4 participants
participants (4)
-
Max Rydahl Andersen (JIRA) -
Rastislav Wagner (JIRA)
-
Rob Stryker (JIRA)
-
Snjezana Peco (JIRA)