[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=all ] Alexey Kazakov reassigned JBIDE-2219: ------------------------------------- Assignee: Victor Rubezhny -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12412984 ] Alexey Kazakov commented on JBIDE-2219: --------------------------------------- Yes it's true. I reproduce it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413077 ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- I can reproduce the issue only in case of immediately creating an entity (while the project being built and validated). In other cases all works fine. If the issue is reproduced it seems that the modified document isn't freed after the editors are closed. Then, when you start the editor again, this non-discarded document is connected to the new editor. But I don't see a reason why the document isn't discarded (IStructuredModel seems to be released during the editor dispose procedure - this has cause the document to be discarded). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=all ] Snjezana Peco updated JBIDE-2219: --------------------------------- Attachment: org.jboss.tools.seam.ui.patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413135 ] Snjezana Peco commented on JBIDE-2219: -------------------------------------- Good question. I could also ask why other validators don't have that problem, but I won't. :) I suppose that this issue is reproducible when using the VPE editor and Seam Validator because they are slow enough. Re the progressmonitor, I haven't added it because I have created a waiting loop that doesn't lock the UI thread. A user has feedback about building and validating the project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413202 ] Snjezana Peco commented on JBIDE-2219: -------------------------------------- The editor is opened after the project has been built and validated. Do you have the following code (SeamBaseOperation.java, lines 161-162): waitForIdle(); IDE.openEditor(SeamGuiPlugin.getDefault().getWorkbench().getActiveWorkbenchWindow().getActivePage(), iFile); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413205 ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- Off course, the other operations (new action, form etc...) also do not work as expected -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413211 ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- Of course, I have some third-party plugins... But it's not the reason... Almost all the decorators are built-up as infinite jobs, so, the job manager have a change never to be idle. We have realized the procedure that waits while the builder jobs finish in JUnit tests... I'll try to use it here. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413223 ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- Seam Validator is a WST Validation Builder. I have used the method that waits the jobs to complete (from JUnit tests see EditorTestHelper.joinBackgroundActivities() from org.jboss.tools.tests plugin. It works in my environment... The problems are: 1. It's vary slow. (We should wait while all the builders are finished. 2. The third-party code is used (from Eclipse's JUnit test cases) for the wait operation. So, it's question to Max (?) - can we use it in our release? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413226 ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- Snjezana, on the http://jira.jboss.com/jira/browse/JBIDE-2128#action_12410859: the waitng as you doing it could hang in some environments (I'm sure it certainly will hang in the my one). In my environment there are at least two jobs that are never finish their work. These are the Flush Cache Job and Task List Saver. But for some environments your code will work fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413234 ] Snjezana Peco commented on JBIDE-2219: -------------------------------------- Victor, Infinite jobs like the Flush Cache Job and Task List Saver (mylyn, isn't it?) contain a bug (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=198241 ). That's why I added the MAX_IDLE constant. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=comments#action_12413250 ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- I agreed that the cause of this issue is the same as in JBIDE-2090. We have the similar problem with VPE (a long time ago). But the problem was in the templates which help to build the Visual Document. The problem was solved by the cleaning up the Structured Model get/release handling. But for that time we had the facts of the Stuctured Model was un-released. For now all the counters are zeroed for the Read/Edit model operations. It's confusing me. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=all ] Anton Klimkovich closed JBIDE-2219. ----------------------------------- Verified on the latest build. Version: 1.1.0 Build id: 1.1.0.GA Build date: 05/20/2008 13:29 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-2219?page=all ] Anton Klimkovich updated JBIDE-2219: ------------------------------------ Fix Version/s: (was: 2.1.0.GA) Affects Version/s: 3.0.0.alpha (was: 2.1.0.GA) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2219?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-2219: --------------------------------------- Fix Version/s: 3.0.0.beta (was: 3.0.0.alpha) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2219?page=com.atlassian.jira.plu... ] Victor Rubezhny commented on JBIDE-2219: ---------------------------------------- The regression was made by a number of developers who were made the latest changes on org.jboss.tools.vpe plugin. The improper usage of IStructuredModel cause this blocker issue: The class SelectionUtil contains method: public static VpeNodeMapping getNodeMappingBySourceSelection( StructuredTextEditor sourceEditor, VpeDomMapping domMapping); (MAreshkau) which locks the IStructuredModel object for edit but never RELEASES it. The class NodesManagingUtil contains method public static IStructuredModel getStructuredModel( StructuredTextEditor sourceEditor) (SDzmitrovich) but there is no pair-method like releaseStructuredModel - this is a potential error of using the IStructuredModel objects The class DocTypeUtil contains method static private IDOMDocument getDocument(IFile file) (MAreshkau). The model is accessed for read but NOT RELEASED! The class SelectionManager contains method final public void refreshVisualSelection() (MAreshkau) which uses the following code: // get element mapping VpeNodeMapping nodeMapping = SelectionUtil .getNodeMappingBySourceSelection(NodesManagingUtil .getStructuredModel(getSourceEditor()), getDomMapping(), focusOffcetInSourceDocument, anchorOffcetInSourceDocument); It takes the IStructuredModel using the NodesManagingUtil.getStructuredModel(...) call but never RELEASES the model. This happens at least twice in the code... The classes MozillaEditor (MAreshkau) and VpeController (EStherbin) use the DocTypeUtil.getDoctype() method which locks the IStructuredModel for read and never RESEASE it. The IStructuredModel is ALWAYS to be released!!! Gentlemen, let's be carefull while using the IStructuredModel in your code. Each time you're locking it using the IModelManager.getModelForRead/Edit/ or IModelManager.getExistingModelForRead/Edit you must release it using the correspinding release method (see the IModelManager interface). The behaviour of the editors based on Structured Editor are unpredictable in case of you're not releasing the model. These bugs are very difficult to figure out. IMHO. These BLOCKER BUGs are to be fixed for 3.0.0.alfa also I'm assigning the issue to MAreshkau to fix (Maxim will decide who will actually fix) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-2219?page=com.atlassian.jira.plu... ] Maxim Areshkau resolved JBIDE-2219. ----------------------------------- Resolution: Done Assignee: Anton Klimkovich (was: Maxim Areshkau) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira