[
https://issues.jboss.org/browse/JBIDE-18110?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-18110:
------------------------------------------
In the Eclipse logs one could see that the "Del" keybinding was conflicting once
the focus changed from the OpenShift Explorer to the editor:
{code}
!MESSAGE A conflict occurred for DEL:
Binding(DEL,
ParameterizedCommand(Command(org.eclipse.ui.edit.delete,Delete,
Delete the selection,
Category(org.eclipse.ui.category.edit,Edit,null,true),
org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@71831114,
,,true),null),
org.eclipse.ui.defaultAcceleratorConfiguration,
org.eclipse.ui.contexts.window,,,system)
Binding(DEL,
ParameterizedCommand(Command(org.jboss.tools.openshift.express.ui.command.removeconnection,Remove
Connection(s)...,
,
Category(org.eclipse.core.commands.categories.autogenerated,Uncategorized,Commands that
were either auto-generated or have no category,true),
org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@6641fdcf,
,,true),null),
org.eclipse.ui.defaultAcceleratorConfiguration,
org.jboss.tools.openshift.explorer.context.connection,,,system)
Binding(DEL,
ParameterizedCommand(Command(org.jboss.tools.openshift.express.ui.command.deletedomain,Delete
Domain...,
,
Category(org.eclipse.core.commands.categories.autogenerated,Uncategorized,Commands that
were either auto-generated or have no category,true),
org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@767e557b,
,,true),null),
org.eclipse.ui.defaultAcceleratorConfiguration,
org.jboss.tools.openshift.explorer.context.domain,,,system)
{code}
I thus now deactivate the context when the OpenShift Explorer is losing the focus which in
turn deactivates the keybinding. (The "del" keybinding is relying on a context
which we activate/deactivate upon selection change:
{code}
<extension
point="org.eclipse.ui.handlers">
<handler
commandId="org.jboss.tools.openshift.express.ui.command.deletedomain"
class="org.jboss.tools.openshift.express.internal.ui.command.DeleteDomainHandler">
</handler>
</extension>
{code}
OpenShift explorer: cannot delete characters in any editor, OpenShift
forcefully binds "Del" even when no focus
---------------------------------------------------------------------------------------------------------------
Key: JBIDE-18110
URL:
https://issues.jboss.org/browse/JBIDE-18110
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 4.2.0.CR1
Reporter: Marián Labuda
Assignee: Andre Dietisheim
Priority: Critical
Labels: explorer
Fix For: 4.2.0.CR1
We have added shortcuts for deletion of application(s), domain(s) and connection(s) in
OpenShift Explorer view. The "Delete" shortcut, often used in text editor,
invoke dialog to delete an entry (application/domain/connection). The problem is that
shortcuts are taken all the time, although the OpenShift Explorer view has lost focus.
This cause deletion of character in text editors impossible while OpenShift Explorer is
opened.
We should set up to listen for shortcuts if and only if OpenShift Explorer view is opened
and has focus.
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)