[
https://issues.jboss.org/browse/JBIDE-21657?page=com.atlassian.jira.plugi...
]
Mickael Istria commented on JBIDE-21657:
----------------------------------------
Most project using Gerrit validations job at
Eclpse.org do use the repo URL under Jenkins
for testing, and there actually have been no complaint because of that that I'm aware
of. Jenkins can be configured to keep the last N builds or to keep builds for N days.
It's pretty sufficient.
About need to aggregate PR builds, or the issue of too many incoming PRs or even
performance of the download of PR builds, I believe this is way too early to consider
those. By adding them to the scope right now, without a clear need for them, we add
complexity where it's probably not necessary and make it more complex and longer to
implement.
set up jobs to handle building from PRs
---------------------------------------
Key: JBIDE-21657
URL:
https://issues.jboss.org/browse/JBIDE-21657
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.3.1.Beta2, 4.4.0.Alpha1
Reporter: Nick Boldt
Assignee: Nick Boldt
Priority: Critical
Fix For: 4.4.0.Alpha2
First experimental build:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sit...
Output:
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
{code}
"revision" : {
"HEAD" : "bfe76fb3f3c34d68b873d0acf715e2145e4cb805",
"currentBranch" : "HEAD",
"knownReferences" : [{
"name" : "origin",
"url" :
"git://github.com/jbosstools/jbosstools-build-sites.git",
"ref" : "pr/221/merge"
}]
},
{code}
http://download.jboss.org/jbosstools/neon/snapshots/builds/jbosstools-bui...
{code}
#Fri Feb 05 16:42:42 EST 2016
null\:merge=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
HEAD=bfe76fb3f3c34d68b873d0acf715e2145e4cb805
{code}
build log:
{code}
Started by upstream project
"jbosstools-build-sites.aggregate.child-sites__pull-request_master" build number
1
originally caused by:
GitHub pull request #221 of commit 50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge
conflicts.
...
Fetching upstream changes from
git://github.com/jbosstools/jbosstools-build-sites.git
> git -c core.askpass=true fetch --tags --progress
git://github.com/jbosstools/jbosstools-build-sites.git +refs/heads/*:refs/remotes/origin/*
+refs/pull/*:refs/remotes/origin/pr/*
Checking out Revision bfe76fb3f3c34d68b873d0acf715e2145e4cb805
(refs/remotes/origin/pr/221/merge)
> git config core.sparsecheckout # timeout=10
> git checkout -f bfe76fb3f3c34d68b873d0acf715e2145e4cb805
{code}
vars:
{code}
-DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
-DghprbPullId=221
-Dsha1=origin/pr/221/merge
"-DghprbPullDescription=GitHub pull request #221 of commit
50c10ad83d250d2b86f5697c4581ba8f9cb4937d, no merge conflicts."
-DghprbActualCommit=50c10ad83d250d2b86f5697c4581ba8f9cb4937d
{code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)