[ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.... ] Mickael Istria updated JBDS-2153: --------------------------------- Attachment: JBDS-2153-step1.png JBDS-2153-step2.png JBDS-2153-step3.png I have a patch (too big to be attached) that replace wrapping of findbugs and pmd bundles by consumption of the features from the requirements site. Build and installation perform well, here are screenshots of how UI looks like when trying to install them: !JBDS-2153-step1.png! => !JBDS-2153-step2.png! => !JBDS-2153-step3.png! Is it OK, can I commit it? Be aware that this is currently only relevant for bundles that were wrapped because of issue in plugin & feature name being the same (which is no more true with Tycho 0.14 according to my local tests and installation). Then I removed the wrapped bundles and used <requires><import feature="..."/></requires> in our features and added the "official" feature uncategorized on the generated site. This does not yet apply to springsource bundle, that was overriden because of its intrusion in welcome screen. We'll need to verify if the JBDS welcome screen is still affected before removing it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-2153: ---------------------------------- Looks like JBDS-1983 and Tycho 0.14 have removed the need clone/patch wrap 3rd party plugins and provide them wrapped w/ our features. Just checked what happens when you take JBDS 5.0.0.CR1 and install everything from Central into it (including JRebel, which used to break the Welcome screen), and it's fine. So... I think we're ok to "unwrap" these 3rd party inclusions. One caveat, however... If we don't provide our own com.jboss.jbds.* features, then we open the floodgates for people to be able to update these features from 3rd party sites w/o our first vetting them through QE. (See "Investigate" issues JBDS-1998, JBDS-2001, JBDS-1946, JBDS-1874, JBDS-1925, etc.) So if we want to continue to prevent users from being able to update from the version of Spring we test/support to an unsupported one (see JBDS-1925), we still need the com.jboss.jbds.* features, but they can now simply include the third party FEATURES instead of third party PLUGINS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-2153: ---------------------------------- Note too that feature.xml from 3rd party may provide <update> or <discovery> URLs which will populate the JBDS "Available software sites" view with sites which can then be searched manually or automatically for updates. If we don't like that we need to prevent users from installing the 3rd party features and only install the plugins (wrapped w/ our features). If we're ok w/ JBDS becoming cluttered w/ 3rd party update sites, then sure, let's just install their features and let loose the dogs of war. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.... ] Nick Boldt edited comment on JBDS-2153 at 5/23/12 3:23 PM: ----------------------------------------------------------- Looks like if we want to use p2.inf to scrub out 3rd party site references, we can try this: http://help.eclipse.org/indigo/index.jsp?topic=/org.eclipse.platform.doc.... eg., {code} instructions.unconfigure=\ org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);\ org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...);\ ... {code} or {code} instructions.configure=\ org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);\ org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...);\ ... {code} was (Author: nickboldt): Looks like if we want to use p2.inf to scrub out 3rd party site references, we can try this: http://help.eclipse.org/indigo/index.jsp?topic=/org.eclipse.platform.doc.... eg., {code} instructions.unconfigure=org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...); ... {code} or {code} instructions.configure=org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...); ... {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin.... ] Nick Boldt commented on JBDS-2153: ---------------------------------- If Central or Extras provide a com.jboss.jbds.whatever.feature, and the user wants to roll their own with the org.whatever.feature, nothing stops them from uninstalling and "going off the menu" for some a la carte wackiness. But I still think the default option should be to install OUR VERSION of the 3rd party add-on. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira