[
https://issues.jboss.org/browse/JBDS-2153?page=com.atlassian.jira.plugin....
]
Nick Boldt edited comment on JBDS-2153 at 5/23/12 3:23 PM:
-----------------------------------------------------------
Looks like if we want to use p2.inf to scrub out 3rd party site references, we can try
this:
http://help.eclipse.org/indigo/index.jsp?topic=/org.eclipse.platform.doc....
eg.,
{code}
instructions.unconfigure=\
org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);\
org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...);\
...
{code}
or
{code}
instructions.configure=\
org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);\
org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...);\
...
{code}
was (Author: nickboldt):
Looks like if we want to use p2.inf to scrub out 3rd party site references, we can try
this:
http://help.eclipse.org/indigo/index.jsp?topic=/org.eclipse.platform.doc....
eg.,
{code}
instructions.unconfigure=org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...);
...
{code}
or
{code}
instructions.configure=org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:0,location:http${#58}//...,name:...);org.eclipse.equinox.p2.touchpoint.eclipse.removeRepository(type:1,location:http${#58}//...,name:...);
...
{code}
Do not embed/wrap 3rd-party bundles in our sources
--------------------------------------------------
Key: JBDS-2153
URL:
https://issues.jboss.org/browse/JBDS-2153
Project: Developer Studio (JBoss Developer Studio)
Issue Type: Enhancement
Security Level: Public(Everyone can see)
Affects Versions: 5.0.0.Beta3
Reporter: Mickael Istria
Assignee: Mickael Istria
Fix For: 5.0.0.CR1
Attachments: JBDS-2153-step1.png, JBDS-2153-step2.png, JBDS-2153-step3.png
in devstudio/extras, we can see that we define some "wrapper" bundles for 3rd
party deps (findbugs, pmd, spring...). This is not the most straightforward approach, and
it seems like we could improve it. Here are some reasons that would have justified this
implementation, and some reasons why we can improve it:
> a) the plugin and feature have the same IU name and therefore confuse Tycho
How is this possible? p2 adds .feature.group to features. We should think about a
3rd-party feature that requires either this plugins or features, that we could provide in
the extras site.
> b) the plugin contributes to the welcome screen and breaks JBDS, so we override that
According to Max, this is no more the case.
> c) because the license doc is incomplete so we provide a more explicit/accurate
license by wrapping it w/ our own feature
We can use our feature and add this bundle as required, so we use their bundles and they
are installed from our feature. Using required allows people to perform updates from the
other sites by themselves.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:
http://www.atlassian.com/software/jira