[JBoss JIRA] (JBIDE-10343) Small refactoring for org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
6:44 a.m.
Small refactoring for org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:50 a.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Vitali Yemialyanchyk updated JBIDE-10343:
-----------------------------------------
Attachment: JBIDE-10343_20111205.patch
JBIDE-10343_20111205.patch - this is how I imagine the issue could be fixed.
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 a.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10343:
-----------------------------------------------
That looks ok, but why the first command is not included into addJSFNature method? It
ensures that the project is a faceted project. Without it, if the method is invoked on a
non-faceted project, it will fail.
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:46 a.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Vitali Yemialyanchyk commented on JBIDE-10343:
----------------------------------------------
1) I create the project programmatically - so it is by default the faceted project;
2) here I do not want to have additional dialog;
3) the dialog hang on the faceted project;
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:48 a.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10343:
-----------------------------------------------
Ok, please commit.
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:20 p.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich commented on JBIDE-10343:
-----------------------------------------------
Sorry, Vitali, I should commit the change myself.
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:05 p.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Viacheslav Kabanovich resolved JBIDE-10343.
-------------------------------------------
Fix Version/s: 3.3.0.Beta1
Resolution: Done
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Fix For: 3.3.0.Beta1
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 p.m.
[
https://issues.jboss.org/browse/JBIDE-10343?page=com.atlassian.jira.plugi...
]
Vlado Pakan closed JBIDE-10343.
-------------------------------
Verified in SVN.
Small refactoring for
org.jboss.tools.jsf.ui.action.AddJSFNatureActionDelegate required
---------------------------------------------------------------------------------------
Key: JBIDE-10343
URL: https://issues.jboss.org/browse/JBIDE-10343
Project: Tools (JBoss Tools)
Issue Type: Feature Request
Components: common/jst/core
Affects Versions: 3.3.0.M5
Reporter: Vitali Yemialyanchyk
Assignee: Viacheslav Kabanovich
Priority: Optional
Fix For: 3.3.0.Beta1
Attachments: JBIDE-10343_20111205.patch
It would be nice to change AddJSFNatureActionDelegate.run method content into public
static function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5207
days inactive
5244
days old
jbosstools-issues@lists.jboss.org
7 comments
6 participants
participants (6)
-
Viacheslav Kabanovich (Commented) (JIRA) -
Viacheslav Kabanovich (Resolved) (JIRA)
-
Vitali Yemialyanchyk (Commented) (JIRA)
-
Vitali Yemialyanchyk (Created) (JIRA)
-
Vitali Yemialyanchyk (Updated) (JIRA)
-
Vlado Pakan (JIRA)