[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3767: -------------------------------------------- The "clean..." button in the servers view is not enough for you ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] arne anka commented on JBIDE-3767: ---------------------------------- oh, and clean does not work immediately -- it first comes up with a dialog which needs to be clicked. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3767: --------------------------------------- Component/s: JBossAS -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3767: -------------------------------------------- I thought Galder also simply wanted to press less ;) With respect to the selections doesn't start/stop/restart/publish correspond to the context menu operations in the view ? Here you can right click a module and get the same operations - but that is maybe just going directly to the server object without any info on which module is selected ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3767: ------------------------------------ The issue is that the server actions (in the top area) are all: 1) contributed by wtp 2) only work for IServer objects none of them work for modules. at all. and I can't change those classes. My options are: 1) I can duplicate those classes and change them, but that'd be code duplication and a divergence from wtp code. 2) Or I can suggest WTP change them so that they work on modules also. Then we get to wait 3) I can add a new icon for full publish that works on a particular module rather than a server. However incremental publish would still work only for the servers as that action is (still) contributed by WTP. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3767: ------------------------------------ that's a fine solution for now, but that means I'm changing what's in the view, and then we can never integrate fully with the official server's view once htey switch to common navigator. We'd need to include our view thereafter even if it's 99% the same. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3767: ------------------------------------ to be clear, do you mean if a project is selected in the servers view or in some other view? I doubt I'd get WTP approval to have those actions listen to selections outside of the servers view. The best I think I could come up with would be to allow those actions to work on modules inside the server's view rather than just servers. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker updated JBIDE-3767: ------------------------------- Fix Version/s: (was: 3.0.1.GA) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker resolved JBIDE-3767. -------------------------------- Resolution: Won't Fix The incremental publish button works with no right-click and should work for most cases. For a full publish, you will still need to right-click and select full publish. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Max Rydahl Andersen reopened JBIDE-3767: ---------------------------------------- Reopening this because it comes more and more clear that this is rather annoying. Burr Sutters usecase: First, why are you in need of full publish ? The content should be publishing on every save anyway and with you running in archive mode touch of jboss-esb.xml not needed since the archive it self is being updated. - Some (but not all) updates publish like changes to the jboss-esb.xml - New Custom Actions do not seem to publish - Sometimes updates to jboss-esb.xml publish at inopportune times, causing all sorts of ugly errors on the server console - for instance, I add a Service, hit Save before I have added an action - that causes a deployment error. Another one is when I add a listener to my service but forget to check InVM Global. So, based on my recent many hours of using CR1, my habit is to turn on zipped deployment and turn off auto-publish to minimize the problems. This actually works out pretty well aside from the need to click on the Server tab and selecting Full Publish a bunch. So even with the bug fixed concerning classes not being deployed properly for some having a shortcut key or direct clickable button for both publish and incremental publish seems to me very valid. Rob, what are our options ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker commented on JBIDE-3767: ------------------------------------ Full publish is there in case (god forbid) the deployment is messed up and needs to be completely republished. It's basically a shortcut to removing the module and then re-adding the module. Instead of just updating the changes, it would update the entire module. Some users find this valuable. I know I do. If you're running in archive mode, sure touching the xml is not necessary. If you're not running in archive mode, it is necessary. Therefore, we touch the xml file. I am not sure why this is a problem? When should we *not* be touching the xml file? Are there a specific class of changes that we shouldn't be updating the xml file for? This seems like a different issue altogether. This seems very vague. Are the files not copied into the deployment, or is the runtime not recognizing them? This is just how it works. If you don't want automatic publishing, then turn it off. I'm trying to get upstream to accept a new option for autopublish to only go on BUILD events rather than save events, but upstream is SLOW AS BALLS at integrating or approving my patch and it angers me. I still fail to see how having an icon in the view for "full publish" is much better than right-clicking the module and selecting full publish. Let's analyze this a bit. First, let's discuss hotkeys. There are two options with hotkeys. A hotkey with a selection, and a hotkey without a selection. A hotkey without a selection is, quite frankly, not doable at all. The reason is because many workspaces have several servers, and each server may have several modules. This hotkey would have absolutely no idea which server you want to target, and more importantly which module under that server you want to FULL PUBLISH. If there are 5 servers and each has 3 child modules, I have no idea what this FULL PUBLISH hotkey should do without a selection. Sorry. We need a selection. A hotkey with a selection, however, is exactly as much work as the current UI / flow is. In order to select the proper module, you'd need to open the server view, expand it, and select the proper child module. This is all done using the mouse. In the current workflow, you then keep your hand on the mouse, right-click that module, and select FULL PUBLISH. In the suggested workflow, you then remove your hand from the mouse, place it on the keyboard, and enter a most-likely complex hotkey (all the simple ones are taken). I and many studies have found that when the first half of a workflow involves the mouse, you should maintain the second half using the mouse if it's just one or two more clicks, especially when it looks like the user will immediately put their hand right back on the mouse after executing that hotkey (to then switch to an editor or other view). The other option is of course a button at the top of the view for full publish. But there are several problems with this. First, those buttons all must subclass ServerAction, and unfortunately ServerAction *only* accepts IServer objects, not the child modules. What this means is you wouldn't be able to FULL PUBLISH a single module, but only a server (which would full publish ALL modules deployed to it). I've suggested, again, patches upstream to allow the regular publish icon to work for IModule objects, but upstream enjoys ignoring me. However, even if we could get a "Full Publish" button at the top of the view, it suffers from the same problems the hotkey does. The user would still need to activate the Server view, expand their chosen server, and select their module. The only difference, again, is that with a button at the top, the user would single-click the module, then single-click the button. In the current workflow, the user right-clicks the module, then single clicks Full Publish. Both of these involve two clicks. The only things I can imagine doing to cut down on clicks (hotkey, magic button) have no way of knowing which module you want to fully publish. The only way to clue these in is via selection, and once you've gone through the trouble of selecting the module, the hotkey and publish button provide no click-count benefit vs the right-click followed by Full Publish. I'm not sure what you'd want me to do that could possibly speed this up. Every case requires a selection. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Rob Stryker resolved JBIDE-3767. -------------------------------- Resolution: Partially Completed -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3767?page=com.atlassian.jira.plu... ] Burr Sutter commented on JBIDE-3767: ------------------------------------ "If it is already deployed to several servers, it will full-publish it to the first server that is returned in the list. " Will this logic take into account what server is "up"? I might have 3 servers configured and the archive (ESB or WAR) deployed to all 3, however, only one server will be active/up at any given time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira