[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3623: --------------------------------------- Fix Version/s: 3.0.0.GA Assignee: Pete Muir Pete - do you know of any changes in the embedded jboss runs in Seam 2.1 that could cause this ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Steve Lee commented on JBIDE-3623: ---------------------------------- I have reproduced the issue under the following environment: Windows Vista SP1 Eclipse 3.4 Seam 2.1.1GA JbossTool Clipse Plugin 3.0.0CR2 Java 1.5.0_16 Can someone provide a workaround? Everybody will encounter this scenario just in the very first day of trying Seam. What I did was this: Create a Seam Project under Eclipse Seam generated the entity from existing DB Added a Seam Action by using Eclipse JbossTool Run TestNG on ActionLocalTest.xml generated by Seam Action code. The error log is as follows: [Parser] Running: C:\Users\ian\workspace34mian\firstSeam-test\test-src\org\domain\firstseam\test\ActionLocalTest.xml FAILED CONFIGURATION: @BeforeSuite startSeam java.lang.IllegalStateException: Two components with the same name and precedence - component name: groupUsersHome, component classes: org.domain.firstseam.session.GroupUsersHome, org.domain.firstseam.session.GroupUsersHome at org.jboss.seam.init.Initialization.addComponentDescriptor(Initialization.java:596) at org.jboss.seam.init.Initialization.installScannedComponentAndRoles(Initialization.java:949) at org.jboss.seam.init.Initialization.installHotDeployableComponents(Initialization.java:847) at org.jboss.seam.init.Initialization.init(Initialization.java:725) at org.jboss.seam.mock.AbstractSeamTest.startSeam(AbstractSeamTest.java:919) at org.jboss.seam.mock.SeamTest.startSeam(SeamTest.java:58) ... Removed 15 stack frames SKIPPED CONFIGURATION: @BeforeClass setupClass SKIPPED CONFIGURATION: @BeforeMethod begin SKIPPED CONFIGURATION: @AfterMethod end SKIPPED CONFIGURATION: @AfterClass cleanupClass SKIPPED: test_actionMethod -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Steve He commented on JBIDE-3623: --------------------------------- Thanks, Max. You are right. Seam 2.0.3CR is working for me. Looks like Seam 2.1.1GA is not usable with Jboss Tools for war deployment type due to TestNG failure. Indeed, the workaround is to use Seam 2.0.3CR1 for War deployment. You can still use Seam 2.1.1 for Ear deployment. Too bad that Seam 2.1.1 can not be used although it is a GA version. How come that integration testing of Seam 2.1.1 GA did not catch this. Also, process wide, does this bug belong to Same 2.1.1 or Jboss Tools? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3623: -------------------------------------------- Which version of AS did you use ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Ian.H commented on JBIDE-3623: ------------------------------ I mean Jboss 4.2.2GA -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3623: --------------------------------------- Fix Version/s: 3.0.1.GA 3.1.0 (was: 3.0.0.GA) Priority: Blocker (was: Major) I just confirmed this and I'm sure this is something to do with the same issue we had with JSF - somehow Seam loads the same component twice even though it should ignore it. We can't fix this for GA. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3623: -------------------------------------------- I looked at the classpath testng uses and there is only one .class file with authenticator as far as I can see - I was thinking that both web-inf/dev and build/classes would have it but only web-inf/dev has it so it is a bit mystical how it can find two ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3623: --------------------------------------- It doesn't work with Seam 2.1.0SP1 either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3623: --------------------------------------- I've checked Seam 2.1.0CR1. It works! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3623: -------------------------------------------- Since I assume this is some subtle bug in Seam and not something we can do anything about in JBoss tools (since we only have the class once in the classpath) i'm not holding back the GA release (which is planned to be next week) - but knowing what causes this would be great! Especially if we would have a workaround (i.e. upgrade to Seam 2.1.1 or whatever) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3623: -------------------------------------------- well if you find a way to fix this by adjusting class path I would be impressed since the class is only in one of them ;) And in any case - what changed between Seam 2.1.0.CR1 and 2.1.0.SP1 that could cause this (which does not happen in any other release ?) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Dan Allen commented on JBIDE-3623: ---------------------------------- Great news! I have a solution and an explanation. Let me start with the explanation. The reason we are seeing two components with the same name, even though there is only one class file, is because the path WEB-INF/dev is being used as both a regular classpath entry and the hot deployment classpath entry. The first one comes from the classpath of the main project. <classpathentry kind="src" output="view/WEB-INF/dev" path="src/action"/> That classpath entry is inherited by the test project. Then, the test project defines the following additional classpath entry <classpathentry kind="lib" path="/testngtest/view"/> Because of this second entry, Seam finds the WEB-INF/dev folder and activates the hot deployment strategy. So the same component is found by two different deployment strategies (it is loaded twice). Okay, so that begs the question, why is the hot deployment strategy being used at all. Well, that is what changed between Seam 2.0 and Seam 2.1. We changed how the hot deployment strategy is activated. It used to be that if the jboss-seam-debug.jar was on the classpath (and the hot deployment filter enabled), the hot deployment would be activated. Now, it's controlled by the debug property on the org.jboss.seam.core.init component, which makes more sense. In Seam projects created by JBDS, the default setting for this property is true. The simplest possible way to correct this problem is to add the following property to test-src/seam.properties in the test project. org.jboss.seam.core.init.debug=false Which is exactly what you want. You want debug disabled in the test project. This restores the previous behavior. Truth be told, we still need to do some work to more clearly define what debug mode means, but this works with today's definition. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Dan Allen commented on JBIDE-3623: ---------------------------------- It's safe to apply to all Seam versions. In response to your other question, Seam isn't just loading the class, it's loading the class+annotations which it considers a unique component, so precedence rules kick in. The question to be asked is why Seam can't recognize that it's the exact same file. That's really where the difficulty lies. We need to figure out if there is a way to not use the hot deploy classpath if it is already a regular classpath entry. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Dan Allen commented on JBIDE-3623: ---------------------------------- I haven't dove into the details, but some how Seam 2.1 is more aggressive in resolving the hot deploy path. My guess is that in Seam 2.0 it simply could not find it in the test execution environment and thus never used it. Clearly in Seam 2.1 it is being used. So when the same class file is loaded but two different classloaders, how can you tell it came from the same file location? Given the abstract at which the Seam deployment scanner works, I'm not sure it is simple to figure this out. I still say that it is better if we just ensure that the two classloaders don't try to use the same location. But I'm speaking at a high level. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Pete Muir commented on JBIDE-3623: ---------------------------------- Yes, this shouldn't happen. Scanned classes are kept in a Set so that you should get <= 1 per deployment. It looks like some equals is broken somewhere. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Pete Muir commented on JBIDE-3623: ---------------------------------- Can you try to set the flag as we aren't in a position to release Seam 2.1.2 that soon... Please, create a JBSEAM and assign to Dan :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3623: --------------------------------------- Workaround Description: (was: in test-src/seam.properties in the test project add org.jboss.seam.core.init.debug=false) Assignee: Alexey Kazakov (was: Dan Allen) Workaround: (was: [Workaround Exists]) Pete/Dan: Done, see JBSEAM-3996 Alexey: Could you add a "hack" that ensures that when we copy the seam.properties file for Seam 2.1 versions we add the following to test-src/seam.properties in the test project. #debug is explicitly disabled in test to avoid JBIDE-3623 org.jboss.seam.core.init.debug=false -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Dan Allen commented on JBIDE-3623: ---------------------------------- I realized that the one downside to this solution is that debug components will no longer be enabled when running tests. Those are components which have @Install(debug=true). However, the preferred approach is to use @Install(precedence=Install.MOCK) anyway. It's just important to make a note. Long term we should still think about making Seam smart enough to recognize that the hot deploy path is also in the regular classpath. That would need to be a separate jira. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen resolved JBIDE-3623. ---------------------------------------- Resolution: Done ok, just verified Alexey's fix (I also added in some resource stream closing to avoid locking under windows) war and ear projects for Seam 2.1 projects will now have something like this: #debug is explicitly disabled in test to avoid JBIDE-3623 #Mon Mar 09 13:50:28 CET 2009 org.jboss.seam.core.init.debug=false -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Aliaksey Nis reopened JBIDE-3623: --------------------------------- EXECUTE: Create Seam 2.1.1GA war project. EXECUTE: Create action(with name "action1") and form(with name "form1") for this project. EXECUTE: Run test NG for this action. ASSERT: All ok, test run successful. EXECUTE: Create Seam 2.1.0 SP1 war project. EXECUTE: Create action(with name "action1") for this project. EXECUTE: Run test NG for this action. FAILURE: Tests failed. Exception appears in console view . FAILED CONFIGURATION: @BeforeSuite startSeam java.lang.IllegalStateException: Two components with the same name and precedence - component name: action1, component classes: org.domain.seam21war.session.Action1, org.domain.seam21war.session.Action1 at org.jboss.seam.init.Initialization.addComponentDescriptor(Initialization.java:586) ... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3623: --------------------------------------- "org.jboss.seam.core.init.debug=false" seems not to work with Seam 2.1.0SP1 Seam 2.1.1GA works fine. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Carsten Christensen commented on JBIDE-3623: -------------------------------------------- Hi Max Try setting the debug property in components.xml to "false" as well -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3623?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3623: -------------------------------------------- i.e. setting the property should be the same as setting it in components.xml -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira