[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10315: ------------------------------------------- {code} if (!pageContext.getVisualBuilder().isFileInIncludeStack(file)) { //registerDefine(pageContext, sourceNode); Document document = pageContext.getVisualBuilder() .getIncludeDocuments().get(file); if (document == null) { document = VpeCreatorUtil.getDocumentForRead(file); } // Document document = VpeCreatorUtil.getDocumentForRead(file, pageContext); if (document != null) { /* * Putting include document */ pageContext.getVisualBuilder() .getIncludeDocuments().put(file, document); creationData = createInclude(document, visualDocument); creationData.setData(new TemplateFileInfo(file)); /* * Pushing include stack and right after that -- * registering DOM Mapping with visual element: * which is <DIV VPE:INCLUDE-ELEMENT="yes"> */ pageContext.getVisualBuilder().pushIncludeStack( new VpeIncludeInfo((Element) sourceNode, file, document)); registerDefine(pageContext, sourceNode, creationData.getNode()); ... {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10315: ------------------------------------------- VpeDefineContainerTemplate class was updated. But there is a problem with resolving EL expressions. Particularly connected with JBIDE-4179. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich commented on JBIDE-10315: ------------------------------------------- JUnit for JBIDE-4179 is failed because visualRefresh() hasn't been performed after changing an attribute's value. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich edited comment on JBIDE-10315 at 12/8/11 6:38 AM: -------------------------------------------------------------------- JUnit for JBIDE-4179 is failed because the node hasn't been updated after changing an attribute's value. VpeVisualDomBuilder.udpateNode(node) is not called. VPEUpdateJob hasn't been started. The reason: DOMMapping wasn't created for invisible tag. Fixed. was (Author: dmaliarevich): JUnit for JBIDE-4179 is failed because the node hasn't been updated after changing an attribute's value. VpeVisualDomBuilder.udpateNode(node) is not called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich updated JBIDE-10315: -------------------------------------- Description: VpeDefineContainerTemplate has not effective logic in createTemplate(..) method. Such as unnecessary ifs, missing sourceNode registratoin in the map, locall regexp patterns. Should be refactored. was: Particularly createTemplate(..) method. registerDefine(pageContext, sourceNode) -- could be placed inside if condiotion. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich resolved JBIDE-10315. --------------------------------------- Resolution: Done Resolved. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10315?page=com.atlassian.jira.plugi... ] Denis Maliarevich closed JBIDE-10315. ------------------------------------- Closed as there were made only code style adjustments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira