[JBoss JIRA] (JBIDE-12620) openshift java client: should not load all applications when creating a new application
4:41 p.m.
Andre Dietisheim created JBIDE-12620:
----------------------------------------
Summary: openshift java client: should not load all applications when
creating a new application
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.0.Alpha2
When creating a new application, the openshift-java-client would lookup if the application
name already exist. When doing that it'll load the existing apps from the backend if
they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:48 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12620:
-------------------------------------
Description:
When creating a new application, the openshift-java-client would lookup if the application
name already exist. When doing that it'll load the existing apps from the backend if
they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend if
they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
was:
When creating a new application, the openshift-java-client would lookup if the application
name already exist. When doing that it'll load the existing apps from the backend if
they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.0.Alpha2
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:03 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-12620:
------------------------------------------
the check makes no sense if we're only looking into the cached apps. I would either
make no check at all, let the backend fail or eventually load all apps from the backend to
check. Thinking twice I'd pretend that this is backend logic, to have unique
application names. The client should not implement backend logic. I'll simply drop
this check.
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.0.Alpha2
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:54 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-12620:
------------------------------------------
I reverted the change, reintroduced the check since we have to load the list of
applications at least when we want to add the new applicaton to the list of available
applications.
{code:title=DomainResource#createApplication adds the new application to the list of
available applications after it created it}
IApplication application = new ApplicationResource(applicationDTO, cartridge, this);
getOrLoadApplications().add(application);
{code}
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.0.Alpha2
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:54 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim resolved JBIDE-12620.
--------------------------------------
Resolution: Won't Fix
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.0.Alpha2
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:54 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-12620:
------------------------------------------
We could eventually further defer the lazy loading of available appliactions. We would
then have to merge the list of existing, freshly created applications with the existing
ones once they're loaded.
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.0.Alpha2
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:56 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-12620:
-------------------------------------
Fix Version/s: 4.0.x
(was: 4.0.0.Alpha2)
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.x
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:56 p.m.
[
https://issues.jboss.org/browse/JBIDE-12620?page=com.atlassian.jira.plugi...
]
Andre Dietisheim edited comment on JBIDE-12620 at 9/14/12 11:54 AM:
--------------------------------------------------------------------
reopened to implement further deferring of application loading and merging into th e list
of created applications
was (Author: adietish):
reopen to implement further deferring of application loading and merging into th e
list of created applications
openshift java client: should not load all applications when creating
a new application
---------------------------------------------------------------------------------------
Key: JBIDE-12620
URL: https://issues.jboss.org/browse/JBIDE-12620
Project: Tools (JBoss Tools)
Issue Type: Enhancement
Components: openshift
Affects Versions: 3.3.0.Final
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 4.0.x
When creating a new application, the openshift-java-client would lookup if the
application name already exist. When doing that it'll load the existing apps from the
backend if they're not cached yet:
{code:title=stacktrace when creating a new application}
at
com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:137)
at
com.openshift.internal.client.DomainResource.loadApplications(DomainResource.java:189)
at
com.openshift.internal.client.DomainResource.getApplications(DomainResource.java:179)
at
com.openshift.internal.client.DomainResource.getApplicationByName(DomainResource.java:141)
at
com.openshift.internal.client.DomainResource.hasApplicationByName(DomainResource.java:151)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:126)
at
com.openshift.internal.client.DomainResource.createApplication(DomainResource.java:112)
{code}
{code:title=DomainResource looks applications up, to see if the name is already used.
DomainResource#createApplication}
if (hasApplicationByName(name)) {
throw new OpenShiftException("Application with name \"{0}\" already
exists.", name);
}
{code}
{code:title=DomainResource#hasApplicationByName gets the available applications:}
return getApplicationByName(name) != null;
{code}
{code:title=DomainResource#getApplicationByName}
IApplication matchingApplication = null;
for (IApplication application : getApplications()) {
if (application.getName().equals(name)) {
matchingApplication = application;
break;
}
}
return matchingApplication;
{code}
{code:title=DomainResource#getApplications would load the applications from the backend
if they're not loaded yet}
if (this.applications == null) {
this.applications = loadApplications();
}
return CollectionUtils.toUnmodifiableCopy(applications);
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4389
days inactive
4389
days old
jbosstools-issues@lists.jboss.org
7 comments
1 participants
participants (1)
-
Andre Dietisheim (JIRA)