[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Max Andersen updated JBIDE-7346: -------------------------------- Attachment: smooksselection.mp4 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng updated JBIDE-7346: ---------------------------- Attachment: selectedfigures.jpg When select the Container figure , the border will turn to be Dot/Blue rectangle. When seelct the Label figure ( e.g, the attribute figure of Java bean figure) , just change the font color Please take a look the attach , give me the feedback -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng commented on JBIDE-7346: --------------------------------- base on common ui colors/selection mechanisms , when select the label figure , the backgourd color change to be blue and font color to be white , -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-7346: ------------------------------------------ Max & Dart... When you're talking about more clearly indicating what's "Selected"... What are you referring to? Are you referring to selecting an item in a model, the model itself, indicating the "linked" items in the model... There are a lot of ways to use the word "selected" - so I'm just trying to explicitly define what it is we're looking at... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Max Andersen commented on JBIDE-7346: ------------------------------------- I assume you meant to assign this to me and not John ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Max Andersen commented on JBIDE-7346: ------------------------------------- Dart, that is much easier to see for the label on the right; its also easy to see for the labels on the left - but here I assume it is the *whole* thing that is selected and not just the individual labels, right ? Then the *whole* thing should be having the selection outline. Brian, see the screencast - it shows how it was before (i.e. inconsistent and with various different colors). And it covers all the aspects of what can be selected in the graph. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-7346: ------------------------------------------ Ok, the dotted outline around boxes and for line edges is very consistent with other graphical editors (as Max showed with his screencast). The same with the box around editable text with a blinking cursor to allow editing when selected. I don't believe we have any editable text on the Smooks Java Mapping or Apply Template graph itself - but we should be able to more clearly identify the object selected and highlight the text for the object selected. And there are actually two graphs - the Task graph (Apply Template or Java Mapping) and the Processing graph (Input -> Java Mapping -> Apply Template). Both should operate the same. Perhaps a bigger dashed border would make it easier to see on the graph model than the dotted variety? But again, I think Max's point is that there should be multiple things selected when a particular object is selected. In the case of your second image - not only should the outer border be highlighted (by dots/dashes and/or color), but the text within should be highlighted - at the very least the title of the figure - XML Input Model. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-7346: ------------------------------------------ That looks better to me. Do you have a similar approach implemented in the Task graph as well? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng updated JBIDE-7346: ---------------------------- Attachment: .png -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick commented on JBIDE-7346: ------------------------------------------ Dart, can you merge the dotted line style along with the style with the bold lines and dot "handles" you showed in http://screencast.com/t/Oioiho3SY6Oj? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng commented on JBIDE-7346: --------------------------------- Brian , I think I can just apply your approach in the Zest viewer. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng commented on JBIDE-7346: --------------------------------- Brian , please take a look the new attach picture , is it you want? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng updated JBIDE-7346: ---------------------------- Attachment: zest_selected_feedback.jpg the connection can't be selected -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] DartPeng edited comment on JBIDE-7346 at 11/9/10 2:07 PM: ---------------------------------------------------------- http://screencast.com/t/cbNjRCmHS New flash demo was (Author: DartPeng): the connection can't be selected -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin.s... ] Brian Fitzpatrick updated JBIDE-7346: ------------------------------------- Fix Version/s: 3.2.0.CR1 (was: 3.2.0.Beta2) Priority: Major (was: Blocker) Great feedback Jiri. We'll see what we can do for Cr1 to get this finished up -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin... ] Brian Fitzpatrick updated JBIDE-7346: ------------------------------------- Fix Version/s: 3.3.x (was: 3.2.0.CR1) Leave this one alone for now and focus on the bigger issues. Bumping to 3.3.x -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-7346?page=com.atlassian.jira.plugin... ] Tom Fennelly updated JBIDE-7346: -------------------------------- Assignee: (was: Xue Peng) Forgot to unassign. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira