[
https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu...
]
Alexey Kazakov commented on JBIDE-3336:
---------------------------------------
> Alexey - by disabling this feature you mean the possibility the
user have today to disable the seam validator via the wtp validator or something else ?
I mean we could add new option in preferences to disable/enable revalidation of files with
unresolved ELs. If user disables it then we won't validate unchanged files with
unresolved EL.
> About making it clever then it sounds to me that if one file is
changed then to be not affect/annoy users too much (i.e. be efficient) we should keep
track of which declarations comes from this file and only revalidate the files that would
be affected by this - and not the whole project.
We already do it. We keep track of variable declaration and use. For example if user
changes some java source with @Name("comp") we will validate this source and all
files which use comp variable. But it works only for resources that already use resolved
variable. If we have some unresolved variable then we can't keep trace to non-existet
declaration. And we revalidate unresolved EL in case if user add demaned declaration in
changed file. See the example above.
We don't validate a resource if it doesn't use variable that was declared (before
changing) in changed resource and if it doesn't have unresolved EL.
> Other optimizations is to only look at .xml within webcontent
paths and java source paths (that might affect pure seam java projects, but then having an
default enabled option saying "only validate files on webcontent and java source
path" would be a solution to that.
It sounds resonable. Let's add new option to preferences: Only validate files on
webcontent (in case of WTP project) and java source path. I'll add this feature to
JIRA,
> That would also stop the original issue of seam validator
running because an ant build.xml file were saved. But again, why are we even running when
a build.xml file is being saved ? Can't we check the content type or something to
limit what files we react to ?
Now we don't check content type of components.xml but we could. So here is one more
feature request. Validate unresolver ELs only if changed file is java source or
components.xml. I'll add it to JIRA as well.
Seam validator is called too often
----------------------------------
Key: JBIDE-3336
URL:
https://jira.jboss.org/jira/browse/JBIDE-3336
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Seam
Affects Versions: 3.0.0.beta1
Environment: Windows XP, eclipse 3.4.1, wtp 3.0.3, jboss tools nightly build
N200812020037
Reporter: Adrian Mitev
Assignee: Alexey Kazakov
Fix For: 3.0.0.GA
The Seam validator is called even if i save a build.xml file and it scans all pages.
Quite heavy, i have over 50 pages.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira