[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3336: --------------------------------------- Seam EL validator should scan: 1. full-build: -all xml,java,jsp,xhtml. 2. incremental build: - changed files - if changed files declare (or used to declare before changing) some Seam context variable then we validate all files which use this variables. - all files with at least one unresolved EL. --- This rule could take a lot of time if we have a lot of files with at least one unresolved EL. So maybe it's better to disable this rule?.. If EL validation works in different way for you then please attach some sample project to reproduce the issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3336: --------------------------------------- Fix Version/s: 3.0.0.GA Assignee: Max Rydahl Andersen (was: Alexey Kazakov) ill try and reproduce to see if we got issue before GA -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3336: --------------------------------------- Fix Version/s: 3.0.0.GA (was: 3.0.0.CR2) slip - now with proper fix version -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Max Rydahl Andersen updated JBIDE-3336: --------------------------------------- Assignee: Alexey Kazakov (was: Max Rydahl Andersen) Alexey - could you take a look ? If not, then just assign back to me. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3336: --------------------------------------- Let me show some examples. For instance we have components.xml: ... <component name="itemmm" class="....."/> ... and page.xhtml: ... <h:outputText value="#{item.name}"/> ... And Seam validator can't resolve #{item.name}. When you save any file (xml, java, xhtml, jsp, properties) then page.xhtml will be validated (may be changed file declares unresolved #{item} now?) In our example it makes sence to revalidate page.xhtml if we changed components.xml: <component name="item" class="....."/> So #{item} is valid EL now and we remove an error marker from page.xhtml. Of course if there is a lot of files with at least one unresolved EL then Seam validator could do a lot of work even if you change only one file. What we can do here: 1. Disable this feature (add new preference or just remove it from code) 2. Try to make it clever. For example revalidate unresolved EL only if we change *.java or components.xml. Where else we can declare Seam context variable? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3336: --------------------------------------- I mean we could add new option in preferences to disable/enable revalidation of files with unresolved ELs. If user disables it then we won't validate unchanged files with unresolved EL. We already do it. We keep track of variable declaration and use. For example if user changes some java source with @Name("comp") we will validate this source and all files which use comp variable. But it works only for resources that already use resolved variable. If we have some unresolved variable then we can't keep trace to non-existet declaration. And we revalidate unresolved EL in case if user add demaned declaration in changed file. See the example above. We don't validate a resource if it doesn't use variable that was declared (before changing) in changed resource and if it doesn't have unresolved EL. It sounds resonable. Let's add new option to preferences: Only validate files on webcontent (in case of WTP project) and java source path. I'll add this feature to JIRA, Now we don't check content type of components.xml but we could. So here is one more feature request. Validate unresolver ELs only if changed file is java source or components.xml. I'll add it to JIRA as well. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3336: --------------------------------------- I've fixed https://jira.jboss.org/jira/browse/JBIDE-3822 and https://jira.jboss.org/jira/browse/JBIDE-3823 If it is enough so far then we can resolve the issue. I don't know what we can do more here. Any ideas? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Adrian Mitev commented on JBIDE-3336: ------------------------------------- Sure. I'll report the result here. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Adrian Mitev commented on JBIDE-3336: ------------------------------------- Works a lot better now :) Thank you guys! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBIDE-3336?page=com.atlassian.jira.plu... ] Alexey Kazakov resolved JBIDE-3336. ----------------------------------- Resolution: Done Ok. Let's resolve this issue then. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira