[ https://issues.jboss.org/browse/JBIDE-9448?page=com.atlassian.jira.plugin... ] Alexey Kazakov commented on JBIDE-9448: --------------------------------------- We definitely should create JUnit tests to cover this functionality. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9448?page=com.atlassian.jira.plugin... ] Victor Rubezhny edited comment on JBIDE-9448 at 8/5/11 11:27 AM: ----------------------------------------------------------------- I found what the real problem is. The issue is caused by fixing JBIDE-8350 which caused regression. While fixing JBIDE-8350 the ChainedTextHover, created in lines 207-208 of org.jboss.tools.jst.jsp.HTMLTextViewerConfiguration.getTextHover(ISourceViewer, String, int) method, was replaced by MarkerProblemAnnotationHoverProcessor. Probably this solved JBIDE-8350, but at the same time this completely killed all other possible hovers to display their information. was (Author: vrubezhny): The reason why tooltips don't work is the change of default value for Window->Preferences->General->Editors->Structured Text Editor->Hovers(Tab) preference. For now, there is a table of available hovers and their enable/disable statuses as well as modifiers for the hover invocation. And now the Documentation Description Hovers are disabled (A Combined Hover is enabled instead of the Documentation Description hover) It seems that this preference is a new one or was not taken into account earlier or just the default is to reconfigured to disable the Document Description hovers. We are using our own "combined"-like ChainTextHover to deal with multiple hovers defined for the same partition type but this works if the Documentation Description Hovers are enabled. Also, our ChainTextHover is used to acquire JBoss Tools hovers first in the hovers chain. Replacing the Document Description hover by Combined Hover by default currently disabled all the hovers on HTML/JSP/XML and other source editors causing this issue. Probably the kosher way is to learn on what the Combined Hover is and how we can use it, but the simplest and shortest way is to add a code that restores an Old defaults for this preference. When doing this manually (enabling the Documentation Description Hover) I faced another problems: (1) the Hover Control which currently is not available to show HTML text for the hover. This probably also is changed (but I didn't discovered a reason yet). (2) Our ChainTextHover is not used after the preference value change (the 2-line-fix prevents this problem) What shall we do with this? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9448?page=com.atlassian.jira.plugin... ] Victor Rubezhny edited comment on JBIDE-9448 at 8/5/11 11:33 AM: ----------------------------------------------------------------- I found what the real problem is. The issue is caused by fixing JBIDE-8350 which caused regression. While fixing JBIDE-8350 the ChainedTextHover, created in lines 207-208 of org.jboss.tools.jst.jsp.HTMLTextViewerConfiguration.getTextHover(ISourceViewer, String, int) method (Rev. 24607), was replaced by MarkerProblemAnnotationHoverProcessor (Rev. 29368). Probably this solved JBIDE-8350, but at the same time this completely killed all other possible hovers to display their information. The same thing happened with org.jboss.tools.jst.jsp.JSPTextViewerConfiguration.getTextHover(ISourceViewer, String, int) method - ChainTextHover was replaced by MarkerProblemAnnotationHoverProcessor - causing the same kind of regression. was (Author: vrubezhny): I found what the real problem is. The issue is caused by fixing JBIDE-8350 which caused regression. While fixing JBIDE-8350 the ChainedTextHover, created in lines 207-208 of org.jboss.tools.jst.jsp.HTMLTextViewerConfiguration.getTextHover(ISourceViewer, String, int) method (Rev. 24607), was replaced by MarkerProblemAnnotationHoverProcessor (Rev. 29368). Probably this solved JBIDE-8350, but at the same time this completely killed all other possible hovers to display their information. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9448?page=com.atlassian.jira.plugin... ] Daniel Azarov commented on JBIDE-9448: -------------------------------------- verified for xml, xhtml and jsp - all fine -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9448?page=com.atlassian.jira.plugin... ] Alexey Kazakov updated JBIDE-9448: ---------------------------------- Fix Version/s: 3.3.0.M4 (was: 3.3.0.M3) Priority: Major (was: Critical) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-9448?page=com.atlassian.jira.plugin... ] Alexey Kazakov resolved JBIDE-9448. ----------------------------------- Assignee: Victor Rubezhny (was: Alexey Kazakov) Resolution: Done fixed -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira