2:33 p.m.
Andre Dietisheim created JBIDE-10676:
----------------------------------------
Summary: OpenShift java client assumes that the app is available when it gets
404
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 p.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim updated JBIDE-10676:
-------------------------------------
Description:
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
was:
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:43 p.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-10676:
------------------------------------------
the approach seems to have changed over time, and we did not notice it so far. The check
is done (in the rhc-tools) on a health_check_url (we are currently checking on the
application web url)
https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-... :
{code}
url = URI.parse("http://#{fqdn}/#{health_check_path}")
{code}
This url is specific to each application type and is reported at creation time, when the
response when the application is created:
https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-... :
{code}
health_check_path = json_data['health_check_path']
{code}
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 p.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim edited comment on JBIDE-10676 at 1/24/12 5:35 PM:
-------------------------------------------------------------------
the approach seems to have changed over time, and we did not notice it so far. The only
reliable way to check the application for it's availability on it's
health_check_url (we are currently checking on the application web url).
https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-... :
{code}
url = URI.parse("http://#{fqdn}/#{health_check_path}")
{code}
This url is specific to each application type and is reported at creation time, in the
response when the application is created:
https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-... :
{code}
health_check_path = json_data['health_check_path']
{code}
There's no reliable way to query the application availability later on. You may only
do it when the app is being created.
was (Author: adietish):
the approach seems to have changed over time, and we did not notice it so far. The
check is done (in the rhc-tools) on a health_check_url (we are currently checking on the
application web url)
https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-... :
{code}
url = URI.parse("http://#{fqdn}/#{health_check_path}")
{code}
This url is specific to each application type and is reported at creation time, when the
response when the application is created:
https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-... :
{code}
health_check_path = json_data['health_check_path']
{code}
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:38 p.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-10676:
------------------------------------------
The bad part for us is that there's no way to query the app for its availability once
it is created. We are currently offering IApplication#waitForAccessible which is not
possible if the application object is created from application infos (which we get by
querying the user info).
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:37 a.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-10676:
------------------------------------------
I work around the abovementioned limitation by not waiting if no health url is present in
IApplication. This should pretty much work since the application only has a health check
url when its being created and therefore may not be ready yet. If an IApplication is
created from application infos (you query the list of your existing applications -> the
applications are created from application infos - which you get from user info) you have
no health check url available. But since you are looking at an application that was
created far earlier, it for sure is accessible.
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:37 a.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim edited comment on JBIDE-10676 at 1/25/12 10:36 AM:
--------------------------------------------------------------------
I work around the abovementioned limitation by only waiting if a health url is present in
IApplication. This should pretty much work since the application only has a health check
url when its being created and therefore may not be ready yet. If an IApplication is
created from application infos (you query the list of your existing applications -> the
applications are created from application infos - which you get from user info) you have
no health check url available. But since you are looking at an application that was
created far earlier, it for sure is accessible.
was (Author: adietish):
I work around the abovementioned limitation by not waiting if no health url is present
in IApplication. This should pretty much work since the application only has a health
check url when its being created and therefore may not be ready yet. If an IApplication is
created from application infos (you query the list of your existing applications -> the
applications are created from application infos - which you get from user info) you have
no health check url available. But since you are looking at an application that was
created far earlier, it for sure is accessible.
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:17 a.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-10676:
------------------------------------------
The current implementation of IOpenShiftService#waitForApplication now pretty much matches
the ruby counterpart:
{code}
try {
IHttpClient client = createHttpClient(id, healthCheckUrl, false);
String response = null;
long startTime = System.currentTimeMillis();
while (!HEALTH_RESPONSE_OK.equals(response)
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (HttpClientException e) {
// not available yet
}
}
return HEALTH_RESPONSE_OK.equals(response);
} catch (InterruptedException e) {
return false;
} catch (MalformedURLException e) {
throw new OpenShiftException(e, MALFORMED_URL_EXCEPTION_MSG, healthCheckUrl);
}
{code}
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 p.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-10676:
------------------------------------------
built a new client jar and added it to our client bundle. committed to TRUNK (Beta1)
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 p.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Andre Dietisheim resolved JBIDE-10676.
--------------------------------------
Resolution: Done
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:39 a.m.
[
https://issues.jboss.org/browse/JBIDE-10676?page=com.atlassian.jira.plugi...
]
Stefan Bunciak closed JBIDE-10676.
----------------------------------
Verified. Test case 'canWaitForApplication' succesfull.
OpenShift java client assumes that the app is available when it gets
404
------------------------------------------------------------------------
Key: JBIDE-10676
URL: https://issues.jboss.org/browse/JBIDE-10676
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: openshift
Affects Versions: 3.3.0.M5
Reporter: Andre Dietisheim
Assignee: Andre Dietisheim
Fix For: 3.3.0.Beta1
The java client currently assumes that the app has become available as soon as it gets
accessible by its DNS-name.
OpenShiftService#waitForApplication:
{code}
while (response == null
&& System.currentTimeMillis() < startTime + timeout) {
try {
Thread.sleep(APPLICATION_WAIT_DELAY);
response = client.get();
} catch (InternalServerErrorException e) {
return true;
} catch (BadRequestException e) {
return true;
} catch (NotFoundException e) {
return true;
} catch (HttpClientException e) {
// not available yet
}
}
{code}
Talking to the guys on libra I found out that it's not. The rhc-tools also consider
the response code
(https://github.com/openshift/os-client-tools/blob/master/express/lib/rhc-...):
{code}
begin
response = net_http.get_response(url)
rescue Exception => e
response = nil
end
if !response.nil? && response.code == "200" &&
response.body[0,1] == "1"
puts CLEAR_LINE + "Confirming application '#{app_name}' is
available: Success!"
puts ""
puts "#{app_name} published: http://#{fqdn}/"
puts "git url: #{git_url}"
if @mydebug
unless no_git
puts "To make changes to '#{app_name}', commit to
#{repo_dir}/."
else
puts <<LOOKSGOOD
To make changes to '#{app_name}', you must first clone it with:
git clone #{git_url}
LOOKSGOOD
puts "Then run 'git push' to update your OpenShift Express
space."
end
end
if result && !result.empty?
puts "#{result}"
end
return true
end
if !response.nil? && @mydebug
puts "Server responded with #{response.code}"
puts response.body unless response.code == '503'
end
puts " sleeping #{sleep_time} seconds" if @mydebug
sleep sleep_time
sleep_time = delay(sleep_time)
end
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4584
days inactive
4645
days old
jbosstools-issues@lists.jboss.org
10 comments
2 participants
participants (2)
-
Andre Dietisheim (JIRA) -
Stefan Bunciak (JIRA)