[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich updated JBIDE-10565: ------------------------------------------ Description: EXECUTE: Type #{ in attribute value or in text node in xml. EXECUTE: Set cursor inside that token #|{ and invoke content assist. FAILURE: JBoss Tools provide all names available for EL (CDI named beans, Seam components, JSF managed beans and resource bundles, etc.). FAILUTE: If a proposal 'abc' is selected for insertion, it is inserted in this way: #abc}{. ASSERT: JBoss Tools provides nothing for that position. was: EXECUTE: Type #{ in attribute value or in text node in xml. EXECUTE: Set cursor inside that token #|{ and invoke content assist. FAILURE: JBoss Tools provide all names available for EL (CDI named beans, Seam components, JSF managed beans and resource bundles, etc.) FAILUTE: If a proposal 'abc' is selected for insertion, it is inserted in this way: #abc}{ ASSERT: JBoss Tools provides nothing for that position. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Victor Rubezhny resolved JBIDE-10565. ------------------------------------- Assignee: Viacheslav Kabanovich (was: Victor Rubezhny) Resolution: Done Fixed. Verified on 3.3.0.beta1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-10565: ---------------------------------------- Vlado, CA for #{ #{user. #{Message. should work. And it's working for me. If you can reprodcue some issues with CA please create a new issue. This issue is only about #|{ case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-10565: ----------------------------------------------- It is exactly what this issue states. There should be no content assist for the cursor position between symbols # and {. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Viacheslav Kabanovich commented on JBIDE-10565: ----------------------------------------------- Vlado, I think I see what you mean. Content assist usually does not parse forward from the cursor position, that is proposals for '#|{' or '#|{Message.' or '#|{user.' are the same - in this case empty. Taking into account one symbol to the right '{' is an exclusion that is the matter of this issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Vlado Pakan commented on JBIDE-10565: ------------------------------------- In Jira description is mentioned xml file as type of file when there should be no Code Assist for #|{. I though that .jsp file is another type of file and it could make sense to have Code Assist with available EL variables. Because right now when user has cursor in this position #|{ and want to use Code Assist he has to move cursor one character to the right and he will have Code Assist available. So for me it make sense to have the same code assist for #|{ as for #{. If you say it's not correct I will accept it. So how you decide? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Vlado Pakan commented on JBIDE-10565: ------------------------------------- I think #|{ Code Assist should offer the same as #{| Code Assist -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Victor Rubezhny edited comment on JBIDE-10565 at 1/11/12 11:08 AM: ------------------------------------------------------------------- I see no difference between xml and jsp for the issue. And I see no reason in displaying EL name proposals when user invokes CA from text position like #|{... The '#'-char is nor EL-starting character, so, IMHO, we shouldn't display EL-proposals here. The only one relevant proposal here is "#{" (insert new EL, which propose to insert #{} into a text), because (if we're in position like #|{) the text cursor is not in EL. However, "New JSF EL expression...." proposal is not shown for some reason when CA is manually invoked when text cursor is placed in position like '#|{' (may be it's a bug (?)) Making the CA to provide EL name proposals for the positions like #|{ is possible but requires us to make more sophisticated processing for EL- open&close sequences ("#{" and "}") as well as inserting the additional characters which are not EL-name characters (I mean curly brace "{" into the current cursor position, which in its turn must be right after "#"-char) which aren't trivial. Once again, IMHO: '#'-character is NOT EL starting sequence, so no EL-proposals should be provided if CA is invoked right after this char. was (Author: vrubezhny): I see no difference between xml and jsp for the issue. And I see no reason in displaying EL name proposals when user invokes CA from text position like #|{... The '#'-char is nor EL-starting character, so, IMHO, we shouldn't display EL-proposals here. The only one relevant proposal here is "#{" (insert new EL, which propose to insert #{} into a text), because (if we're in position like #|{) the text cursor is not in EL. However, "New JSF EL expression...." proposal is not shown for some reason when CA is manually invoked when text cursor is placed in position like '#|{' (may be it's a bug (?)) Making the CA to provide EL name proposals for the positions like #|{ is possible but requires us to make more sophisticated processing for EL- open&close sequences ("#{" and "}") as well as inserting the additional characters which are not EL-name characters (I mean curly brace "{" into the current cursor position, which in its turn must be right after "#"-char) which aren't trivial (). Once again, IMHO: '#'-character is NOT EL starting sequence, so no EL-proposals should be provided if CA is invoked right after this char. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Alexey Kazakov commented on JBIDE-10565: ---------------------------------------- Slava, yes excatly. So I'm not sure that #|{xyz -> #{name}{xyz is useful at all. If Victor thinks that it requires "a big" refactoring of our code then probably we just leave it as it is now. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-10565?page=com.atlassian.jira.plugi... ] Vlado Pakan closed JBIDE-10565. ------------------------------- Verified on JBT 2012-01-14_13-11-27-H4140. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira