]
Nick Boldt updated JBIDE-24671:
-------------------------------
Fix Version/s: 4.5.1.AM1
[jbosstools-openshift] Block PRs for merge untill the Jenkins build
is successful
---------------------------------------------------------------------------------
Key: JBIDE-24671
URL:
https://issues.jboss.org/browse/JBIDE-24671
Project: Tools (JBoss Tools)
Issue Type: Sub-task
Components: openshift
Affects Versions: 4.5.1.AM1
Reporter: Nick Boldt
Assignee: Nick Boldt
Fix For: 4.5.1.AM1
Nick asked:
{quote}
if we implement protected branches in github then no PRs can be merged w/o a PR review
so for projects like Base or Server, this would slow Rob down as he'd be even more
dependent on PR reviews
for Openshift this would force Andre to break his PRs into smaller pieces so they could
be more easily/quickly reviewed
otherwise all forward dev would be halted
so it's good from a "keep the code safe and clean" perspective
but if we don't actually get buy-in / acceptance from the people who submit the PRs
and review them, it will block progress{quote}
Jeff replied:
{quote}I think this make more sense for OpenShift as we are more in a collaborative way,
I have the feeling that Rob is more or less alone in server. So let's start with
OpenShift but I would see this after the GA{quote}