[JBoss JIRA] Created: (JBIDE-3818) ConcurrentModificationException in seam validator

[JBoss JIRA] Created: (JBIDE-1288)...

[JBoss JIRA] Created: (JBDS-552)...

Denis Golovin (JIRA)

Tuesday, 17 February 2009 Tue, 17 Feb '09

6:21 a.m.

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Alexey Kazakov Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Alexey Kazakov (JIRA)

Tuesday, 17 February Tue, 17 Feb

9:57 p.m.

New subject: [JBoss JIRA] Assigned: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Alexey Kazakov reassigned JBIDE-3818: ------------------------------------- Assignee: Viacheslav Kabanovich (was: Alexey Kazakov) We can't fix this issue without modification of Seam Tools model. What we can do: - add new methods to SeamProject like getComponents(boolean createNewCopy); This method should return new copy of collection. The coping should be thread-safe too. - use ConcurrentLinkedQueue instead of HashSet in SeamProject. It will allow clients to work with thread-safe collection of Seam artifacts. We have to figure out if it is fast enough. - return Collections.synchronizedSet() in getComponents(). Then every client code should use sinchronize block when we need to iterate Seam artifacts. Could be slow. Not sure it is the best solution. Also we can use CopyOnWriteArraySet in SeamProject but it would be too slow. I don't think we should use it. Any ideas?

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Denis Golovin (JIRA)

Wednesday, 18 February Wed, 18 Feb

1:28 a.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Denis Golovin commented on JBIDE-3818: -------------------------------------- How can that happen? Seam model and validation are in separate processes that are executed with the same schedule rule which means they should follow each other, right? Validation should start when seam model is built, validation job should lock certain resources in workspace until it is finished, it is guarantee that if someone tries to modify resource affected by validation, it is locked until validation is finished. Now it looks like something tries to modify seam model during validation, that means validation could use incomplete model and cannot guarantee right results. Looking through code I can guess that getComponents() method is called only by clients and returned set isn't supposed for modification, that means it can return unmodified collection. It worth to do, but it will not help because something modifies wrapped set.

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Denis Golovin (JIRA)

1:37 a.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Alexey Kazakov (JIRA)

1:39 a.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3818: ---------------------------------------

...

> Seam model and validation are in separate processes that are executed with the same schedule rule which means they should follow each other, right?

Seam validator for some project could be started by wst builder of another project.

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Max Rydahl Andersen (JIRA)

9:50 a.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3818: -------------------------------------------- Isn't this the same problem we have received multiple reports about over time ? These were fixed, right ? so what has changed ?

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Max Rydahl Andersen (JIRA)

9:52 a.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Max Rydahl Andersen commented on JBIDE-3818: -------------------------------------------- btw. relying on schedule job and preventing updates to seam model while validator runs sounds like a bad thing - since the validators tend to run for a long time users wouldn't be able to do much else than wait for the validators to stop would they ?

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Viacheslav Kabanovich (JIRA)

12:26 p.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich commented on JBIDE-3818: ---------------------------------------------- I vote for making a copy of components collection. Iteration in SeamCoreValidator.validateAll takes a lot of time, about 1 minute per 1000 components, and for that time model is expected to be locked. Making a copy is 1000 times faster. If model is going to be modified during validation of that copy, another validator job will be queued, and in the end actual set of components will be validated.

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Alexey Kazakov (JIRA)

12:28 p.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Alexey Kazakov commented on JBIDE-3818: --------------------------------------- I don't like locking resources during seam validation either. It could take a long time. It seems to be a problem only when we have a few builder processes for a few projects. And we try to validate a project that is being built by his own builder. We already have tried to fix this problem. The fix doesn't work actally.

...

> Isn't this the same problem we have received multiple reports about over time ?

There were a few ConcurrentModificationExceptions in different part of Seam Tools. We fixed some of them. So now we should fix this one too. This issue seems to be a very old one. It is not reproducible all the time. I think all collections that Seam model return should be thread-safe. Even if one validate process (from first project) will have incomplete model then next validaton process (that will start after second project is buit) will have full model and revalidate resources. So I don't think that incomplete model could be a problem in that case.

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Denis Golovin (JIRA)

10:18 p.m.

New subject: [JBoss JIRA] Commented: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Denis Golovin commented on JBIDE-3818: -------------------------------------- To Max: I agree that looking resources during validation isn't good idea. To Alex: Making them thread-safe wouldn't solve the problem, it basically the same as locking resources during validation, but time intervals would be shorter.

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Viacheslav Kabanovich (JIRA)

Thursday, 19 February Thu, 19 Feb

2:26 p.m.

New subject: [JBoss JIRA] Resolved: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Viacheslav Kabanovich resolved JBIDE-3818. ------------------------------------------ Resolution: Done We had the same problem with collection of variables, which was solved by making copy. Now I used the same approach for components and factories

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Anton Klimkovich (JIRA)

Thursday, 26 February Thu, 26 Feb

6:44 p.m.

New subject: [JBoss JIRA] Closed: (JBIDE-3818) ConcurrentModificationException in seam validator

[ https://jira.jboss.org/jira/browse/JBIDE-3818?page=com.atlassian.jira.plu... ] Anton Klimkovich closed JBIDE-3818. ----------------------------------- Verified on 3.0.0.GA-N200902260002-H1459

...

ConcurrentModificationException in seam validator ------------------------------------------------- Key: JBIDE-3818 URL: https://jira.jboss.org/jira/browse/JBIDE-3818 Project: Tools (JBoss Tools) Issue Type: Bug Components: Seam Affects Versions: 3.0.0.GA Reporter: Denis Golovin Assignee: Viacheslav Kabanovich Priority: Critical Fix For: 3.0.0.GA java.util.ConcurrentModificationException [java] at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793) [java] at java.util.HashMap$KeyIterator.next(HashMap.java:828) [java] at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010) [java] at org.jboss.tools.seam.internal.core.validation.SeamCoreValidator.validateAll(SeamCoreValidator.java:198) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateAll(SeamValidatorManager.java:88) [java] at org.jboss.tools.seam.internal.core.validation.SeamValidatorManager.validateInJob(SeamValidatorManager.java:68) [java] at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78) [java] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

5602

days inactive

5611

days old

jbosstools-issues@lists.jboss.org

Manage subscription

11 comments

5 participants

tags (0)

participants (5)

Alexey Kazakov (JIRA)
Anton Klimkovich (JIRA)
Denis Golovin (JIRA)
Max Rydahl Andersen (JIRA)
Viacheslav Kabanovich (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[JBoss JIRA] Created: (JBIDE-3818) ConcurrentModificationException in seam validator