[
https://issues.jboss.org/browse/JBIDE-26283?page=com.atlassian.jira.plugi...
]
Andre Dietisheim commented on JBIDE-26283:
------------------------------------------
[~nickboldt]: referring to your
[
findings|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=136...]
I ack that eclipse source references are ignored and thus shouldn't trigger a baseline
comparison failure (as found out by [~jeffmaury] in his
[
comment|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=1361...]:
https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src...
{code}
// this is common attribute not supported by Tycho yet
ignoredKeys.add(new Name("Eclipse-SourceReferences"));
{code}
The other change in comments shouldn't trigger a failure in baseline comparison.
Comparison is done based on keys and values, where comments should be ignored:
https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src...
So I still dont get why the baseline checks fails. Thoughts?
Baseline and reactor have same fully qualified version, but with
different content in jbosstools-base plugins/features
----------------------------------------------------------------------------------------------------------------------
Key: JBIDE-26283
URL:
https://issues.jboss.org/browse/JBIDE-26283
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: build
Affects Versions: 4.9.0.AM1
Reporter: Josef Kopriva
Assignee: Nick Boldt
Priority: Blocker
Fix For: 4.9.0.AM2
Attachments: diff-baseline-with-local-build-commented-timestamps.png,
diff-baseline-with-local-build-sourcereferences-cause-problem.png
Job
https://dev-platform-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/Devstud...
is red for one week.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)