[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11264: --------------------------------------------- Lucia, there must be some other difference than just the path changing. When you Import the application in step 6 and 7 - what do you do exactly ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Lucia Jelinkova commented on JBIDE-11264: ----------------------------------------- @Max Yes, the change of the location is the only thing I do. I've added screencast. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11264: --------------------------------------------- so you are putting the project *inside* the workspace - what happens if you do it outside ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-11264: ---------------------------------------- Summary: Wrong workspace project name when the OpenShift app name != artifact id in pom file and the project location is within the workspace (was: Wrong workspace project name when the OpenShift app name != artifact id in pom file and the project location is not default) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Lucia Jelinkova updated JBIDE-11264: ------------------------------------ Description: When I have an existing OpenShift application with name different that the artifact id in pom file and I want to import it into Eclipse workspace, I get different Eclipse project names depending on the chosen location of the newly created workspace file. # when selected default value (/home/xxx/git) the project's name is the one from pom file # when selected the workspace location the project's name is the OpenShift application name was: When I have an existing OpenShift application with name different that the artifact id in pom file and I want to import it into Eclipse workspace, I get different Eclipse project names depending on the chosen location of the newly created workspace file. # when selected default value (/home/xxx/git) the project's name is the one from pom file # when selected any other value the project's name is the OpenShift application name Steps to Reproduce: 1.) Create new OpenShift application 2.) Import the application 3.) Change the artifact id in pom.xml 4.) Push the changes 5.) Delete the workspace project (also from the disc) 6.) Import the application and leave the project's location default (/home/xxx/git) RESULT: the created workspace project has the name from pom file 7.) Import the application and choose the location of your workspace RESULT: the created workspace project has the name of OpenShift applciation was: 1.) Create new OpenShift application 2.) Import the application 3.) Change the artifact id in pom.xml 4.) Push the changes 5.) Delete the workspace project (also from the disc) 6.) Import the application and leave the project's location default (/home/xxx/git) RESULT: the created workspace project has the name from pom file 7.) Import the application and choose any other location than default RESULT: the created workspace project has the name of OpenShift applciation -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-11264 at 3/12/12 10:37 AM: -------------------------------------------------------------------- in my screencast (untitled.mp4) I clone to /tmp/ which is clearly not in the workspace. The error does not appear in this setup. When trying with your approach, where I clone to the workspace, I could reproduce your bug. Having a repo in the workspace root is clearly not recommended. But still, this has to be a "bug" in the maven import process which is not in my control. was (Author: adietish): in my screencast I clone to /tmp/ which is clearly not in the workspace. The error does not appear in this setup. When trying with your approach, where I clone to the workspace, I could reproduce your bug. Having a repo in the workspace root is clearly not recommended. But still, this has to be a "bug" in the maven import process which is not in my control. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-11264: ------------------------------------------ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11264: --------------------------------------------- Nope, I do not agree :) Have you verified that a basic maven import when done outside our wizard/code behaves the same ? i.e. import a project within a workspace manually repeats the same problem ? if it works fine manually then something is wrong in our import code and we should fix it. if it does not work and thus it is an m2eclipse problem then: A) fbricon is a committer on m2eclipse so we do influence this. B) if A can't be done in time then adding a warning or maybe even error validation about output being inside workspace would be fitting since i'm sure others will attempt this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-11264 at 3/13/12 4:43 AM: ------------------------------------------------------------------- ok, good catch. I tried to reproduce it manually and was perfectly able to: 1.) ASSERT: have a git repo that holds a maven project in a single subdir - no nested subdirs (ex. <git repo>/*a-project*/.git, pom.xml etc.) 2.) EXEC: change the artifact id in the pom.xml (ex. *a-project-changed*) 3.) EXEC; clone the git repo into your workspace (ex. <your home>/runtime-workspace/*a-project*) 4.) EXEC: File->Import->Maven->Existing Maven Projects 5.) EXEC: The maven import will detect your project and display */a-project/pom.xml*. Pick it and finish the wizard. Results: The maven import will import a new project to your workspace, the project will hold the name of the directory it is in, not the artifact-id (ex. *a-project* and *NOT a-project-changed*) was (Author: adietish): ok, good catch. I tried to reproduce it manually and was perfectly able to: 1.) ASSERT: have a git repo that holds a maven project in a single subdir - no nested subdirs (ex. <git repo>/*a-project*/.git, pom.xml etc.) 2.) EXEC: change the artifact id in the pom.xml (ex. *a-project-changed*) 3.) EXEC; clone the git repo into your workspace (ex. <your home>/runtime-workspace/*a-project*) 4.) EXEC: File->Import->Maven->Existing Maven Projects 5.) EXEC: The maven import will detect your project and display */a-project/pom.xml*. Pick it and finish the wizard. Results: The maven import will import a new project to your workspace, the project will hold the name of the directory it is in, not the artifact-id (ex. *a-project* and NOT *a-project-changed*) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-11264 at 3/13/12 5:06 AM: ------------------------------------------------------------------- ok, good catch. I tried to reproduce it manually and was perfectly able to: 1.) ASSERT: have a git repo that holds a maven project in a single subdir - no nested subdirs (ex. <git repo>/*a-project*/.git, pom.xml etc.). Make sure the project has NO .project. 2.) EXEC: change the artifact id in the pom.xml (ex. *a-project-changed*) 3.) EXEC; clone the git repo into your workspace (ex. <your home>/runtime-workspace/*a-project*) 4.) EXEC: File->Import->Maven->Existing Maven Projects 5.) EXEC: The maven import will detect your project and display /*a-project*/pom.xml. Pick it and finish the wizard. Results: The maven import will import a new project to your workspace, the project will hold the name of the directory it is in, not the artifact-id (ex. *a-project* and *NOT a-project-changed*) was (Author: adietish): ok, good catch. I tried to reproduce it manually and was perfectly able to: 1.) ASSERT: have a git repo that holds a maven project in a single subdir - no nested subdirs (ex. <git repo>/*a-project*/.git, pom.xml etc.) 2.) EXEC: change the artifact id in the pom.xml (ex. *a-project-changed*) 3.) EXEC; clone the git repo into your workspace (ex. <your home>/runtime-workspace/*a-project*) 4.) EXEC: File->Import->Maven->Existing Maven Projects 5.) EXEC: The maven import will detect your project and display /*a-project*/pom.xml. Pick it and finish the wizard. Results: The maven import will import a new project to your workspace, the project will hold the name of the directory it is in, not the artifact-id (ex. *a-project* and *NOT a-project-changed*) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-11264: ---------------------------------------- Summary: When project is inside eclipse workspace Maven import gets the application name wrong (was: Wrong workspace project name when the OpenShift app name != artifact id in pom file and the project location is within the workspace) Fix Version/s: 3.3.x (was: 3.3.0.Beta3) Priority: Major (was: Critical) Assignee: Fred Bricon (was: Max Rydahl Andersen) Component/s: UpStream Not for beta3 since the issue is upstream. Not critical since it only happens if your project is within the workspace which is bad practice anyway :) Moved to 3.3.x for investigation by Fred for fix in m2e core. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11264?page=com.atlassian.jira.plugi... ] Fred Bricon resolved JBIDE-11264. --------------------------------- Resolution: Won't Fix Closing as won't fix, as this is a limitation of Eclipse IDE. When creating a project in the workspace, the project name *must* match the folder name. This is briefly mentioned on the [m2e FAQ|http://wiki.eclipse.org/M2E_FAQ#Why_projects_are_renamed_on_import] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira