3:16 a.m.
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Maxim Areshkau
Fix For: 3.1.0.M1
testTemplate.xhtml
<code> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml
</code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
<code>
</code>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Sergey Dzmitrovich updated JBIDE-4311:
--------------------------------------
Description:
testTemplate.xhtml :
<code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
</code>
testPage.xhtml :
<code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
</code>
was:
testTemplate.xhtml
<code> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml
</code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
<code>
</code>
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Maxim Areshkau
Fix For: 3.1.0.M1
testTemplate.xhtml :
<code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
</code>
testPage.xhtml :
<code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
</code>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:18 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Sergey Dzmitrovich updated JBIDE-4311:
--------------------------------------
Description:
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
was:
testTemplate.xhtml :
<code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
</code>
testPage.xhtml :
<code>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
</code>
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Maxim Areshkau
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:22 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Sergey Dzmitrovich updated JBIDE-4311:
--------------------------------------
JBoss Forum Reference:
http://www.jboss.org/index.html?module=bb&op=viewtopic&t=155320
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Maxim Areshkau
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 a.m.
New subject: [JBoss JIRA] Updated: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Maxim Areshkau updated JBIDE-4311:
----------------------------------
Component/s: Visual Page Editor core
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Maxim Areshkau
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [JBoss JIRA] Assigned: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Denis Maliarevich reassigned JBIDE-4311:
----------------------------------------
Assignee: Denis Maliarevich (was: Maxim Areshkau)
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Denis Maliarevich
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:46 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Denis Maliarevich commented on JBIDE-4311:
------------------------------------------
After debugging I've found out that there was an exception while parsing
<ui:param> inside <ui:composition>:
java.lang.NullPointerException
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.replacePattern(VpeDefineContainerTemplate.java:133)
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.updateNodeValue(VpeDefineContainerTemplate.java:190)
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.insertParam(VpeDefineContainerTemplate.java:220)
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.insertParam(VpeDefineContainerTemplate.java:230)
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.insertParam(VpeDefineContainerTemplate.java:230)
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.insertParam(VpeDefineContainerTemplate.java:230)
at
org.jboss.tools.vpe.editor.template.VpeDefineContainerTemplate.validate(VpeDefineContainerTemplate.java:261)
at
org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:582)
at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:273)
at
org.jboss.tools.vpe.editor.VpeVisualDomBuilder.updateElement(VpeVisualDomBuilder.java:1034)
at
org.jboss.tools.vpe.editor.VpeVisualDomBuilder.updateNode(VpeVisualDomBuilder.java:964)
at
org.jboss.tools.vpe.editor.VpeController.notifyChangedInUiThread(VpeController.java:631)
at org.jboss.tools.vpe.editor.VpeController$1.runInUIThread(VpeController.java:482)
at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3855)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3476)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)
While getting <ui:params>'s "name" attribute null value was retrieved.
The attribute was getting throug uppercase attribute name. But after changing to lowercase
name attribute value was retrieved fine. So it seems that in new eclipse
org.w3c.dom.Element.getAttribute(name) is case sensitive.
W3C has following rules and recomendations:
HTML tags are not case sensitive. World Wide Web Consortium (W3C) recommends lowercase in
HTML 4, and demands lowercase tags in future versions of (X)HTML.
World Wide Web Consortium (W3C) recommends lowercase attributes/attribute values in their
HTML 4 recommendation. Newer versions of (X)HTML will demand lowercase attributes.
So as a solution I'll change all our tags/attributes/attributes values into lowercase.
I'll add additional null pointer check to ui:param processing also.
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Denis Maliarevich
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:23 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Max Rydahl Andersen commented on JBIDE-4311:
--------------------------------------------
Are you sure this is change in behavior in Eclipse ? If yes, then that would have a biig
impact on adopters and should be noted in their migration notes.
And even with this change, there still should be a null check since it is not sure at all
that name will resolve to anything.
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Denis Maliarevich
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:49 p.m.
New subject: [JBoss JIRA] Commented: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Denis Maliarevich commented on JBIDE-4311:
------------------------------------------
I found that I was missing plugin org.jboss.tools.jst.web.kb that Aleksey Kazakov commited
on Friday 15, so after adding it workflow didn't go there where exception happened. By
the way <ui:param>'s name still null when getting through uppercase. So there is
no actual need in my fix, but I think it still should be added because parameter's
name is getting wrong.
I didn't find direct mentioning of such a strict behavior of w3c rules in eclipse
3.5.
krasig created the issue on 12 of May on JBT 3.1.0 Alpha, so to specify the reason
I'll revert Alexey Kazakov's changes and will try to reproduse it.
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Denis Maliarevich
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:32 a.m.
New subject: [JBoss JIRA] Commented: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Denis Maliarevich commented on JBIDE-4311:
------------------------------------------
I've tested this issue on trunk from 11 of May. The issue was reproduced.
It happaned in the same place:
During loading of testPage.xhtml VPE inserts parameters declared in <ui:param> into
<ui:composition>'s template (in our case it's testTemplate.xhtml).
testTemplate.xhtml has <div> with backgroung-image in css style. And there is an el
expressin in the url. In ui:composition tempalte #{env.skinPic} variable is compared with
ui:params name and will be replaced if matched. But ui:param's name is null thus
exception is thrown.
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Denis Maliarevich
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:27 p.m.
New subject: [JBoss JIRA] Resolved: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Denis Maliarevich resolved JBIDE-4311.
--------------------------------------
Resolution: Done
Assignee: Yura Zhishko (was: Denis Maliarevich)
Html tags and attribute names and values were changed into lowercase, null value check was
added to ui:params value replacement.
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Yura Zhishko
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:59 a.m.
New subject: [JBoss JIRA] Closed: (JBIDE-4311) vpe is broken in some cases
[
https://jira.jboss.org/jira/browse/JBIDE-4311?page=com.atlassian.jira.plu...
]
Yura Zhishko closed JBIDE-4311.
-------------------------------
Verified in JBossTools-ALL-win32-3.1.0.M1-N200905280026-H204
vpe is broken in some cases
---------------------------
Key: JBIDE-4311
URL: https://jira.jboss.org/jira/browse/JBIDE-4311
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: Visual Page Editor core
Affects Versions: 3.1.0.M1
Environment: windows
Reporter: Sergey Dzmitrovich
Assignee: Yura Zhishko
Fix For: 3.1.0.M1
testTemplate.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<body>
<div style="background-image:
url(${facesContext.externalContext.requestContextPath}/images/#{env.skinPic}) !imp
ortant;padding-left: 10px">
</div>
<ui:insert name="content>
<h:commandButton action="" value="Some button" />
</ui:insert>
</body>
</html>
testPage.xhtml :
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
xmlns:ui="http://java.sun.com/jsf/facelets"
xmlns:h="http://java.sun.com/jsf/html"
xmlns:f="http://java.sun.com/jsf/core">
<ui:composition template="testTemplate.xhtml">
<ui:param name="icon" value="system171.ico" />
<ui:define name="content">
<h:commandButton action="" value=button A" />
<h:inputText value="aaa" />
</ui:define>
</ui:composition>
</html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6009
days inactive
6025
days old
jbosstools-issues@lists.jboss.org
11 comments
5 participants
participants (5)
-
Denis Maliarevich (JIRA) -
Max Rydahl Andersen (JIRA)
-
Maxim Areshkau (JIRA)
-
Sergey Dzmitrovich (JIRA)
-
Yura Zhishko (JIRA)