3:23 p.m.
Rob Cernich created JBIDE-10763:
-----------------------------------
Summary: Project examples cache logic is faulty
Key: JBIDE-10763
URL: https://issues.jboss.org/browse/JBIDE-10763
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.M5
Reporter: Rob Cernich
Assignee: Snjezana Peco
Project examples files that are provided by plugins using a plugin URL (e.g.
platform:/plugin/plugin.id/...) fail to be refreshed. The only workaround is to delete
the cached file from the workspace's .metadata.
The following logic in ProjectUtils.getProjectExamplesFile() is incorrect:
{code:java}
if (urlModified == 0) {
if (file.exists()) {
return file;
}
}
{code}
as '0' is the same as IRemoteFileInfo.NO_LAST_MODIFIED. If urlModified ==
IRemoteFileInfo.NO_LAST_MODIFIED, the file should always be updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:37 p.m.
[
https://issues.jboss.org/browse/JBIDE-10763?page=com.atlassian.jira.plugi...
]
Snjezana Peco commented on JBIDE-10763:
---------------------------------------
JBoss Tools/JBDS doesn't have any project example provided by a plugin. Could you
provide us with any test case?
When would such project examples be refreshed? When updating the plugin including them or
...?
Project examples cache logic is faulty
--------------------------------------
Key: JBIDE-10763
URL: https://issues.jboss.org/browse/JBIDE-10763
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.M5
Reporter: Rob Cernich
Assignee: Snjezana Peco
Project examples files that are provided by plugins using a plugin URL (e.g.
platform:/plugin/plugin.id/...) fail to be refreshed. The only workaround is to delete
the cached file from the workspace's .metadata.
The following logic in ProjectUtils.getProjectExamplesFile() is incorrect:
{code:java}
if (urlModified == 0) {
if (file.exists()) {
return file;
}
}
{code}
as '0' is the same as IRemoteFileInfo.NO_LAST_MODIFIED. If urlModified ==
IRemoteFileInfo.NO_LAST_MODIFIED, the file should always be updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:07 p.m.
[
https://issues.jboss.org/browse/JBIDE-10763?page=com.atlassian.jira.plugi...
]
Rob Cernich commented on JBIDE-10763:
-------------------------------------
The following is a link to a plugin xml that can be used as an example.
https://github.com/rcernich/tools/blob/project_examples/eclipse/plugins/o...
The main problem I have is during development testing. If the file needs to be modified,
I have to nuke the workspace (or the cache in .metadata) to see the changes.
I would assume updates would be problematic as the plugin url does not contain any version
information (i.e. the system would continue using the file from the original plugin).
Let me know if you need anything else.
Rob
Project examples cache logic is faulty
--------------------------------------
Key: JBIDE-10763
URL: https://issues.jboss.org/browse/JBIDE-10763
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.M5
Reporter: Rob Cernich
Assignee: Snjezana Peco
Project examples files that are provided by plugins using a plugin URL (e.g.
platform:/plugin/plugin.id/...) fail to be refreshed. The only workaround is to delete
the cached file from the workspace's .metadata.
The following logic in ProjectUtils.getProjectExamplesFile() is incorrect:
{code:java}
if (urlModified == 0) {
if (file.exists()) {
return file;
}
}
{code}
as '0' is the same as IRemoteFileInfo.NO_LAST_MODIFIED. If urlModified ==
IRemoteFileInfo.NO_LAST_MODIFIED, the file should always be updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 p.m.
[
https://issues.jboss.org/browse/JBIDE-10763?page=com.atlassian.jira.plugi...
]
Snjezana Peco resolved JBIDE-10763.
-----------------------------------
Fix Version/s: 3.3.0.Beta1
Resolution: Done
Such project examples files aren't being cached because they are local files.
Project examples cache logic is faulty
--------------------------------------
Key: JBIDE-10763
URL: https://issues.jboss.org/browse/JBIDE-10763
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.M5
Reporter: Rob Cernich
Assignee: Snjezana Peco
Fix For: 3.3.0.Beta1
Project examples files that are provided by plugins using a plugin URL (e.g.
platform:/plugin/plugin.id/...) fail to be refreshed. The only workaround is to delete
the cached file from the workspace's .metadata.
The following logic in ProjectUtils.getProjectExamplesFile() is incorrect:
{code:java}
if (urlModified == 0) {
if (file.exists()) {
return file;
}
}
{code}
as '0' is the same as IRemoteFileInfo.NO_LAST_MODIFIED. If urlModified ==
IRemoteFileInfo.NO_LAST_MODIFIED, the file should always be updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9 a.m.
[
https://issues.jboss.org/browse/JBIDE-10763?page=com.atlassian.jira.plugi...
]
Rastislav Wagner closed JBIDE-10763.
------------------------------------
verified on ProjectUtil.java
Project examples cache logic is faulty
--------------------------------------
Key: JBIDE-10763
URL: https://issues.jboss.org/browse/JBIDE-10763
Project: Tools (JBoss Tools)
Issue Type: Bug
Components: project-examples
Affects Versions: 3.3.0.M5
Reporter: Rob Cernich
Assignee: Snjezana Peco
Fix For: 3.3.0.Beta1
Project examples files that are provided by plugins using a plugin URL (e.g.
platform:/plugin/plugin.id/...) fail to be refreshed. The only workaround is to delete
the cached file from the workspace's .metadata.
The following logic in ProjectUtils.getProjectExamplesFile() is incorrect:
{code:java}
if (urlModified == 0) {
if (file.exists()) {
return file;
}
}
{code}
as '0' is the same as IRemoteFileInfo.NO_LAST_MODIFIED. If urlModified ==
IRemoteFileInfo.NO_LAST_MODIFIED, the file should always be updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5156
days inactive
5186
days old
jbosstools-issues@lists.jboss.org
4 comments
3 participants
participants (3)
-
Rastislav Wagner (JIRA) -
Rob Cernich (JIRA)
-
Snjezana Peco (JIRA)