[ http://jira.jboss.com/jira/browse/JBIDE-1039?page=all ] Max Andersen moved RHDS-216 to JBIDE-1039: ------------------------------------------ Project: JBoss Tools (was: Red Hat Developer Studio) Key: JBIDE-1039 (was: RHDS-216) Component/s: JSF (was: jsf) Fix Version/s: 2.0.0.CR1 (was: 1.0.0.CR1) Affects Version/s: 2.0.0.Beta4 (was: 1.0.0.beta1) (was: 1.0.0.beta2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1039?page=comments#action_12380927 ] Alexey Kazakov commented on JBIDE-1039: --------------------------------------- I forgot: for JSF projects we also support some common JSF variables like request, context,... All of these types we provide in content assistent. But validation works only for seam variables. Validation works prety simple. For example we have EL: #{not empty search.results}" EL validator just check the last sigment of this EL: "search.results". If we have any context variable with name search (defined by anotation or in xml) and this class has method or property (getter or setter) 'result' then there is not error. We don't parce complicated EL like #{hotels != null and hotels.rowCount==0}" -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1039?page=comments#action_12380949 ] Alexey Kazakov commented on JBIDE-1039: --------------------------------------- 1. El Validator looks for every EL in files. e.g. <h:outputText value="{var.p"}>...</h:outputText>... 2. For each EL it makes request for our SeamELCompletionEngine. e.g. "#{var.p}" 3. Invokes SeamELCompletionEngine. That is almost the same request that Contetent Assist Procecor makes when user Ctrl+Click on "#{var1.p|}" 4. If SeamELCompletionEngine doesn't return any proposals then validator shows warning 'Illegal Expression'. So validator does not parce EL at all. What we can do: 1. Parce EL and try to resolve all variables and properties and ignore special words like "not", "null", "!=",... E.g. in "#{hotels != null and hotels.rowCount==0}" check "hotels" and "hotels.rowCount". 2. Parce a syntax of EL. E.g. "#{var1.p1 null var2.p2}" is not correct. 3. SeamELCompletionEngine should provide an information about resolved and unresolved sigments. E.g. there could be EL like "#{var1.p1.p2.p3.p4.p5.p6.p7}" and we have to provide name of a sigment (for example "p6") that we can't resolve to help validator to show an informative warning. I think 1,3 are easier than 2. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1039?page=comments#action_12380957 ] Alexey Kazakov commented on JBIDE-1039: --------------------------------------- Yes. Ok. We'are starting to implement it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira