[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12391915 ] Dima Geraskov commented on JBIDE-1482: -------------------------------------- The reason of problem is: when we expand "addres" item the TreeContentProvider gets items children - here all works fine. Then it finds the item which represents out "address" component. But we have three items which data our "address" component. As we have TreeContentProvider and not TreePathContentProvider it finds the first loaded item which data "address" component. So, we need replace our successor of TreeContentProvider by successor of TreePathContentProvider. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12392813 ] Dima Geraskov commented on JBIDE-1482: -------------------------------------- When I create new issue which fix version should I set? Max or Denis explain to me please. Because I set 2.0.1. Is it right? Or should I select "Later"? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12392817 ] Max Andersen commented on JBIDE-1482: ------------------------------------- note: for new issues that you are not sure about when should be done set the version to none. I just asked for where you wanted to have this since it was set to coding in progress but not fix version. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12392840 ] Dima Geraskov commented on JBIDE-1482: -------------------------------------- DeferredTreeContentManager and PeddingUpdateUdapter work with ITreeContentProvider. (It helps to us to postpone loading of tree item) Anybody knows the equivalent of them which works with ITreePathContentProvider instead of ITreeContentProvider? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12392846 ] Dima Geraskov commented on JBIDE-1482: -------------------------------------- Because in Tree we have TreeItems which hold Objects. We have 1 Property object "address" which represented in 3 TreeItems. TreeViewer works as I wrote in my first comment: 1) it gets children for "address" - all right 2) it finds TreeItem which represents "address" object, but we have 3 such TreeItems. And always it finds first(from top) loaded TreeItem with "address" object. When we use TreePathContentProvider it use not only selected TreeItem but all path to the selected object(path from tree). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=all ] Vitali Yemialyanchyk reassigned JBIDE-1482: ------------------------------------------- Assignee: Vitali Yemialyanchyk (was: Dima Geraskov) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=all ] Max Andersen reopened JBIDE-1482: --------------------------------- Was looking at the fix for this and what is MTreeViewer !? Looks like a copy of EPL code. What are the changes and why is it needed to have subclasses treeviewer!? I still don't get this and is it not an underlying issue in the model instead of the ui or ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12394509 ] Max Andersen commented on JBIDE-1482: ------------------------------------- 1) Hibernate Tools is LGPL hence we cannot just copy stuff from EPL without proper documentation for it. Is it from something EPL ? 2) The code looks extremely weird - like checking for methods on class and iterating potential huuge trees. 3) Is this bug really that critical to pay the price of special subclasses of a viewer ? I still don't get what the issue is...is it when you expand the whole tree with * that things does not expanded or also when you try and expand individual items ? 4) *why* cant the tree not find things correctly ? Could it be our underlying model is *wrong* ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12394522 ] Vitali Yemialyanchyk commented on JBIDE-1482: --------------------------------------------- 1) this is not exact code copy - I made some changes; I don't know the right way to handle the situation... Is it be enough put MTreeViewer into .xpl package? or should I workaround code comments; 2) I leave the same functionality as it was - just return ALL TreeItems for the OBJECT - not the first one as standard TreeViewer does; I don't know why TreeViewer return only first one cause I see that its developers think about such functionality support but didn't make it; they even create some troubles for redefine his methods; 3) If you have old code version - without my changes - you can easy reproduce the bug; take discriminator project - I will attach zip file and try to open all tree items for Configuration subtree - first time from top to buttom, then restart the workspace (or refresh) and then - from buttom to top; you'll see the difference to see the difference - bug - in KnownConfigurationsView - use TreeViewer instead of MTreeViewer - I'll attach 2 screenshots; 4) Our model is right. This is just TreeView luck. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=all ] Vitali Yemialyanchyk updated JBIDE-1482: ---------------------------------------- Attachment: reproduce the bug.jpg -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBIDE-1482?page=comments#action_12394591 ] Max Andersen commented on JBIDE-1482: ------------------------------------- 1) please move it to an .xpl with the apropriate header and it would be good if you commented on the things that is our changes (at least I would like to know since I think that MTreeViewer looks weird ,) 2) ok - now I think I understand what it is fixing. 3) Thanks for the screenshots! 4) got it.. 5) when 1 is done this issue can be closed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira