[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich updated JBIDE-11047: ------------------------------------- Description: BrowserSim cannot be run with 64-bit Java on 64-bit Windows (JBIDE-11046). The platform filters of plugins should be changed to disable BrowserSim there. (was: BrowserSim cannot be run on 64-bit Java on 64-bit Windows (JBIDE-11046). The platform filters of plugins should be changed to disable BrowserSim there.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich resolved JBIDE-11047. -------------------------------------- Resolution: Done *Resolved* A filter which excludes win32.win32.x86_64 platform is applied to the org.jboss.tools.vpe.browsersim.browser plugin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich updated JBIDE-11047: ------------------------------------- Attachment: screenshot-1.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11047: --------------------------------------------- okey - apply to beta1. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11047: ------------------------------------ My other confusion here is that the error says * org.jboss.tools.vpe.browsersim.eclipse 3.3.0 requires * org.jboss.tools.vpe.browsersim.browser 1.0.0 But when I look in the manifest [1], I see the plugin is at version 3.3.0, not 1.0.0: [1] http://anonsvn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.too..., http://anonsvn.jboss.org/repos/jbosstools/branches/jbosstools-3.3.0.Beta1... Should this (and its pom.xml) be downversioned to 1.0.0? Or should the downstream plugin [2] be changed to Require-Bundle v3.3.0 instead of v1.0.0? [2] http://anonsvn.jboss.org/repos/jbosstools/trunk/vpe/plugins/org.jboss.too..., http://anonsvn.jboss.org/repos/jbosstools/branches/jbosstools-3.3.0.Beta1... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich commented on JBIDE-11047: ------------------------------------------ The changes have been rolled back by Nick. I suppose, it is tycho-related error, because there are no errors when building the BrowserSim plugins from Eclipse. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11047: ------------------------------------ FWIW, the product build CAN be run locally, with some effort. If you're on linux, see https://svn.jboss.org/repos/devstudio/trunk/releng/org.jboss.ide.eclipse.... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-11047: --------------------------------------- solution would be to have the same filter for all plugins in the feature. I'm going to test it on local build and the submit the fix. If it is not late for Beta1, I put it in branch too. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11047: ------------------------------------ Product build still broken when trying to p2.director install for the win64 installer: {code} [java] assemble.org.eclipse.pde.build.container.feature.win32.win32.x86_64: [java] [java] main: [java] [mkdir] Created dir: /mnt/hudson_workspace/workspace/devstudio-5.0_trunk.product/jbds-build/5.0.0.Beta3/201203161357/jbds-all-package/tmp [java] [java] runDirector: [java] [java] runDirector: [java] [p2.director] Installing com.jboss.jbds.all 5.0.0.201203161409. [java] [p2.director] Installation failed. [java] [p2.director] Cannot complete the install because one or more required items could not be found. [java] [p2.director] Software being installed: JBoss Developer Studio 5.0.0.201203161409 (com.jboss.jbds.all 5.0.0.201203161409) [java] [p2.director] Missing requirement: JBoss Tools Mobile Browser Simulator 3.3.0.v20120316-1222-H870-Beta3 (org.jboss.tools.vpe.browsersim.feature.feature.group 3.3.0.v20120316-1222-H870-Beta3) requires 'org.jboss.tools.vpe.browsersim [3.3.0.v20120316-1222-H870-Beta3]' but it could not be found [java] [p2.director] Cannot satisfy dependency: [java] [p2.director] From: JBoss Developer Studio 5.0.0.201203161409 (com.jboss.jbds.all 5.0.0.201203161409) [java] [p2.director] To: org.jboss.tools.vpe.browsersim.feature.feature.group [3.3.0.v20120316-1222-H870-Beta3] [java] An error has occurred. See the log file [java] /mnt/hudson_workspace/workspace/devstudio-5.0_trunk.product/jbds-build/workspace/.metadata/.log. {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt updated JBIDE-11047: ------------------------------- Priority: Blocker (was: Major) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11047: ------------------------------------ Respinning: https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.component--vpe/ >=880 https://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.aggregate/ >=4329 https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.updatesite/ >=1788 https://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.product/ >=1024 What's the solution here? If you don't want to have more than one plugin/fragment for platform-specific stuff (win32 + other or 32-bit + 64-bit), how about having two features, which set platform filters? We could therefore include the feature in the .product only if we're on a compliant platform ...? Or... can we include the same plugin more than once in a feature, but with different platform filters? http://wiki.eclipse.org/PDE/Build/FAQ#Platform_Specific_fragments_in_Mult... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-11047: --------------------------------------- I don't like "put all what we have in one bucket and see if it works on hudson" approach, instead of manipulating two items: filter and optional flag for plugin to fix the issue. It works for Xulrunner Feature and should work for browserseam -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-11047: --------------------------------------- actually it looks like I have simplest fix for this problem. Filter should be applied to org.jboss.tools.vpe.browsersim.eclipse only. Since all eclipse extensions are declared in it and none of browserseam plugins depends on this plugin. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Denis Golovin commented on JBIDE-11047: --------------------------------------- actual problem is in org.jboss.tools.vpe.browsersim.browser plugin which mixes several platforms support in one plugin and tight coupled with org.jboss.tools.vpe.browsersim plugin. That's why filter and optional reference is not working here as I expected. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11047 at 3/21/12 11:29 PM: -------------------------------------------------------------- Because of this platform-filter: {code} Eclipse-PlatformFilter: (| (&(osgi.ws=win32)(osgi.os=win32)(osgi.arch=x86)) (&(osgi.ws=cocoa)(osgi.os=macosx) (|(osgi.arch=x86)(osgi.arch=x86_64)) ) (&(osgi.ws=gtk)(osgi.os=linux) (|(osgi.arch=x86)(osgi.arch=x86_64)) ) ) {code} I feel we need to have **TWO** plugins here: <plugin id="org.jboss.tools.vpe.browsersim" os="linux,macosx" arch="x86,x86_64" download-size="0" install-size="0" version="0.0.0" unpack="false"/> <plugin id="org.jboss.tools.vpe.browsersim.win32" os="win32" arch="x86" download-size="0" install-size="0" version="0.0.0" unpack="false"/> or <plugin id="org.jboss.tools.vpe.browsersim.x86" os="linux,macosx,win32" arch="x86" download-size="0" install-size="0" version="0.0.0" unpack="false"/> <plugin id="org.jboss.tools.vpe.browsersim.x86_64" os="linux,macosx" arch="x86_64" download-size="0" install-size="0" version="0.0.0" unpack="false"/> This would allow the browsersim.feature's feature.xml to include platform-specific plugin(s). was (Author: nickboldt): Because of this platform-filter: {code} Eclipse-PlatformFilter: (| (&(osgi.ws=win32)(osgi.os=win32)(osgi.arch=x86)) (&(osgi.ws=cocoa)(osgi.os=macosx) (|(osgi.arch=x86)(osgi.arch=x86_64)) ) (&(osgi.ws=gtk)(osgi.os=linux) (|(osgi.arch=x86)(osgi.arch=x86_64)) ) ) {code} I feel we need to have TWO plugins here: <plugin id="org.jboss.tools.vpe.browsersim" os="linux,macosx" arch="x86,x86_64" download-size="0" install-size="0" version="0.0.0" unpack="false"/> <plugin id="org.jboss.tools.vpe.browsersim.win32" os="win32" arch="x86" download-size="0" install-size="0" version="0.0.0" unpack="false"/> or <plugin id="org.jboss.tools.vpe.browsersim.x86" os="linux,macosx,win32" arch="x86" download-size="0" install-size="0" version="0.0.0" unpack="false"/> <plugin id="org.jboss.tools.vpe.browsersim.x86_64" os="linux,macosx" arch="x86_64" download-size="0" install-size="0" version="0.0.0" unpack="false"/> This would allow the browsersim.feature's feature.xml to include platform-specific plugin(s). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11047: ------------------------------------ http://hudson.qa.jboss.com/hudson/job/jbosstools-3.3_trunk.component--vpe/ >=887 {code:title=http://download.jboss.org/jbosstools/updates/nightly/core/trunk/} org.jboss.tools.vpe.browsersim.feature 3.3.0.v20120322-0921-H888-Beta3 | AbridgedTools | WebTools {code} also included in http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk...., but not YET in http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.... So... waiting on a product respin: http://hudson.qa.jboss.com/hudson/job/devstudio-5.0_trunk.product/ >=1029 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich commented on JBIDE-11047: ------------------------------------------ Downloading the build... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich updated JBIDE-11047: ------------------------------------- Attachment: windows7-duplicate-plugin-references.png On Windows 7 JBDS works fine with these two the same references: [^windows7-duplicate-plugin-references.png] I will verify OS X 64 bit tomorrow. But anyway, version="0.0.0" looks not good :( I expect problems while updating from the update site. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich commented on JBIDE-11047: ------------------------------------------ I have no idea how it can help, but if needed, we could create two fake empty fragments. XULRunner is a different matter - if current platform is not supported (and there is no XULRunner fragment), then we throw exception and properly handle it (JBIDE-10711). But in the case of BrowserSim we should not load the BrowserSim plugins at all. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich edited comment on JBIDE-11047 at 3/23/12 10:07 AM: -------------------------------------------------------------------- I have no idea how it can help, but if needed, we could create two fake empty fragments. XULRunner is a different matter - if current platform is not supported (and there is no XULRunner -fragment- plugin), then we throw exception and properly handle it (JBIDE-10711). But in the case of BrowserSim we should not load the BrowserSim plugins at all. was (Author: yradtsevich): I have no idea how it can help, but if needed, we could create two fake empty fragments. XULRunner is a different matter - if current platform is not supported (and there is no XULRunner fragment), then we throw exception and properly handle it (JBIDE-10711). But in the case of BrowserSim we should not load the BrowserSim plugins at all. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt edited comment on JBIDE-11047 at 3/23/12 12:20 PM: -------------------------------------------------------------- I don't imagine going from feature a.b.c to a.b.(c+1) will be a problem so long as there's a working plugin (org.jboss.tools.vpe.browsersim.eclipse_*.jar) installed into JBT or JBDS which works as expected. To test an update, take JBDS (eg., http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk....) and point it at the nightly JBT or JBDS sites, then install whatever update to the browsersim feature is available. http://download.jboss.org/jbosstools/updates/nightly/core/trunk/ http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.... After that you should have a newer org.jboss.tools.vpe.browsersim.eclipse_*.jar on disk and listed in the Help > About dialog. was (Author: nickboldt): I don't imagine going from feature a.b.c to a.b.(c+1) will be a problem so long as there's a working plugin (org.jboss.tools.vpe.browsersim.eclipse_*.jar) installed into JBT or JBDS which works as expected. To test an update, take JBDS and point it at the nightly JBT or JBDS sites, then install whatever update to the browsersim feature is available. http://download.jboss.org/jbosstools/updates/nightly/core/trunk/ http://www.qa.jboss.com/binaries/RHDS/builds/staging/devstudio-5.0_trunk.... After that you should have a newer org.jboss.tools.vpe.browsersim.eclipse_*.jar on disk and listed in the Help > About dialog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Nick Boldt commented on JBIDE-11047: ------------------------------------ SOLVED: {code} <build> <plugins> <plugin> <groupId>org.eclipse.tycho.extras</groupId> <artifactId>tycho-source-feature-plugin</artifactId> <version>${tychoExtrasVersion}</version> <executions> <execution> <id>source-feature</id> <phase>package</phase> <goals> <goal>source-feature</goal> </goals> </execution> </executions> <configuration> <excludes> <plugin id="org.jboss.tools.vpe.browsersim.eclipse"/> <!-- <feature id="sourcefeature.feature.nosource"/> --> </excludes> </configuration> </plugin> ... {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Mickael Istria commented on JBIDE-11047: ---------------------------------------- Here are some alternatives approach for this problem that would be less intrusive: * Display a pop-up when using Win on 64 saying "Sorry, BrowserSim not supported on Win 64". So that we have a UI that is consistent across all platforms, and Win 64 users do know this feature exist for other platforms (that won't be the case if we hide all entry points). Although they won't be able to get the feature, they'll probably be curious about learning about it * Using the action/command enablement to make this button "grey" on Win 64. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11047: --------------------------------------------- especially since in future 64 bit could easily be considered something that could work thus seems overkill to do this split IMO. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11047: --------------------------------------------- Yahor can do that - but needs to have these changes about plugin split reverted, right ? Can you do that and then hand it to Yahor ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11047: --------------------------------------------- dont understand why it have to wait after the ui fixes are done since rolling back to the old gives similar behavior (win64 shows browser as "cannot load") Anyway, back to Yahor on making the UI react dependent on OS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen commented on JBIDE-11047: --------------------------------------------- Yes, "cannot load" is what we want/prefer over this complex filtering for such a little feature limitation. Yahor can add code that makes that "cannot load" prettier. Removal of filtering does not have to wait. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Yahor Radtsevich resolved JBIDE-11047. -------------------------------------- Resolution: Done Resolved as 'Won't Fix'. The 'prettier "cannot load"' behavior will be implemented in the scope of JBIDE-11498. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-11047?page=com.atlassian.jira.plugi... ] Vlado Pakan closed JBIDE-11047. ------------------------------- -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira