[
https://issues.jboss.org/browse/JBIDE-18820?page=com.atlassian.jira.plugi...
]
Mickael Istria edited comment on JBIDE-18820 at 11/25/14 4:59 AM:
------------------------------------------------------------------
{code}[~mickael_istria] I and [~fbricon] did consider adding a jboss tools branding plugin
like we have for jbds but A) how do we ensure that is included AND activated when
foundation loads its settings ?! B) how do we ensure it is *NOT* active when devstudio is
running ?{code}
A) tricky... We need a bundle to provide this ide-config.properties for anything (even
tests), so it's difficult to move this plugin downstream. Which components do need
these ide-config.properties expect Central? If only Central requires it, then maybe this
would be a good/better place to host a JBoss Tools branding plugin with a good
ide-config.properties configuration
B) We just don't put it in JBDS. It would be a separate feature that we don't
include. In case someone includes 2 different providers for ide-config.properties, we show
an error.
was (Author: maxandersen):
[~nickboldt] none of this *requires* it to be in parent pom. Putting this blindly in
parent pom makes it forced that *Everything* need to rebuild to get this info. This is
why JBIDE-13452 happened, was it not ? The *missing step* here is that foundation was not
upversioned/updated - something that would *need* to happen anyway for this to work. So
putting it in parent pom changes nothing if foundation plugin is not updated and version
bumped.
As you say your self it does not matter that the version is in the parent pom if the
foundation plugin is not rebuilt, but the version of the plugin also need to change. Hence
the version should just stay near it instead of bubble up as a global value that is listed
as something you can rely on in other modules ...which you cannot or rather should not
since it is *not* guaranteed to be right unless we are doing a full complete rebuild of
*everything*.
[~mickael_istria] I and [~fbricon] did consider adding a jboss tools branding plugin like
we have for jbds but A) how do we ensure that is included AND activated when foundation
loads its settings ?! B) how do we ensure it is *NOT* active when devstudio is running ?
It is a *false* assumption that just because foundation has a bug fix that it needs to
trigger a full rebuild of everything - this is the thing we need to stop depending on. If
this is the case then none of this would be an issue.
define how to handle ide.properties and avoid parent pom to always
change
-------------------------------------------------------------------------
Key: JBIDE-18820
URL:
https://issues.jboss.org/browse/JBIDE-18820
Project: Tools (JBoss Tools)
Issue Type: Task
Components: build
Reporter: Max Rydahl Andersen
As illustrated in JBIDE-18806 our current setup of how ide.properties and project
versioning are not working or at least we seem to not get it updated right.
Current workaround applied is that parent pom now again defines the global version even
though this is not reliable at all since not all plugins will be rebuilt. (see JBIDE-13452
for earlier attempts on this)
Opening this jira to make sure we walkthrough and write down which values should be in
ide.properties and what level (4.2.0.CR1, 4.2.0 or 4.2. etc), when they get updated
(hopefully rarely) and how to avoid parent pom from always having to respin because of a
maintanence release.
--
This message was sent by Atlassian JIRA
(v6.3.8#6338)