[ https://issues.jboss.org/browse/JBIDE-26283?page=com.atlassian.jira.plugi... ] Andre Dietisheim edited comment on JBIDE-26283 at 8/6/18 8:41 AM: ------------------------------------------------------------------ [~nickboldt]: referring to your [findings|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=136...]): * *Eclipse source references* are ignored and thus shouldn't trigger a baseline comparison failure (as found out by [~jeffmaury] in his [comment|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=1361...]: https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src... {code} // this is common attribute not supported by Tycho yet ignoredKeys.add(new Name("Eclipse-SourceReferences")); {code} * The other change in *properties* is in a comment abd shouldn't trigger a failure in baseline comparison. Comparison is done based on keys and values, where comments should be ignored: https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src... So I still dont get why the baseline checks fails. Thoughts? was (Author: adietish): [~nickboldt]: referring to your [findings|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=136...]: * *Eclipse source references* are ignored and thus shouldn't trigger a baseline comparison failure (as found out by [~jeffmaury] in his [comment|https://issues.jboss.org/browse/JBIDE-26283?focusedCommentId=1361...]: https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src... {code} // this is common attribute not supported by Tycho yet ignoredKeys.add(new Name("Eclipse-SourceReferences")); {code} * The other change in *properties* is in a comment abd shouldn't trigger a failure in baseline comparison. Comparison is done based on keys and values, where comments should be ignored: https://github.com/eclipse/tycho/blob/master/tycho-artifactcomparator/src... So I still dont get why the baseline checks fails. Thoughts? -- This message was sent by Atlassian JIRA (v7.5.0#75005)