[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-13095: ------------------------------------- Attachment: id-rsa-warning.png id-rsa-listed-in-preferences.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-13095: ------------------------------------- Attachment: id-rsa-listed-in-preferences.png -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim updated JBIDE-13095: ------------------------------------- Steps to Reproduce: # ASSERT: make sure you have an account on OpenShift and OpenShift Explorer # ASSERT: make sure you have a id_rsa key-pair in your <home>\.ssh\id_rsa(.pub) # ASSERT: make sure id_rsa is listed in the private keys of your SSH2 preferences in Eclipse ( # EXEC: pick "Manage SSH keys..." from context menu in OpenShift Explorer # EXEC: in the upcoming dialog: choose "Add Existing..." # EXEC: Browse and choose "id_rsa" Result: The "Public Key" text field is decorated with a warning that tells you that the private key for your public key is eventually not listed in the Eclipse ssh preferences. !id-rsa-warning.png! Even though the id_rsa is listed in the preferences: !id-rsa-listed-in-preferences.png! was: # ASSERT: make sure you have an account on OpenShift and OpenShift Explorer # ASSERT: make sure you have a id_rsa key-pair in your <home>\.ssh\id_rsa(.pub) # ASSERT: make sure id_rsa is listed in the private keys of your SSH2 preferences in Eclipse ( # EXEC: pick "Manage SSH keys..." from context menu in OpenShift Explorer # EXEC: in the upcoming dialog: choose "Add Existing..." # EXEC: Browse and choose "id_rsa" Result: The "Public Key" text field is decorated with a warning that tells you that the private key for your public key is eventually not listed in the Eclipse ssh preferences. id-rsa-warning.png Even though the id_rsa is listed in the preferences: !id-rsa-listed-in-preferences.png! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-13095: ------------------------------------------ set to fixVersion 4.0.0.CR2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-13095: ------------------------------------------ Apparently both variants exists but *.ssh* prevails on newer Windows Systems. You can see this in the following codes: {code:title=org.eclipse.jsch.internal.core.IConstants} public static final String SSH_DEFAULT_HOME=".ssh"; //$NON-NLS-1$ public static final String SSH_OLD_DEFAULT_WIN32_HOME="ssh"; //$NON-NLS-1$ {code} {code:title=org.eclipse.jsch.internal.core.PreferenceInitializer} static{ SSH_HOME_DEFAULT=System.getProperty(IConstants.SYSTEM_PROPERTY_USER_HOME); if(SSH_HOME_DEFAULT!=null){ SSH_OLD_WIN32_HOME_DEFAULT=SSH_HOME_DEFAULT+File.separator +IConstants.SSH_OLD_DEFAULT_WIN32_HOME; SSH_HOME_DEFAULT=SSH_HOME_DEFAULT+File.separator +IConstants.SSH_DEFAULT_HOME; } } {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim commented on JBIDE-13095: ------------------------------------------ Xavier Coulon reviewed the PR's: [6:20:08 PM CEST] André Dietisheim: so plz one review https://github.com/jbosstools/jbosstools-openshift/pull/23 and https://github.com/jbosstools/jbosstools-openshift/pull/24 [6:21:54 PM CEST] Xavier Coulon: that looks good to me -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Max Rydahl Andersen updated JBIDE-13095: ---------------------------------------- Labels: respin-a (was: ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Stefan Bunciak closed JBIDE-13095. ---------------------------------- Verified with JBoss Developer Studio Version: 6.0.0.CR1 Build id: CR1-v20121125-1229-B133 Build date: 20121125-1229. Running on Windows 8 32bit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Andre Dietisheim resolved JBIDE-13095. -------------------------------------- Resolution: Done closing after having added release notes -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Isaac Rooskov updated JBIDE-13095: ---------------------------------- Release Notes Text: When adding SSH public keys to OpenShift, they are verified to ensure the matching private key is listed in Eclipse SSH preferences. Previously when performing this task on a Windows operating system, a user would be warned in error when adding default rsa or dsa keys (id_dsa, id_rsa). This has been corrected so that the false alert is not generated or displayed. (was: When adding SSH public keys to OpenShift, they are verified to ensure the matching private key is listed in Eclipse SSH preferences. Previously when performing this task on a Windows operating system, a user would be warned in error when adding default rsa or dsa keys (id_dsa, id_rsa). This has been corrected and no false alerts are generated or displayed.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBIDE-13095?page=com.atlassian.jira.plugi... ] Isaac Rooskov closed JBIDE-13095. --------------------------------- Resolution: Done Reclosing now that release note status has been set -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira